Bug 2068693 - Review Request: qview - Practical and minimal image viewer
Summary: Review Request: qview - Practical and minimal image viewer
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Gustavo Costa
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-03-26 01:02 UTC by Justin Zobel
Modified: 2022-05-07 04:27 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-04-28 05:51:09 UTC
Type: Bug
Embargoed:
xfgusta: fedora-review+


Attachments (Terms of Use)

Description Justin Zobel 2022-03-26 01:02:03 UTC
SPEC: https://pagure.io/qview_rpm/raw/master/f/qview.spec
SRPM: https://pagure.io/qview_rpm/raw/master/f/qview-5.0-1.fc36.src.rpm

Description: Practical and minimal image viewer

Fedora Review only issue:
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://docs.fedoraproject.org/en-US/packaging-guidelines/

Comment 1 Gustavo Costa 2022-04-16 22:54:32 UTC
Hi Justin. This is my first attempt to do an official review, if you're not happy with something let me know.

Some changes I will propose are to improve the maintainability of the spec. You can see all the changes I made here: https://xfgusta.fedorapeople.org/review/qview.spec.

--- Define an appid ---

It's useful to define the application ID as we will be using it a few times.

> %global appid com.interversehq.qView

--- Use URL instead of Url ---

I can't really tell you if "Url" is valid, but most packages use "URL". Pagure, for instance, doesn't even highlight "Url".

> URL:            https://interversehq.com/qview

--- SourceURL ---

I recommend you to use the following SourceURL [1], because it makes it easier for you to bump the version of the package.

> Source0:        https://github.com/jurplel/%{name}/archive/%{version}/%{name}-%{version}.tar.gz

You will need to update the %autosetup as well:

> %autosetup -n qView-%{version}

--- BuildRequires make ---

Since you are using the make build system, you need to add it as a build dependency.

> BuildRequires:  make

--- Fix unowned directory ---

qView installs its icons in the /usr/share/icons/hicolor directory, which is provided by hicolor-icon-theme [2]

> Requires:       hicolor-icon-theme

--- Use kf5-kimageformats instead of kimageformats ---

It should be kf5-kimageformats instead of kimageformats [3]

> Requires:       kf5-kimageformats

--- Use qt5-qtimageformats instead of qt5-imageformats ---

It should be qt5-qtimageformats instead of qt5-imageformats [4]

> Requires:       qt5-qtimageformats

-- Use a better description ---

I think the description used in the flatpak version [5] is better than copying the summary. I would recommend it:

> %description
> qView is a Qt image viewer designed with minimalism and usability in mind. It
> is designed to get out of your way and let you view your image without excess
> GUI elements, while also being flexible enough for everyday use.

--- Check the AppData and Desktop Entry ---

You must validate the metainfo file using appstream-util [6]. You can also use desktop-file-validate to check the desktop entry file and install it [7].

> BuildRequires:  libappstream-glib

> %check
> appstream-util validate-relax --nonet %{buildroot}/%{_metainfodir}/%{appid}.appdata.xml
> desktop-file-validate %{buildroot}/%{_datadir}/applications/%{appid}.desktop

Also, remove the desktop-file-install in the %install section.

--- Add a doc. file ---

The README.md file contains some relevant information, such as a link to the changelog [8]

> %doc README.md

--- Use the appid and globs ---

> %{_datadir}/applications/%{appid}.desktop
> %{_metainfodir}/%{appid}.appdata.xml

You can also use glob here

> %{_datadir}/icons/hicolor/*/apps/*

References:

1. https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#_git_tags
2. https://docs.fedoraproject.org/en-US/packaging-guidelines/UnownedDirectories
3. https://src.fedoraproject.org/rpms/kf5-kimageformats
4. https://src.fedoraproject.org/rpms/qt5-qtimageformats
5. https://flathub.org/apps/details/com.interversehq.qView
6. https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/#_app_data_validate_usage
7. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_file_install_usage
8. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_documentation

Comment 2 Justin Zobel 2022-04-17 01:35:58 UTC
Thanks for all the feedback, updates done.

SPEC: https://pagure.io/qview_rpm/raw/master/f/qview.spec
SRPM: https://pagure.io/qview_rpm/raw/master/f/qview-5.0-1.fc36.src.rpm

Comment 3 Gustavo Costa 2022-04-17 05:26:08 UTC
Looks good! Package approved.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "*No copyright* GNU General Public
     License, Version 3". 76 files have unknown license. Detailed output of
     licensecheck in /home/gusta/Desktop/2068693-qview/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
     desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: There are rpmlint messages (see attachment).
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Cannot parse rpmlint output:


Rpmlint (debuginfo)
-------------------
Cannot parse rpmlint output:



Rpmlint (installed packages)
----------------------------
Cannot parse rpmlint output:


Source checksums
----------------
https://github.com/jurplel/qView/releases/download/5.0/qView-5.0.tar.gz :
  CHECKSUM(SHA256) this package     : 2d09b0bd0c439aacbd02613b0dd5c2e9f8f5458739717f86288addcdb6225245
  CHECKSUM(SHA256) upstream package : 2d09b0bd0c439aacbd02613b0dd5c2e9f8f5458739717f86288addcdb6225245


Requires
--------
qview (rpmlib, GLIBC filtered):
    hicolor-icon-theme
    kf5-kimageformats
    libQt5Core.so.5()(64bit)
    libQt5Core.so.5(Qt_5)(64bit)
    libQt5Core.so.5(Qt_5.15)(64bit)
    libQt5Gui.so.5()(64bit)
    libQt5Gui.so.5(Qt_5)(64bit)
    libQt5Network.so.5()(64bit)
    libQt5Network.so.5(Qt_5)(64bit)
    libQt5Widgets.so.5()(64bit)
    libQt5Widgets.so.5(Qt_5)(64bit)
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    qt5-qtimageformats
    qt5-qtsvg
    rtld(GNU_HASH)

qview-debuginfo (rpmlib, GLIBC filtered):

qview-debugsource (rpmlib, GLIBC filtered):



Provides
--------
qview:
    application()
    application(com.interversehq.qView.desktop)
    metainfo()
    metainfo(com.interversehq.qView.appdata.xml)
    mimehandler(application/photoshop)
    mimehandler(application/psd)
    mimehandler(application/x-krita)
    mimehandler(application/x-navi-animation)
    mimehandler(application/x-photoshop)
    mimehandler(image/aces)
    mimehandler(image/apng)
    mimehandler(image/avif)
    mimehandler(image/avif-sequence)
    mimehandler(image/bmp)
    mimehandler(image/gif)
    mimehandler(image/heic)
    mimehandler(image/heif)
    mimehandler(image/icns)
    mimehandler(image/jpeg)
    mimehandler(image/jpg)
    mimehandler(image/jxl)
    mimehandler(image/openraster)
    mimehandler(image/png)
    mimehandler(image/psd)
    mimehandler(image/sgi)
    mimehandler(image/svg+xml)
    mimehandler(image/tiff)
    mimehandler(image/vnd.adobe.photoshop)
    mimehandler(image/vnd.radiance)
    mimehandler(image/vnd.wap.wbmp)
    mimehandler(image/vnd.zbrush.pcx)
    mimehandler(image/webp)
    mimehandler(image/x-exr)
    mimehandler(image/x-icon)
    mimehandler(image/x-pcx)
    mimehandler(image/x-pic)
    mimehandler(image/x-portable-bitmap)
    mimehandler(image/x-portable-graymap)
    mimehandler(image/x-portable-pixmap)
    mimehandler(image/x-rgb)
    mimehandler(image/x-sgi-bw)
    mimehandler(image/x-sgi-rgba)
    mimehandler(image/x-sun-raster)
    mimehandler(image/x-tga)
    mimehandler(image/x-win-bitmap)
    mimehandler(image/x-xbitmap)
    mimehandler(image/x-xcf)
    mimehandler(image/x-xpixmap)
    qview
    qview(x86-64)

qview-debuginfo:
    debuginfo(build-id)
    qview-debuginfo
    qview-debuginfo(x86-64)

qview-debugsource:
    qview-debugsource
    qview-debugsource(x86-64)



Generated by fedora-review 0.8.0 (e988316) last change: 2022-04-07
Command line :/usr/bin/fedora-review -b 2068693
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, C/C++, Shell-api
Disabled plugins: R, SugarActivity, Haskell, fonts, Python, PHP, Ocaml, Perl, Java
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

Comment 4 Gwyn Ciesla 2022-04-18 15:37:23 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/qview

Comment 5 Fedora Update System 2022-04-20 02:54:04 UTC
FEDORA-2022-10a42d07fe has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-10a42d07fe

Comment 6 Fedora Update System 2022-04-20 02:54:05 UTC
FEDORA-2022-771d14e771 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2022-771d14e771

Comment 7 Fedora Update System 2022-04-20 02:54:06 UTC
FEDORA-2022-c86a4391fa has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-c86a4391fa

Comment 8 Fedora Update System 2022-04-20 15:30:57 UTC
FEDORA-2022-10a42d07fe has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-10a42d07fe \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-10a42d07fe

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2022-04-20 20:25:09 UTC
FEDORA-2022-771d14e771 has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-771d14e771 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-771d14e771

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2022-04-20 20:26:20 UTC
FEDORA-2022-c86a4391fa has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-c86a4391fa \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-c86a4391fa

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2022-04-28 05:51:09 UTC
FEDORA-2022-c86a4391fa has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 12 Fedora Update System 2022-04-28 05:54:08 UTC
FEDORA-2022-771d14e771 has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2022-05-07 04:27:52 UTC
FEDORA-2022-10a42d07fe has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.