Red Hat Bugzilla – Bug 206875
Review Request: libgadu - Gadu-Gadu protocol support library
Last modified: 2007-11-30 17:11:43 EST
Spec URL: http://rpm.greysector.net/extras/libgadu.spec
SRPM URL: http://rpm.greysector.net/extras/libgadu-1.7.0-1.src.rpm
libgadu is intended to make it easy to add Gadu-Gadu communication
support to your software.
My ekg package is already tested and ready to build against this. I only need to
cvs commit && make tag build. gg2 (currently under review in bug 205136) doesn't
require any changes.
I'll take it.
W: libgadu-devel no-documentation
(should be ignored)
* package meets Packaging (Naming) Guidelines
* package is licensed by LGPL open-source compatible license
* spec file is legible
* md5sums are matching (152180afbbad584017592a3021aac97a)
* package successfully compiles on x86_64
* BRs are good (mock builds fine)
* no locales
* proper %post and %postun
* not relocatable
* package doesn't create any directories
* every %files includes %defattr
* proper %clean section
* header, .pc and .so files are in -devel
* devel requires the base package using a fully versioned dependency
* .la archives removed
* no gui
Everything looks good.
Don't forget to remove libgadu from ekg.spec.
> * BRs are good (mock builds fine)
No, they are not. autoconf and automake are superflous.
Oops, I forgot to mention, that it would be better to pass
`--disable-dependency-tracking' to %configure macro. This speeds up a bit
building and makes output more legible.
(In reply to comment #4)
> No, they are not. autoconf and automake are superflous.
Okay, my fault... I only tested if mock builds fine, didn't check for
Imported and built for devel. FC-5 branch requested. ekg updated and built for
devel. FC-5 rebuild pending. I'll check the BRs later.
According to http://fedoraproject.org/wiki/Extras/FullExceptionList automake and
autoconf are NOT in the minimal buildroot, so they are NOT redundant. Dawid,
feel free to prove me wrong.
Well, you don't regenerate configure script nor Makefile.in files. I don't see a
reason to BR automake or autoconf ;-) Package builds fine without them.
BTW I noticed some differences in libgadu.pc file when someone recompiles
libgadu with or without pkgconfig. What is more, there is to much bloat (I mean
including whole CFLAGS variable from build system). libgadu.pc from ekg's
libgadu-devel subpackage looks more sane to me :)
You are correct. I'll fix this later. Thanks!