Red Hat Bugzilla – Bug 206877
Review Request: bzr-gtk - Bazaar plugin for GTK+ interfaces to most Bazaar operations
Last modified: 2007-11-30 17:11:43 EST
Spec URL: Bazaar plugin for GTK+ interfaces to most Bazaar operations
SRPM URL: http://togami.com/~warren/fedora/bzr-gtk-0.10.0-1.src.rpm
bzr-gtk is a plugin for Bazaar that aims to provide GTK+ interfaces to most Bazaar operations.
E: bzr-gtk description-line-too-long
W: mixed use of spaces and tabs (ignore)
Lots of errors due to non-executable-script
__init__.py 0644, bzrkapp.py
__init__.py 0644, graphcell.py 0644, graph.py 0644, diffwin.py 0644,
Spec file looks okay
building now in mock
E: bzr-gtk non-executable-script
Does this really need to be executable?
And how rpmlint seeing this as different from the many other py files that it
isn't complaining about?
Created attachment 136493 [details]
New spec file
This spec file addresses every warning and error rpmlint was throwing up on my
buildsys. It builds cleanly in mock.
Making the permissions on those scripts 755 seems to be not needed at all. Most
of similar installed files have 644 permissions, and this software works fine.
These scripts are not meant to be run directly.
Do we really need to do this?
Just remove the shebang (#!/usr/bin/python) from __init__.py to get rid of this
rpmlint error. Maybe you can convince upstream to do the same, if it's really
Requesting approval of the package in #3 which fixes the .src.rpm rpmlint
warnings. The opinion of fedora-extras-list is the permission issues are not a
problem at all. Removal of shebang is not required either.
Spec file in US-English
Consistent use of macros
upstream and package md5sums match
the software installs and deinstalls cleanly
no dupes in the rpms
contains a %clean section
builds cleanly in mock
rpmlint gives plenty of warnings and errors, but they can be ignored
follows python packaging guidelines
Could you please close this bug if it has been imported?