Bug 2069287 - Two annotations for VM Template provider name
Summary: Two annotations for VM Template provider name
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Container Native Virtualization (CNV)
Classification: Red Hat
Component: SSP
Version: 4.10.0
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
: 4.11.0
Assignee: Karel Šimon
QA Contact: Roni Kishner
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-03-28 16:34 UTC by Hilda Stastna
Modified: 2023-11-13 08:11 UTC (History)
3 users (show)

Fixed In Version: kubevirt-ssp-operator-container-v4.11.0-18
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-09-14 19:29:36 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker CNV-17257 0 None None None 2022-04-04 06:27:09 UTC
Red Hat Issue Tracker CNV-17373 0 None None None 2023-11-13 08:11:23 UTC
Red Hat Issue Tracker CNV-17658 0 None None None 2023-11-13 08:11:20 UTC
Red Hat Product Errata RHSA-2022:6526 0 None None None 2022-09-14 19:30:45 UTC

Description Hilda Stastna 2022-03-28 16:34:23 UTC
Description of problem:
There are two annotations to look at when checking the VM Template provider name in the yaml:
"openshift.io/provider-display-name" annotation that usually "tells" you "KubeVirt",
vs.
"template.kubevirt.io/provider" that tells you "Red Hat".
These two sources of truth are confusing.

Version-Release number of selected component (if applicable):

How reproducible:
always

Steps to Reproduce:
1. Check the upstream vs. downstram VM Template's yaml:
Check the annotations under template?.metadata?.annotations

Actual results:
There are two sources of truth for checking the VM Template provider name, and that's confusing.

Expected results:
There are more ways how to solve the problem: to get rid of one of those annotations, or to edit "openshift.io/provider-display-name" in downstream.

Additional info:
There is only "openshift.io/provider-display-name" annotation in the upstream VM Templates' yaml, "template.kubevirt.io/provider" is added in downstream.

Comment 1 Yaacov Zamir 2022-03-29 06:06:16 UTC
Hi all,
Component is SSP because the "openshift.io/provider-display-name" label is set by common-templates, please move to the correct component if needed.

Moving version to 4.10 since this is reproducible in 4.10

Comment 2 Dominik Holler 2022-03-30 11:38:10 UTC
So let's set 'openshift.io/provider-display-name' in midsteam to the value of 'template.kubevirt.io/provider' .

Comment 4 Roni Kishner 2022-04-18 09:26:03 UTC
Verified on ssp-operator v4.11.0-22

Comment 7 errata-xmlrpc 2022-09-14 19:29:36 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: OpenShift Virtualization 4.11.0 Images security and bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:6526


Note You need to log in before you can comment on or make changes to this bug.