Description of problem:
The ingress operator has unnecessary logic to delete the finalizer that earlier versions of the operator added to LoadBalancer-type services. This finalizer has not been necessary since OpenShift 4.2, when the DNSRecord CRD was added (see <https://github.com/openshift/cluster-ingress-operator/pull/251/commits/5043726b6956401551087af5729b40db73733c5b>). OpenShift 4.8 removed the logic that added the finalizer and added logic to remove the finalizer if it was present (see bug 1914127 and <https://github.com/openshift/cluster-ingress-operator/pull/549/commits/081081a3eb2aea672319c047eba0623b8db41c44>). Thus on OpenShift versions since OpenShift 4.9, this code is no longer needed and should be deleted.
OpenShift release version:
OpenShift 4.9 and later.
Steps to Reproduce (in detail):
1. Look at https://github.com/openshift/cluster-ingress-operator/blob/master/pkg/operator/controller/ingress/load_balancer_service.go and search for "deleteLoadBalancerServiceFinalizer".
The deleteLoadBalancerServiceFinalizer method is still defined: https://github.com/openshift/cluster-ingress-operator/blob/77baf4309062b83199a806d466955b1bf071e19c/pkg/operator/controller/ingress/load_balancer_service.go#L471-L493
The deleteLoadBalancerServiceFinalizer method is gone.
Impact of the problem:
The logic adds negligible overhead. The main impact is that it complicates the code base.
checked the code and the deleteLoadBalancerServiceFinalizer method is gone.
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.
For information on the advisory (Important: OpenShift Container Platform 4.11.0 bug fix and security update), and where to find the updated
files, follow the link below.
If the solution does not work for you, open a new bug report.