Bug 2069457 - Ingress operator has superfluous finalizer deletion logic for LoadBalancer-type services
Summary: Ingress operator has superfluous finalizer deletion logic for LoadBalancer-ty...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Networking
Version: 4.9
Hardware: Unspecified
OS: Unspecified
medium
low
Target Milestone: ---
: 4.11.0
Assignee: Miciah Dashiel Butler Masters
QA Contact: Hongan Li
URL:
Whiteboard:
Depends On:
Blocks: 2082161
TreeView+ depends on / blocked
 
Reported: 2022-03-28 22:28 UTC by Miciah Dashiel Butler Masters
Modified: 2022-08-10 11:02 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Cause: The ingress operator had unnecessary logic to remove a finalizer that the operator had added to LoadBalancer-type services it had created in previous versions of OpenShift. Consequence: The unnecessary finalizer removal logic has no effect in OpenShift 4.9 and newer. Fix: The finalizer removal logic was removed. Result: The ingress operator no longer includes this unnecessary logic.
Clone Of:
Environment:
Last Closed: 2022-08-10 11:02:32 UTC
Target Upstream Version:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift cluster-ingress-operator pull 729 0 None Merged Bug 2069457: Delete LoadBalancer-type service finalizer logic 2022-03-31 15:22:08 UTC
Red Hat Product Errata RHSA-2022:5069 0 None None None 2022-08-10 11:02:50 UTC

Description Miciah Dashiel Butler Masters 2022-03-28 22:28:23 UTC 
Description of problem:

The ingress operator has unnecessary logic to delete the finalizer that earlier versions of the operator added to LoadBalancer-type services.  This finalizer has not been necessary since OpenShift 4.2, when the DNSRecord CRD was added (see <https://github.com/openshift/cluster-ingress-operator/pull/251/commits/5043726b6956401551087af5729b40db73733c5b>).  OpenShift 4.8 removed the logic that added the finalizer and added logic to remove the finalizer if it was present (see bug 1914127 and <https://github.com/openshift/cluster-ingress-operator/pull/549/commits/081081a3eb2aea672319c047eba0623b8db41c44>).  Thus on OpenShift versions since OpenShift 4.9, this code is no longer needed and should be deleted.  


OpenShift release version:

OpenShift 4.9 and later.


Steps to Reproduce (in detail):

1. Look at https://github.com/openshift/cluster-ingress-operator/blob/master/pkg/operator/controller/ingress/load_balancer_service.go and search for "deleteLoadBalancerServiceFinalizer".


Actual results:

The deleteLoadBalancerServiceFinalizer method is still defined: https://github.com/openshift/cluster-ingress-operator/blob/77baf4309062b83199a806d466955b1bf071e19c/pkg/operator/controller/ingress/load_balancer_service.go#L471-L493


Expected results:

The deleteLoadBalancerServiceFinalizer method is gone.    


Impact of the problem:

The logic adds negligible overhead.  The main impact is that it complicates the code base.
Comment 3 Hongan Li 2022-04-25 01:39:18 UTC 
checked the code and the deleteLoadBalancerServiceFinalizer method is gone.
Comment 6 errata-xmlrpc 2022-08-10 11:02:32 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: OpenShift Container Platform 4.11.0 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:5069
Note You need to log in before you can comment on or make changes to this bug.