Bug 2069537 - python-migen fails to build with Python 3.11: ValueError: Cannot extract clock domain name from code, need to specify.
Summary: python-migen fails to build with Python 3.11: ValueError: Cannot extract cloc...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: python-migen
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Gabriel Somlo
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 2099004 (view as bug list)
Depends On:
Blocks: PYTHON3.11 F37FTBFS F37FailsToInstall
TreeView+ depends on / blocked
 
Reported: 2022-03-29 06:28 UTC by Tomáš Hrnčiar
Modified: 2022-07-14 01:45 UTC (History)
4 users (show)

Fixed In Version: python-migen-0.9.2-14.20220705git0fb9173.fc36
Clone Of:
Environment:
Last Closed: 2022-07-05 22:42:50 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Tomáš Hrnčiar 2022-03-29 06:28:33 UTC
python-migen fails to build with Python 3.11.0a6.

test_local_cd (migen.test.test_examples.TestExamplesBasic) ... Traceback (most recent call last):
  File "/builddir/build/BUILD/migen-9a0be7a4210ff96043412539eb5388659b81831d/examples/basic/local_cd.py", line 18, in <module>
    mm = MultiMod()
         ^^^^^^^^^^
  File "/builddir/build/BUILD/migen-9a0be7a4210ff96043412539eb5388659b81831d/examples/basic/local_cd.py", line 14, in __init__
    self.submodules.foo = CDM()
                          ^^^^^
  File "/builddir/build/BUILD/migen-9a0be7a4210ff96043412539eb5388659b81831d/examples/basic/local_cd.py", line 9, in __init__
    self.clock_domains.cd_sys = ClockDomain(reset_less=True)
                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/builddir/build/BUILD/migen-9a0be7a4210ff96043412539eb5388659b81831d/migen/fhdl/structure.py", line 710, in __init__
    raise ValueError("Cannot extract clock domain name from code, need to specify.")
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
ValueError: Cannot extract clock domain name from code, need to specify.
ERROR
test_memory (migen.test.test_examples.TestExamplesBasic) ... ok
test_namer (migen.test.test_examples.TestExamplesBasic) ... ok
test_psync (migen.test.test_examples.TestExamplesBasic) ... ok
test_record (migen.test.test_examples.TestExamplesBasic) ... ok
test_reslice (migen.test.test_examples.TestExamplesBasic) ... ok
test_tristate (migen.test.test_examples.TestExamplesBasic) ... ok
test_two_dividers (migen.test.test_examples.TestExamplesBasic) ... ok
test_basic1 (migen.test.test_examples.TestExamplesSim) ... ok
test_basic2 (migen.test.test_examples.TestExamplesSim) ... ok
test_memory (migen.test.test_examples.TestExamplesSim) ... ok
test_division (migen.test.test_divider.DivisionCase) ... ok
test_to_verilog (migen.test.test_divider.DivisionCase) ... ok
test_comparisons (migen.test.test_constant.ConstantCase) ... ok
test_to_verilog (migen.test.test_constant.ConstantCase) ... ok
test_run_sequence (migen.test.test_coding.DecCase) ... ok
test_sizes (migen.test.test_coding.DecCase) ... ok
test_to_verilog (migen.test.test_coding.DecCase) ... ok
test_run_sequence (migen.test.test_coding.EncCase) ... ok
test_sizes (migen.test.test_coding.EncCase) ... ok
test_to_verilog (migen.test.test_coding.EncCase) ... ok
test_run_sequence (migen.test.test_coding.PrioEncCase) ... ok
test_sizes (migen.test.test_coding.PrioEncCase) ... ok
test_to_verilog (migen.test.test_coding.PrioEncCase) ... ok
test_run_sequence (migen.test.test_coding.SmallPrioEncCase) ... ok
test_sizes (migen.test.test_coding.SmallPrioEncCase) ... ok
test_to_verilog (migen.test.test_coding.SmallPrioEncCase) ... ok
test_bitslip_128b (migen.test.test_bitslip.TestBitSlip) ... ok
test_bitslip_16b (migen.test.test_bitslip.TestBitSlip) ... ok
test_bitslip_32b (migen.test.test_bitslip.TestBitSlip) ... ok
test_bitslip_4b (migen.test.test_bitslip.TestBitSlip) ... ok
test_bitslip_64b (migen.test.test_bitslip.TestBitSlip) ... ok
test_bitslip_8b (migen.test.test_bitslip.TestBitSlip) ... ok

======================================================================
ERROR: test_local_cd (migen.test.test_examples.TestExamplesBasic)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/migen-9a0be7a4210ff96043412539eb5388659b81831d/migen/test/test_examples.py", line 13, in test_method
    subprocess.check_call(
    ^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib64/python3.11/subprocess.py", line 373, in check_call
    raise CalledProcessError(retcode, cmd)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
subprocess.CalledProcessError: Command '['/usr/bin/python3', '/builddir/build/BUILD/migen-9a0be7a4210ff96043412539eb5388659b81831d/examples/basic/local_cd.py']' returned non-zero exit status 1.

----------------------------------------------------------------------
Ran 52 tests in 4.270s

FAILED (errors=1, skipped=54)
Test failed: <unittest.runner.TextTestResult run=52 errors=1 failures=0>
error: Test failed: <unittest.runner.TextTestResult run=52 errors=1 failures=0>


https://docs.python.org/3.11/whatsnew/3.11.html

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.11/fedora-rawhide-x86_64/03845489-python-migen/

For all our attempts to build python-migen with Python 3.11, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.11/package/python-migen/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.11:
https://copr.fedorainfracloud.org/coprs/g/python/python3.11/

Let us know here if you have any questions.

Python 3.11 is planned to be included in Fedora 37. To make that update smoother, we're building Fedora packages with all pre-releases of Python 3.11.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Miro Hrončok 2022-06-20 10:18:34 UTC
*** Bug 2099004 has been marked as a duplicate of this bug. ***

Comment 2 Gabriel Somlo 2022-06-21 09:59:15 UTC
I opened an upstream issue a while back, forgot to link here, so here goes: https://github.com/m-labs/migen/issues/259

Comment 3 Miro Hrončok 2022-06-27 14:53:24 UTC
Hello,

This is the first reminder (step 3 from https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/#_package_removal_for_long_standing_ftbfs_and_fti_bugs).

If you know about this problem and are planning on fixing it, please acknowledge so by setting the bug status to ASSIGNED. If you don't have time to maintain this package, consider orphaning it, so maintainers of dependent packages realize the problem.

Comment 4 Gabriel Somlo 2022-06-30 20:44:10 UTC
I've submitted a fix upstream: https://github.com/m-labs/migen/pull/261
Once it gets applied, I'll rebuild the latest migen version for both F36 and rawhide.

Comment 5 Fedora Update System 2022-07-05 17:47:01 UTC
FEDORA-2022-26953aa78a has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-26953aa78a

Comment 6 Miro Hrončok 2022-07-05 22:42:50 UTC
Hello,

Please note that this comment was generated automatically. If you feel that this output has mistakes, please contact me via email (mhroncok).

All subpackages of a package against which this bug was filled are now installable or removed from Fedora 37.

Thanks for taking care of it!

Comment 7 Fedora Update System 2022-07-06 02:16:07 UTC
FEDORA-2022-26953aa78a has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2022-26953aa78a`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-26953aa78a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2022-07-14 01:45:46 UTC
FEDORA-2022-26953aa78a has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.