Hide Forgot
Spec URL: http://rpm.greysector.net/extras/ed2k_hash.spec SRPM URL: http://rpm.greysector.net/extras/ed2k_hash-0.4.0-1.src.rpm Description: A tool that outputs ed2k-links for given files.
{Not Official Reviewer} packaging looks ok. + Mockbuild is successfull for i386 FC6 + rpmlint on binary rpm is silent - dist tag is NOT present + Buildroot is correct + source URL is correct + BR is correct + License used is GPL + License file COPYING is included + desktop file is handled correctly + MD5 sum on tarball is matching upstream tarball 545d44d5e00078011f41a18e235f4af8 ed2k_hash-0.4.0.tar.gz Remove %doc from gui package as its again installing those files doc files which are laready present in ed2k_hash package. Also after installing ed2k_hash package when i tried to install ed2k_hash-gui, i got error: Failed dependencies: libfltk.so.1.1 is needed by ed2k_hash-gui-0.4.0-1.i386
my mistake forgot to check fltk-devel package. Ignore Failed dependecies error. Package is working fine. Even desktop file is installed successfully. But remove %doc files from gui package and reupload new version.
But the GUI version is independent of the CLI one. So it's perfectly possible to have only the GUI version installed. The user would be left without docs in that case.
Ok. I got that. I thought you want to create 2 packages. Anyway everything is OK now.
I will review this. Well; 1. From http://fedoraproject.org/wiki/Packaging/Guidelines : * Tags - Add %{?dist} tag. * Encoding - I recommend that the encoding of AUTHORS file is changed from ISO-8859-1 to UTF-8. * Desktop files - Well, I recommend that some icon is installed in -gui package, make desktop file have the entry of the icon name. Perhaps you may get some image file from upstream. If you do so, write it to spec file where you got the image file. If some image conversion is needed (for example, making image file smaller), you can do so and then include the image file to -gui package (then write to the spec file what you have done). 2. From http://fedoraproject.org/wiki/Packaging/ReviewGuidelines : = Nothing.
http://rpm.greysector.net/extras/ed2k_hash.spec http://rpm.greysector.net/extras/ed2k_hash-0.4.0-2.src.rpm - added dist tag - converted AUTHORS to utf8 - added an icon from ed2k-gtk-gui
Well, one thing to be fixed. All %post, %postun scriptlets should be for gui package. I want to check this package once more to check if the icon installed appear on GNOME menu.
http://rpm.greysector.net/extras/ed2k_hash.spec http://rpm.greysector.net/extras/ed2k_hash-0.4.0-3.src.rpm But of course! I don't know how I missed that.
Okay. Please go ahead. -------------------------------------------------------------- This package (ed2k_hash) is APPROVED by me.
Imported and built for devel. FC-5 branch requested.