Bug 2070578 - Review Request: python-sqladmin - SQLAdmin is a flexible Admin interface for SQLAlchemy models.
Summary: Review Request: python-sqladmin - SQLAdmin is a flexible Admin interface for ...
Keywords:
Status: ASSIGNED
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jakub Kadlčík
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-03-31 13:24 UTC by Onuralp Sezer
Modified: 2023-10-01 21:03 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:
jkadlcik: fedora-review?


Attachments (Terms of Use)

Description Onuralp Sezer 2022-03-31 13:24:50 UTC
Spec URL: https://pagure.io/python-sqladmin/raw/main/f/python-sqladmin.spec
SRPM URL: https://pagure.io/python-sqladmin/raw/main/f/	python-sqladmin-0.1.7-1.fc36.src.rpm
Description: SQLAdmin is a flexible Admin interface for SQLAlchemy models.
Fedora Account System Username: thunderbirdtr

Comment 1 Jakub Kadlčík 2022-09-17 19:39:20 UTC
Hello Onuralp,
thank you for the package.


> Version:       0.1.7

There is already a 0.5.0 version on GitHub, can you please update?


> License:       MIT

I believe this is not true (anymore?). According to the pyproject.toml
and LICENSE.md, the project is available under a BSD license.


> %{?python_enable_dependency_generator}

I think this is the default, so this line can IMHO be deleted. Per

https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#Automatically-generated-dependencies

> In an emergency, you can opt-out from running the requires generator
> by adding %{?python_disable_dependency_generator} to the package
> (usually, just before the main package’s %description). 



> %description
> %{summary}.

Heh, I like the period at the end :D

Joking aside, please let's try to avoid duplicating the Summary. Can
you please write 2-3 sentences or points about the package?

Comment 2 Package Review 2023-09-30 00:45:34 UTC
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time, but it seems
that the review is still being working out by you. If this is right, please
respond to this comment clearing the NEEDINFO flag and try to reach out the
submitter to proceed with the review.

If you're not interested in reviewing this ticket anymore, please clear the
fedora-review flag and reset the assignee, so that a new reviewer can take
this ticket.

Without any reply, this request will shortly be resetted.

Comment 3 Jakub Kadlčík 2023-10-01 21:03:00 UTC
> If you're not interested in reviewing this ticket anymore

I am interested in reviewing this ticket but there is no response from the contributor.


Note You need to log in before you can comment on or make changes to this bug.