Bug 207075 - Typo in /etc/init.d/irqbalance makes irqbalance start at every runlevel change
Summary: Typo in /etc/init.d/irqbalance makes irqbalance start at every runlevel change
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: irqbalance
Version: 5
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Neil Horman
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2006-09-19 05:51 UTC by Philippe Troin
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version: 1.2-1.26
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-09-19 12:13:00 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Philippe Troin 2006-09-19 05:51:43 UTC
irqbalance-1.12-1.25

/etc/init.d/irqbalance says:

start() {
        echo -n $"Starting $prog: "
        daemon irqbalance $ONESHOT
        RETVAL=$?
        echo
        [ $RETVAL -eq 0 -a -n "$ONESHOT" ] && touch /var/lock/subsys/irqbalance
        return $RETVAL
}

If ONESHOT is empty, -n "$ONESHOT" is false, and /var/lock/subsys/irqbalance is
never touched.

This causes irqbalance to get started every time one changes the runlevel. 
Hopefully, only one irqbalance process runs, because the pid file is checked.
Nevertheless, it's broken.

It should be:

        [ $RETVAL -eq 0 -a -z "$ONESHOT" ] && touch /var/lock/subsys/irqbalance

Phil.

Comment 1 Neil Horman 2006-09-19 12:13:00 UTC
fixed in -1.26


Note You need to log in before you can comment on or make changes to this bug.