Red Hat Bugzilla – Bug 207079
Review Request: perl-Cache - The Cache interface
Last modified: 2007-11-30 17:11:43 EST
Spec URL: http://www.environnement.ens.fr/perso/dumas/fc-srpms/perl-Cache.spec
SRPM URL: http://www.environnement.ens.fr/perso/dumas/fc-srpms/perl-Cache-2.04-1.src.rpm
The Cache modules are designed to assist a developer in persisting data
for a specified period of time. Often these modules are used in web
applications to store data locally to save repeated and redundant
expensive calls to remote machines or databases.
The Cache interface is implemented by derived classes that store cached
data in different manners (such as as files on a filesystem, or in memory).
Auto-requires misses a dep on perl(Tie::Hash) due to a use base construct, but
Tie::Hash is a core module.
There are three missing BR's, listed below. For the purposes of this review,
I'm assuming they're in there (and added them).
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ dist tag is present.
+ build root is correct.
+ license field matches the actual license.
+ license is open source-compatible. License text not included upstream
+ source files match upstream:
+ latest version is being packaged.
X BuildRequires are proper.
Date::Parse => 2.24,
Heap::Fibonacci => 0.01,
Digest::SHA1 => 2.01,
O builds in mock, with additional br's added.
+ rpmlint is silent.
O final provides and requires are sane:
perl(Cache) = 2.04
perl(Cache::Entry) = 2.04
perl(Cache::File) = 2.04
perl(Cache::File::Entry) = 2.04
perl(Cache::File::Heap) = 2.04
perl(Cache::Memory) = 2.04
perl(Cache::Memory::Entry) = 2.04
perl(Cache::Null) = 2.04
perl(Cache::Null::Entry) = 2.04
perl(Cache::RemovalStrategy) = 2.04
perl(Cache::Tester) = 2.04
perl-Cache = 2.04-1.fc5
perl >= 0:5.006
+ no shared libraries are present.
+ package is not relocatable.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ %clean is present.
+ %check is present and all tests pass:
All tests successful.
Files=11, Tests=590, 25 wallclock secs ( 2.10 cusr + 1.24 csys = 3.34 CPU)
+ no scriptlets present.
+ code, not content.
+ documentation is small, so no -docs subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.
+ no headers.
+ no pkgconfig files.
+ no libtool .la droppings.
+ not a GUI app.
+ not a web app.
APPROVED, provided the missing BR's are added.
BuildRequires added, imported, built for devel, added in owners.list.
Thanks for the review.
Any chance of a FC-5 branch? This would be quite useful on a box of mine :)
the FC-5 package is available now