Bug 2071125 - Review Request: rust-owo-colors - Zero-allocation terminal colors that'll make people go owo
Summary: Review Request: rust-owo-colors - Zero-allocation terminal colors that'll mak...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Davide Cavalca
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2070649
TreeView+ depends on / blocked
 
Reported: 2022-04-01 22:03 UTC by Michel Lind
Modified: 2022-04-13 15:49 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2022-04-05 00:17:23 UTC
Type: ---
Embargoed:
davide: fedora-review+


Attachments (Terms of Use)

Comment 1 Davide Cavalca 2022-04-01 22:07:22 UTC
Taking this review

Comment 2 Davide Cavalca 2022-04-01 22:11:04 UTC
MIT requires the license text to be present.

Comment 3 Michel Lind 2022-04-01 22:37:24 UTC
I did a PR adding the license text. Since the PR also modifies Cargo.toml, which in the crate is Cargo.toml.orig, I can't apply it directly so I'm pulling in the text I added as an additional source instead (until the PR is merged):


PR: https://github.com/jam1garner/owo-colors/pull/53
Spec URL: https://download.copr.fedorainfracloud.org/results/salimma/nu-wip/fedora-rawhide-x86_64/03938498-rust-owo-colors/rust-owo-colors.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/salimma/nu-wip/fedora-rawhide-x86_64/03938498-rust-owo-colors/rust-owo-colors-3.3.0-1.fc37.src.rpm

Comment 4 Davide Cavalca 2022-04-01 22:38:22 UTC
 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Package approved.

Comment 5 Michel Lind 2022-04-01 22:39:46 UTC
Thanks!

specs on  master [?] via 🌙 v5.4.4 took 5s
❯ fedpkg request-repo rust-owo-colors 2071125
https://pagure.io/releng/fedora-scm-requests/issue/43355

specs on  master [?] via 🌙 v5.4.4 took 4s
❯ fedpkg request-branch --repo rust-owo-colors --all-releases
https://pagure.io/releng/fedora-scm-requests/issue/43356
https://pagure.io/releng/fedora-scm-requests/issue/43357
https://pagure.io/releng/fedora-scm-requests/issue/43358

Comment 6 Gwyn Ciesla 2022-04-04 15:42:27 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-owo-colors

Comment 7 Fedora Update System 2022-04-04 18:32:53 UTC
FEDORA-2022-7ce28d8043 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-7ce28d8043

Comment 8 Fedora Update System 2022-04-04 18:33:16 UTC
FEDORA-2022-30c92bea13 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-30c92bea13

Comment 9 Fedora Update System 2022-04-04 18:33:25 UTC
FEDORA-2022-7ce28d8043 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 10 Fedora Update System 2022-04-04 18:33:47 UTC
FEDORA-2022-df79a5b433 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-df79a5b433

Comment 11 Fedora Update System 2022-04-04 18:58:04 UTC
FEDORA-2022-b80d6c33e5 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2022-b80d6c33e5

Comment 12 Fedora Update System 2022-04-05 00:17:23 UTC
FEDORA-2022-30c92bea13 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2022-04-05 12:19:10 UTC
FEDORA-2022-b80d6c33e5 has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-b80d6c33e5 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-b80d6c33e5

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2022-04-05 13:26:29 UTC
FEDORA-2022-df79a5b433 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-df79a5b433 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-df79a5b433

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 15 Fedora Update System 2022-04-13 15:42:47 UTC
FEDORA-2022-df79a5b433 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 16 Fedora Update System 2022-04-13 15:49:19 UTC
FEDORA-2022-b80d6c33e5 has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.