Description of problem: While copying the disk with "preallocated" allocation policy and incremental backup enabled, the copy gets "thin provision" allocation policy. Version-Release number of selected component (if applicable): Version 4.5.0.1-601.f26e9ea8cac5.3.el8ev vdsm-4.50.0.10-1.el8ev.x86_64 How reproducible: 100% Steps to Reproduce: 1. Create a preallocated disk with "incremental backup" enabled through the UI (Looks like it doesn't matter if it's attached to some VM or not and SD doesn't matter too). 2. Copy the disk to another domain. I did it with iscsi1 -> iscsi2, nfs1 -> nfs2 and iscsi1 -> gluster1. Actual results: The copy of the disk gets "Thin Provision" allocation policy Expected results: The copy of the disk should be preallocated. Additional info: Not a regression, reproduces on 4.4.10 as well
Relevant piece of code: https://github.com/oVirt/ovirt-engine/blob/3c09efb4e34384619492cf6ac57c3cc139e8d002/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/CreateVolumeContainerCommand.java#L83 It should instead consider the incremental backup flag, this would probably allow dropping the ActionType.ConvertDisk check as well
Not sure why I moved it to ON_QA.. the fix would be available in 4.5.1-1
Verified. Disks were copied with the same allocation policy as the source disks. Versions: engine-4.5.1.1-0.14.el8ev vdsm-4.50.1.2-1.el8ev.x86_64
This bugzilla is included in oVirt 4.5.1 release, published on June 22nd 2022. Since the problem described in this bug report should be resolved in oVirt 4.5.1 release, it has been closed with a resolution of CURRENT RELEASE. If the solution does not work for you, please open a new bug report.