Spec URL: https://download.copr.fedorainfracloud.org/results/mhayden/azure-cli/fedora-rawhide-x86_64/04086029-python-azure-data-tables/python-azure-data-tables.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/mhayden/azure-cli/fedora-rawhide-x86_64/04086029-python-azure-data-tables/python-azure-data-tables-12.2.0-1.fc37.src.rpm Description: Microsoft Azure Azure Data Tables Client Library for Python Fedora Account System Username: mhayden 🔧 This is a new azure-cli dependency that blocks the azure 2.35.0 update in BZ 2072335.
Ben -- If you have a spare moment to look this one over, it would be much appreciated. If not -- that's okay! Just let me know. 😉
I can do it! It might take me a few days to get to it.
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - Dist tag is present. (OK: rpmautospec) - The current version (2022-03-11) is 12.3.0. Is there any reason not to update? - There are a few issues with the source archive: - It’s awkward that it lacks a top-level directory. Consider using git archive --format tar.gz --prefix=azure-data-tables-$VERSION/ … - There is no LICENSE file. Happily, this is fixed in 12.3.0. - It seems like samples/ should be included as documentation. - You no longer need the “-r” option to %pyproject_buildrequires, as it is the default. (It doesn’t hurt anything to leave it, though.) ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. $ rpm -qL -p results/python3-azure-data-tables-12.2.0-1.fc37.noarch.rpm (no output) With MIT license, the license text must be included, and it is present in the upstream source repository. Updating to 12.3.0 should fix this. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License". 600 files have unknown license. Detailed output of licensecheck in /home/reviewer/2072531-python-azure-data-tables/licensecheck.txt [-]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib/python3.10/site- packages/azure(python3-azure-mgmt-redis, python3-azure-mgmt-iothub, python3-azure-mgmt-deploymentmanager, python3-azure-mgmt-kusto, python3-azure-mgmt-sql, python3-azure-synapse-artifacts, python3-azure-mgmt-managementgroups, python3-azure-multiapi-storage, python3-azure-mgmt-signalr, python3-azure-mgmt-marketplaceordering, python3-azure-mgmt-servicelinker, python3-azure-mgmt-media, python3-azure-cosmos, python3-azure-synapse-accesscontrol, python3-azure-mgmt-datamigration, python3-azure-mgmt-policyinsights, python3-azure-keyvault-secrets, python3-azure-mgmt-recoveryservices, python3-azure-mgmt-reservations, python3-azure-mgmt-search, python3-azure-mgmt-eventhub, python3-azure-mgmt-apimanagement, python3-azure-batch, python3-azure-mgmt-batch, python3-azure-mgmt- network, python3-azure-mgmt-trafficmanager, python3-azure-mgmt- recoveryservicesbackup, python3-azure-mgmt-core, azure-cli, python3-azure-mgmt-imagebuilder, python3-azure-synapse- managedprivateendpoints, python3-azure-core, python3-azure-mgmt- redhatopenshift, python3-azure-mgmt-cognitiveservices, python3-azure- mgmt-botservice, python3-azure-mgmt-resource, python3-azure-keyvault- keys, python3-azure-identity, python3-azure-mgmt-dns, python3-azure- mgmt-sqlvirtualmachine, python3-azure-mgmt-applicationinsights, python3-azure-keyvault-administration, python3-azure-appconfiguration, python3-azure-mgmt-servicefabric, python3-azure-mgmt-authorization, python3-azure-mgmt-containerservice, python3-azure-mgmt-batchai, python3-azure-mgmt-azurestackhci, python3-azure-mgmt-devtestlabs, python3-azure-mgmt-containerregistry, python3-azure-mgmt-storage, python3-azure-mgmt-cosmosdb, python3-azure-mgmt- servicefabricmanagedclusters, python3-azure-mgmt-hdinsight, python3-azure-mgmt-maps, python3-azure-mgmt-monitor, python3-azure- mgmt-security, python3-azure-mgmt-web, python3-azure-common, python3-azure-mgmt-iotcentral, python3-azure-mgmt-compute, python3-azure-mgmt-loganalytics, python3-azure-mgmt-managedservices, python3-azure-mgmt-hybridcompute, python3-azure-mgmt-netapp, python3-azure-mgmt-cdn, python3-azure-mgmt-advisor, python3-azure- mgmt-privatedns, python3-azure-mgmt-synapse, python3-azure-keyvault- certificates, python3-azure-synapse-spark, python3-azure-mgmt- databoxedge, python3-azure-mgmt-billing, python3-azure-mgmt-eventgrid, python3-azure-mgmt-rdbms, python3-azure-mgmt-containerinstance, python3-azure-mgmt-extendedlocation, python3-azure-mgmt- appconfiguration, python3-azure-datalake-store, python3-azure-mgmt- servicebus, python3-azure-mgmt-keyvault, python3-azure-storage-common, python3-azure-graphrbac) Appropriate co-ownership of Python namespace package directories. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 2 files. [x]: Package complies to the Packaging Guidelines (except as mentioned) [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. See notes in Issues. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. (based on tests passing) [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Requires -------- python3-azure-data-tables (rpmlib, GLIBC filtered): (python3.10dist(azure-core) < 2~~ with python3.10dist(azure-core) >= 1.14) python(abi) python3.10dist(msrest) Provides -------- python3-azure-data-tables: python-azure-data-tables python3-azure-data-tables python3.10-azure-data-tables python3.10dist(azure-data-tables) python3dist(azure-data-tables) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 2072531 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Python, Generic Disabled plugins: fonts, PHP, Ocaml, Java, C/C++, Haskell, SugarActivity, Perl, R Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH ============================ rpmlint session starts ============================ rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 python-azure-data-tables.spec: W: invalid-url Source0: azure-data-tables-12.2.0.tgz python3-azure-data-tables.noarch: W: files-duplicate /usr/lib/python3.10/site-packages/azure/data/tables/_generated/operations/__init__.py /usr/lib/python3.10/site-packages/azure/data/tables/_generated/aio/operations/__init__.py 2 packages and 0 specfiles checked; 0 errors, 2 warnings, 0 badness; has taken 0.6 s
(In reply to Ben Beasley from comment #3) > - The current version (2022-03-11) is 12.3.0. Is there any reason not to > update? The current released version of azure-cli has a hard requirement on 12.2.0. I usually try to work within those requirements because azure-cli's tests often fail if the requirements aren't exact. 😞 > - There are a few issues with the source archive: > > - It’s awkward that it lacks a top-level directory. Consider using > > git archive --format tar.gz --prefix=azure-data-tables-$VERSION/ … Ah, good idea. Fixed. > - There is no LICENSE file. Happily, this is fixed in 12.3.0. I'll pull in the current one from that version. > - It seems like samples/ should be included as documentation. Fixing that. > - You no longer need the “-r” option to %pyproject_buildrequires, as it is > the > default. (It doesn’t hurt anything to leave it, though.) Old habits die hard! 😉 Spec file: https://download.copr.fedorainfracloud.org/results/mhayden/azure-cli/fedora-rawhide-x86_64/04091430-python-azure-data-tables/python-azure-data-tables.spec SRPM file: https://download.copr.fedorainfracloud.org/results/mhayden/azure-cli/fedora-rawhide-x86_64/04091430-python-azure-data-tables/python-azure-data-tables-12.2.0-1.fc37.src.rpm
LGTM! Package approved. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - Dist tag is present. OK: rpmautospec ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License". 600 files have unknown license. Detailed output of licensecheck in /home/reviewer/2072531-python-azure-data-tables/2072531-python-azure- data-tables/licensecheck.txt [-]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib/python3.10/site- packages/azure(python3-azure-mgmt-iotcentral, python3-azure-keyvault- secrets, python3-azure-mgmt-extendedlocation, python3-azure-mgmt- containerservice, python3-azure-mgmt-search, python3-azure-mgmt- reservations, python3-azure-mgmt-datamigration, python3-azure-batch, python3-azure-identity, python3-azure-mgmt-policyinsights, python3-azure-mgmt-hybridcompute, python3-azure-mgmt-appconfiguration, python3-azure-storage-common, python3-azure-mgmt-devtestlabs, python3-azure-mgmt-loganalytics, python3-azure-mgmt-core, python3-azure-mgmt-iothub, python3-azure-mgmt-recoveryservices, azure- cli, python3-azure-synapse-spark, python3-azure-mgmt-managedservices, python3-azure-mgmt-cosmosdb, python3-azure-mgmt- recoveryservicesbackup, python3-azure-synapse-accesscontrol, python3-azure-mgmt-apimanagement, python3-azure-mgmt-authorization, python3-azure-mgmt-security, python3-azure-mgmt-network, python3-azure-mgmt-sql, python3-azure-synapse-artifacts, python3-azure-mgmt-kusto, python3-azure-mgmt-deploymentmanager, python3-azure-mgmt-synapse, python3-azure-mgmt-applicationinsights, python3-azure-mgmt-containerregistry, python3-azure-common, python3-azure-mgmt-databoxedge, python3-azure-mgmt-cognitiveservices, python3-azure-keyvault-keys, python3-azure-mgmt-botservice, python3-azure-synapse-managedprivateendpoints, python3-azure-mgmt- hdinsight, python3-azure-cosmos, python3-azure-mgmt-maps, python3-azure-mgmt-eventhub, python3-azure-mgmt-storage, python3-azure-core, python3-azure-mgmt-batch, python3-azure-mgmt- signalr, python3-azure-datalake-store, python3-azure-graphrbac, python3-azure-mgmt-servicelinker, python3-azure-mgmt-billing, python3-azure-mgmt-redis, python3-azure-mgmt-dns, python3-azure-mgmt- media, python3-azure-mgmt-servicefabric, python3-azure-mgmt-batchai, python3-azure-mgmt-trafficmanager, python3-azure-multiapi-storage, python3-azure-mgmt-web, python3-azure-mgmt-sqlvirtualmachine, python3-azure-mgmt-keyvault, python3-azure-mgmt-eventgrid, python3-azure-mgmt-advisor, python3-azure-mgmt-rdbms, python3-azure- mgmt-servicebus, python3-azure-mgmt-containerinstance, python3-azure- mgmt-managementgroups, python3-azure-mgmt-privatedns, python3-azure- mgmt-imagebuilder, python3-azure-mgmt-compute, python3-azure-mgmt-cdn, python3-azure-mgmt-netapp, python3-azure-mgmt-azurestackhci, python3-azure-mgmt-monitor, python3-azure-mgmt-redhatopenshift, python3-azure-mgmt-servicefabricmanagedclusters, python3-azure- keyvault-administration, python3-azure-appconfiguration, python3-azure-keyvault-certificates, python3-azure-mgmt- marketplaceordering, python3-azure-mgmt-resource) Appropriate co-ownership of Python namespace package directories. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 133120 bytes in 19 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. License file included manually from upstream; inclusion directly in the source distribution is fixed in 12.3.0. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. (tests pass) [-]: Latest version is packaged. Held back one version for azure-cli compatibility, a reasonable justification. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://raw.githubusercontent.com/Azure/azure-sdk-for-python/0b5d7ae6e9af3c45d59dacc7966949d0dd6911e3/sdk/tables/azure-data-tables/LICENSE : CHECKSUM(SHA256) this package : fd532481d828e13a0b13ccb598e02338a3617740675a862ee6bdc1541b68e93d CHECKSUM(SHA256) upstream package : fd532481d828e13a0b13ccb598e02338a3617740675a862ee6bdc1541b68e93d Requires -------- python3-azure-data-tables (rpmlib, GLIBC filtered): (python3.10dist(azure-core) < 2~~ with python3.10dist(azure-core) >= 1.14) python(abi) python3.10dist(msrest) Provides -------- python3-azure-data-tables: python-azure-data-tables python3-azure-data-tables python3.10-azure-data-tables python3.10dist(azure-data-tables) python3dist(azure-data-tables) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 2072531 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Python, Generic Disabled plugins: R, PHP, SugarActivity, Haskell, Java, fonts, Ocaml, Perl, C/C++ Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH ============================ rpmlint session starts ============================ rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 python-azure-data-tables.spec: W: invalid-url Source0: azure-data-tables-12.2.0.tgz python3-azure-data-tables.noarch: W: files-duplicate /usr/lib/python3.10/site-packages/azure/data/tables/_generated/operations/__init__.py /usr/lib/python3.10/site-packages/azure/data/tables/_generated/aio/operations/__init__.py 2 packages and 0 specfiles checked; 0 errors, 2 warnings, 0 badness; has taken 0.6 s
Thank you, Ben! You got me unblocked! 🫂
Repo requested: https://pagure.io/releng/fedora-scm-requests/issue/43551
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-azure-data-tables
FEDORA-2022-862339d824 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-862339d824
FEDORA-2022-862339d824 has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.