I'm trying to upgrade wxGTK to 3.1.6 in Rawhide, but audacity FTBFS with it (see COPR where I'm test building dependent packages: https://copr.fedorainfracloud.org/coprs/swt2c/wxGTK-3.1.6/builds/) The first issue is related to the wxLanguageInfo struct being changed in 3.1.6 to add and reorder fields: [ 52%] Building CXX object src/CMakeFiles/Audacity.dir/AudacityException.cpp.o cd /builddir/build/BUILD/audacity-minsrc-3.0.2/redhat-linux-build/src && /usr/bin/g++ -DAudacity_EXPORTS -DBUILDING_AUDACITY -DCMAKE -DHAVE_LRINT -DHAVE_LRINTF -DHAVE_MLOCK -DHAVE_SYS_SOUNDCARD_H=1 -DPA_USE_ALSA=1 -DPA_USE_JACK=1 -DPA_USE_OSS=1 -DWXINTL_NO_GETTEXT_MACRO -DWXUSINGDLL -D_FILE_OFFSET_BITS=64 -D__WXGTK__ -I/builddir/build/BUILD/audacity-minsrc-3.0.2/redhat-linux-build/src/private -I/builddir/build/BUILD/audacity-minsrc-3.0.2/include -I/builddir/build/BUILD/audacity-minsrc-3.0.2/src -I/usr/lib64/wx/include/gtk3-unicode-3.1 -I/usr/include/wx-3.1 -I/builddir/build/BUILD/audacity-minsrc-3.0.2/lib-src/lame -I/builddir/build/BUILD/audacity-minsrc-3.0.2/lib-src/portaudio-v19/include -I/builddir/build/BUILD/audacity-minsrc-3.0.2/lib-src/sqlite -I/builddir/build/BUILD/audacity-minsrc-3.0.2/lib-src/portsmf/include -I/builddir/build/BUILD/audacity-minsrc-3.0.2/lib-src/libnyquist -I/builddir/build/BUILD/audacity-minsrc-3.0.2/lib-src/portmixer/include -I/builddir/build/BUILD/audacity-minsrc-3.0.2/lib-src/libsbsms/include -isystem /usr/include/opus -isystem /usr/include/lilv-0 -isystem /usr/include/serd-0 -isystem /usr/include/sord-0 -isystem /usr/include/sratom-0 -isystem /usr/include/suil-0 -isystem /usr/include/soundtouch -isystem /usr/include/glib-2.0 -isystem /usr/lib64/glib-2.0/include -isystem /usr/include/sysprof-4 -isystem /usr/include/gtk-3.0 -isystem /usr/include/pango-1.0 -isystem /usr/include/harfbuzz -isystem /usr/include/freetype2 -isystem /usr/include/libpng16 -isystem /usr/include/libmount -isystem /usr/include/blkid -isystem /usr/include/fribidi -isystem /usr/include/libxml2 -isystem /usr/include/cairo -isystem /usr/include/pixman-1 -isystem /usr/include/gdk-pixbuf-2.0 -isystem /usr/include/gio-unix-2.0 -isystem /usr/include/cloudproviders -isystem /usr/include/atk-1.0 -isystem /usr/include/at-spi2-atk/2.0 -isystem /usr/include/dbus-1.0 -isystem /usr/lib64/dbus-1.0/include -isystem /usr/include/at-spi-2.0 -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -g -pthread -std=gnu++14 -Winvalid-pch -include /builddir/build/BUILD/audacity-minsrc-3.0.2/redhat-linux-build/src/CMakeFiles/Audacity.dir/cmake_pch.hxx -MD -MT src/CMakeFiles/Audacity.dir/AudacityException.cpp.o -MF CMakeFiles/Audacity.dir/AudacityException.cpp.o.d -o CMakeFiles/Audacity.dir/AudacityException.cpp.o -c /builddir/build/BUILD/audacity-minsrc-3.0.2/src/AudacityException.cpp /builddir/build/BUILD/audacity-minsrc-3.0.2/src/AudacityApp.cpp:937:80: error: 'wxString::wxString(int)' is private within this context 937 | { wxLANGUAGE_USER_DEFINED, wxT("eu"), WL(0, SUBLANG_DEFAULT) wxT("Basque"), wxLayout_LeftToRight }, | ^~~~~~~~~~~~~~~~~~~~ In file included from /usr/include/wx-3.1/wx/memory.h:15, from /usr/include/wx-3.1/wx/object.h:19, from /usr/include/wx-3.1/wx/wx.h:15, from /builddir/build/BUILD/audacity-minsrc-3.0.2/src/AudacityHeaders.h:32, from /builddir/build/BUILD/audacity-minsrc-3.0.2/redhat-linux-build/src/CMakeFiles/Audacity.dir/cmake_pch.hxx:5, from <command-line>: /usr/include/wx-3.1/wx/string.h:324:3: note: declared private here 324 | wxString(int); | ^~~~~~~~ That's easy enough to fix by just commenting out that line. I'm not entirely sure what that code is doing because, as best as I can tell, wxWidgets already supports the Basque language and has for some time. The second issue: In file included from /usr/include/c++/12/memory:76, from /builddir/build/BUILD/audacity-minsrc-3.0.2/src/AColor.h:17, from /builddir/build/BUILD/audacity-minsrc-3.0.2/src/AudacityHeaders.h:44, from /builddir/build/BUILD/audacity-minsrc-3.0.2/redhat-linux-build/src/CMakeFiles/Audacity.dir/cmake_pch.hxx:5, from <command-line>: /usr/include/c++/12/bits/unique_ptr.h: In instantiation of 'std::__detail::__unique_ptr_t<_Tp> std::make_unique(_Args&& ...) [with _Tp = wxBitmap; _Args = {const char* const* const&, int}; __detail::__unique_ptr_t<_Tp> = __detail::__unique_ptr_t<wxBitmap>]': /builddir/build/BUILD/audacity-minsrc-3.0.2/src/MixerBoard.cpp:1309:44: required from here /usr/include/c++/12/bits/unique_ptr.h:984:30: error: invalid conversion from 'const char* const*' to 'int' [-fpermissive] 984 | { return unique_ptr<_Tp>(new _Tp(std::forward<_Args>(__args)...)); } | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | | | const char* const* In file included from /usr/include/wx-3.1/wx/bitmap.h:310, from /usr/include/wx-3.1/wx/generic/panelg.h:14, from /usr/include/wx-3.1/wx/panel.h:69, from /usr/include/wx-3.1/wx/wx.h:40, from /builddir/build/BUILD/audacity-minsrc-3.0.2/src/AudacityHeaders.h:32: /usr/include/wx-3.1/wx/gtk/bitmap.h:69:19: note: initializing argument 1 of 'wxBitmap::wxBitmap(int, int, int)' 69 | wxBitmap( int width, int height, int depth = wxBITMAP_SCREEN_DEPTH ) | ~~~~^~~~~ This code, as best as I can tell, is trying to call a wxBitmap constructor overload with arguments (const char* const*, int), which doesn't seem to exist. No such overload exists in 3.1.5, either, so I'm confused as to how this code compiled before. In any event, help to get audacity building with wxWidgets 3.1.6 would be appreciated so I can update the package in Rawhide.
Thanks for noticing these. I have created two patches (and sent them upstream in https://github.com/audacity/audacity/pull/2776). I will update the spec this weekend, but right now I am hitting a really odd bug with LTO that makes compiling Audacity for me basically impossible (https://bugzilla.redhat.com/show_bug.cgi?id=2073222).
FEDORA-2022-857f49ff15 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-857f49ff15
I have gone ahead and pushed the patches to both rawhide and F36, and kicked off a build on each branch (since I also updated the Audacity version at the same time). The builds have completed and updates have been made for them. @swt I just noticed you didn't have commit access to the dist-git repo for audacity, so I have added you to it, and you now should be able to push the rebuild commits yourself. Let me know if there are any other issues in the upgrade.
FEDORA-2022-857f49ff15 has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2022-857f49ff15` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-857f49ff15 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
(In reply to Ian McInerney from comment #3) > I have gone ahead and pushed the patches to both rawhide and F36, and kicked > off a build on each branch (since I also updated the Audacity version at the > same time). The builds have completed and updates have been made for them. > > @swt I just noticed you didn't have commit access to the dist-git repo for > audacity, so I have added you to it, and you now should be able to push the > rebuild commits yourself. Let me know if there are any other issues in the > upgrade. Thanks Ian for fixing these issues and adding me to dist-git!
FEDORA-2022-857f49ff15 has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report.