Spec URL: https://download.copr.fedorainfracloud.org/results/voegelas/fedora/fedora-rawhide-x86_64/06130318-perl-IP-Geolocation-MMDB/perl-IP-Geolocation-MMDB.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/voegelas/fedora/fedora-rawhide-x86_64/06130318-perl-IP-Geolocation-MMDB/perl-IP-Geolocation-MMDB-1.010-1.fc39.src.rpm Description: A Perl module that reads MaxMind DB files and maps IP addresses to location information such as country and city names Fedora Account System Username: voegelas perl-Alien-libmaxminddb and this module are my first packages. I am the upstream author of both modules. I am looking for a sponsor. IP::Geolocation::MMDB is an alternative to the deprecated Perl module MaxMind::DB::Reader.
Sorry, I forgot about this review.
@andreas Hi Andreas, could we update to last version of module from CPAN? I was looking at https://bugzilla.redhat.com/show_bug.cgi?id=2072968 and the issues in this are similar. 1) License 2) MODULE_COMPAT
Hello Michal, thanks a lot for the review. I've removed the MODULE_COMPAT requirement. I had already updated the version and the license in Copr. Today's build with review output in the "fedora-review" subfolder is here: https://download.copr.fedorainfracloud.org/results/voegelas/fedora/fedora-rawhide-x86_64/05934643-perl-IP-Geolocation-MMDB/ Kind regards, Andreas Spec URL: https://download.copr.fedorainfracloud.org/results/voegelas/fedora/fedora-rawhide-x86_64/05934643-perl-IP-Geolocation-MMDB/perl-IP-Geolocation-MMDB.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/voegelas/fedora/fedora-rawhide-x86_64/05934643-perl-IP-Geolocation-MMDB/perl-IP-Geolocation-MMDB-1.010-1.fc39.src.rpm Description: A Perl module that reads MaxMind DB files and maps IP addresses to location information such as country and city names Fedora Account System Username: voegelas
Hi Andreas, There is one missing thing with not explicitly named files in spec file. Need to name files in %{perl_vendorlib}/ and %{_mandir}/man3/ See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists
Hello Michael, I've updated the spec file. The build is https://copr.fedorainfracloud.org/coprs/voegelas/fedora/build/6130318/. I've also updated perl-Alien-libmaxminddb accordingly. Spec URL: https://download.copr.fedorainfracloud.org/results/voegelas/fedora/fedora-rawhide-x86_64/06130318-perl-IP-Geolocation-MMDB/perl-IP-Geolocation-MMDB.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/voegelas/fedora/fedora-rawhide-x86_64/06130318-perl-IP-Geolocation-MMDB/perl-IP-Geolocation-MMDB-1.010-1.fc39.src.rpm
Source file is ok Summary is ok License is ok Description is ok URL and Source are ok All tests passed BuildRequires are ok $ rpm -qp --requires perl-IP-Geolocation-MMDB-1.010-1.fc39.x86_64.rpm | sort | uniq -c | grep -v rpmlib 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.4)(64bit) 1 libc.so.6()(64bit) 1 libmaxminddb.so.0()(64bit) 1 libperl.so.5.36()(64bit) 1 perl(IP::Geolocation::MMDB::Metadata) 1 perl-libs 1 perl(Math::BigInt) >= 1.999806 1 perl(:MODULE_COMPAT_5.36.1) 1 perl(utf8) 1 perl(:VERSION) >= 5.16.0 1 perl(warnings) 1 perl(XSLoader) 1 rtld(GNU_HASH) Binary requires are Ok. $ rpm -qp --provides perl-IP-Geolocation-MMDB-1.010-1.fc39.x86_64.rpm | sort | uniq -c 1 perl(IP::Geolocation::MMDB::Metadata) = 1.010 1 perl-IP-Geolocation-MMDB(x86-64) = 1.010-1.fc39 1 perl(IP::Geolocation::MMDB) = 1.010 1 perl-IP-Geolocation-MMDB = 1.010-1.fc39 Binary provides are Ok. $ rpmlint perl-IP-Geolocation-MMDB-* 4 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.3 s Rpmlint is ok The package is in line with Fedora and Perl packaging guide lines. Resolution: approved
The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-IP-Geolocation-MMDB