Bug 2073153 - IPs with leading zeros should still be valid in the apiserver
Summary: IPs with leading zeros should still be valid in the apiserver
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: kube-apiserver
Version: 4.9
Hardware: Unspecified
OS: Unspecified
Target Milestone: ---
: 4.9.z
Assignee: Antonio Ojea
QA Contact: Ke Wang
Depends On: 2042493
Blocks: 2069310 2075043
TreeView+ depends on / blocked
Reported: 2022-04-07 18:51 UTC by Abu Kashem
Modified: 2022-05-03 07:35 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed: 2022-05-03 07:35:34 UTC
Target Upstream Version:

Attachments (Terms of Use)

System ID Private Priority Status Summary Last Updated
Github openshift kubernetes pull 1239 0 None open Bug 2073153: golang toolchain unsupported parsers tag 2022-04-12 16:33:08 UTC
Red Hat Product Errata RHBA-2022:1605 0 None None None 2022-05-03 07:35:52 UTC

Description Abu Kashem 2022-04-07 18:51:01 UTC
https://bugzilla.redhat.com/show_bug.cgi?id=2043807 is in ERRATA, but we still see the unit test fail.

: Run test unit - container test expand_more	13m49s
k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/util/validation: TestIsValidIP expand_less	0s
{Failed  === RUN   TestIsValidIP
    validation_test.go:340: expected true for "": [must be a valid IP address, (e.g. or 2001:db8::ffff)]
--- FAIL: TestIsValidIP (0.00s)

It's blocking https://github.com/openshift/kubernetes/pull/1233. 

I do see the proper GOFLAGS in 4.9, and yet the unit test fails.

> RUN make GOFLAGS='-mod=vendor -p=4 -tags=unsupportedGolang116OnlyUseDeprecatedParseIPv4' \
>         WHAT='cmd/kube-apiserver cmd/kube-controller-manager cmd/kube-scheduler cmd/kubelet cmd/watch-termination' && \

Comment 8 Ke Wang 2022-04-15 02:33:21 UTC
Based on Comment 5 and PR change, this is for test fix. Checked the latest unit test results: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_kubernetes/1223/pull-ci-openshift-kubernetes-release-4.9-unit/1514325256490192896, the related test TestIsValidIP passed, so move the bug VERIFIED.

Comment 13 errata-xmlrpc 2022-05-03 07:35:34 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.9.31 bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.