Bug 2074486

Sounds like wipefs is able to open the device for write and the write() call is successful. 

Can you confirm this? For example by "strace -o log wipefs -a /dev/sr1".

If yes, then wipefs has no way how to report the issue.

Hi Karel,
  It's introduced by this patch https://github.com/util-linux/util-linux/commit/39f5af25982d8b0244000e92a9d0e0e6557d0e17
  and the return value of the cmd is 0, but the data is not changed actually if we check with "wipefs -J /dev/sr1" before and after we run "wipefs -a /dev/sr1"

(In reply to Karel Zak from comment #1)
> Sounds like wipefs is able to open the device for write and the write() call
> is successful. 
> 
> Can you confirm this? For example by "strace -o log wipefs -a /dev/sr1".
> 
> If yes, then wipefs has no way how to report the issue.

Hi Karel:

I saw an "(Input/output error)" in following section in strace log and the whole log was attached:

lseek(3, 32769, SEEK_SET)               = 32769
write(3, "\0\0\0\0\0", 5)               = 5
fsync(3)                                = -1 EIO (Input/output error)
newfstatat(1, "", {st_mode=S_IFCHR|0620, st_rdev=makedev(0x88, 0), ...}, AT_EMPTY_PATH) = 0
write(1, "/dev/sr1: 5 bytes were erased at"..., 77) = 77
lseek(3, 32768, SEEK_SET)               = 32768

Thanks for debugging. You're right, libblkid as well as wipefs do not check fsync() and close() return value. That's a mistake for O_NONBLOCK.

Minl and Wei Shi, can you guys try the latest upstream in your environment? (git clone https://github.com/util-linux/util-linux)

I have improved the code to check fsync() and close() return code:
https://github.com/util-linux/util-linux/commit/133a0d70f637b4f4e4337811e452153b04f2bdcf

but I'm not able to reproduce your issue on my workstation, so it would be nice to have confirmation from you ;-) Thanks!

Karel,
  My test result is PASS, btw I modified the patch a little bit in order to backport to v2.37.4
  http://pastebin.test.redhat.com/1045610

====== original util-linux-2.37.4-3.el9.x86_64 ======
# wipefs -J /dev/sr1 
{
   "signatures": [
      {
         "device": "sr1",
         "offset": "0x8001",
         "type": "iso9660",
         "uuid": "2022-04-19-16-07-37-00",
         "label": "config-2"
      }
   ]
}
# wipefs -a /dev/sr1 
/dev/sr1: 5 bytes were erased at offset 0x00008001 (iso9660): 43 44 30 30 31
# echo $?
0
# wipefs -J /dev/sr1 
{
   "signatures": [
      {
         "device": "sr1",
         "offset": "0x8001",
         "type": "iso9660",
         "uuid": "2022-04-19-16-07-37-00",
         "label": "config-2"
      }
   ]
}

====== After patched ======
# wipefs -J /dev/sr1 
{
   "signatures": [
      {
         "device": "sr1",
         "offset": "0x8001",
         "type": "iso9660",
         "uuid": "2022-04-19-16-07-37-00",
         "label": "config-2"
      }
   ]
}
# wipefs -a /dev/sr1 
wipefs: /dev/sr1: failed to erase iso9660 magic string at offset 0x00008001: Input/output error
# echo $?
1
# wipefs -J /dev/sr1 
{
   "signatures": [
      {
         "device": "sr1",
         "offset": "0x8001",
         "type": "iso9660",
         "uuid": "2022-04-19-16-07-37-00",
         "label": "config-2"
      }
   ]
}

(In reply to Wei Shi from comment #7)
>   My test result is PASS, btw I modified the patch a little bit in order to
> backport to v2.37.4  http://pastebin.test.redhat.com/1045610

Thanks for your feedback!

[root@minl-9 ~]# rpm -qf /usr/sbin/wipefs 
util-linux-2.37.4-8.el9.x86_64
[root@minl-9 ~]# 
[root@minl-9 ~]# wipefs -J /dev/sr1
{
   "signatures": [
      {
         "device": "sr1",
         "offset": "0x8001",
         "type": "iso9660",
         "uuid": "2022-08-18-17-58-53-00",
         "label": "config-2"
      }
   ]
}
[root@minl-9 ~]# 
[root@minl-9 ~]# wipefs -a /dev/sr1
wipefs: /dev/sr1: failed to erase iso9660 magic string at offset 0x00008001: Input/output error
[root@minl-9 ~]# 
[root@minl-9 ~]# echo $?
1
[root@minl-9 ~]# 
[root@minl-9 ~]# wipefs -J /dev/sr1
{
   "signatures": [
      {
         "device": "sr1",
         "offset": "0x8001",
         "type": "iso9660",
         "uuid": "2022-08-18-17-58-53-00",
         "label": "config-2"
      }
   ]
}

# cat /etc/redhat-release 
Red Hat Enterprise Linux release 9.1 Beta (Plow)
# rpm -qf /usr/sbin/wipefs 
util-linux-2.37.4-8.el9.x86_64
# wipefs -a /dev/sr1
wipefs: /dev/sr1: failed to erase iso9660 magic string at offset 0x00008001: Input/output error
# echo $?
1

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (util-linux bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:8404