Bug 2074582
| Summary: | VDSM expects from engine to translate resize_and_pin_numa policy to resize_and_pin | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [oVirt] ovirt-engine | Reporter: | Polina <pagranat> | ||||
| Component: | BLL.Virt | Assignee: | Liran Rotenberg <lrotenbe> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Polina <pagranat> | ||||
| Severity: | high | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 4.5.0 | CC: | ahadas, bugs, lrotenbe, tgolembi | ||||
| Target Milestone: | ovirt-4.5.0 | Keywords: | Regression | ||||
| Target Release: | 4.5.0.4 | Flags: | pm-rhel:
ovirt-4.5?
ahadas: blocker- ahadas: exception+ |
||||
| Hardware: | x86_64 | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | ovirt-engine-4.5.0.4 | Doc Type: | If docs needed, set a value | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2022-04-28 09:26:34 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | Virt | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
This is not accurate. The policy should be "manual".
The list of policies VDSM understands and that is here:
https://github.com/oVirt/vdsm/blob/68ec445938a144bf72952297def58c030a8b7c41/lib/vdsm/virt/cpumanagement.py#L25
These are the only policies that Engine should send in metadata.
Actually, VDSM doesn't know about 'resize_and_pin' or 'resize_and_pin_numa'. We can either add it to VDSM, or, more likely to set it as 'manual' when we have 'resize_and_pin_numa'. ...and this is a regression. This bug report has Keywords: Regression or TestBlocker. Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP. Verified on ovirt-engine-4.5.0.4-0.1.el8ev.noarch. The virsh dumpxml contains now <ovirt-vm:cpuPolicy>manual</ovirt-vm:cpuPolicy> . As the result, the cleared cpu_pinning described in https://bugzilla.redhat.com/show_bug.cgi?id=2074582#c0 is solved as well. This bugzilla is included in oVirt 4.5.0 release, published on April 20th 2022. Since the problem described in this bug report should be resolved in oVirt 4.5.0 release, it has been closed with a resolution of CURRENT RELEASE. If the solution does not work for you, please open a new bug report. |
Created attachment 1871985 [details] engine log dump xmls Description of problem: engine needs to convert resize_and_pin_numa to policy that VDSM understands Version-Release number of selected component (if applicable): vdsm-4.50.0.11-1.el8ev.x86_64 ovirt-engine-4.5.0.2-0.7.el8ev.noarch How reproducible: 100% Steps to Reproduce: 1. Configure VM with resize policy . Run and Migrate. Actual results: in virsh dumpxml we have 'resize_and_pin_numa' instead of 'resize_and_pin' Now as result of passing arbitrary strings instead of expected policy name we have incorrect behavior , like for example while migration of VM with resize policy the cpu_pinning is cleared in virsh dump xml Expected results: in virsh dump the policy name 'resize_and_pin' The it must fix the cleared cpu_pinning after migration Additional info: