Spec URL: https://pagure.io/python-qt6/raw/main/f/python-qt6.spec SRPM URL: https://pagure.io/python-qt6/raw/main/f/python-qt6-6.2.3-1.fc36.src.rpm Description: PyQt6 is Python bindings for Qt6 Fedora Account System Username: thunderbirdtr
This package require python-pyqt6-sip for installation and Review Link: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2074732
Despite the unusual python-qt5 name, this package should be named python-pyqt6 / python3-pyqt6.
%python_provide macro is deprecated and should not be used, see https://docs.fedoraproject.org/en-US/packaging-guidelines/Python_201x/#_the_py_provides_macro
%python_provide removed. BuildRequires: cmake(Qt6RemoteObjects) added Extra files added. %{python3_sitearch}/PyQt6/QtQuick3D.* %{python3_sitearch}/PyQt6/QtRemoteObjects.* New file names Spec URL: https://pagure.io/python-qt6/raw/main/f/python-pyqt6.spec SRPM URL: https://pagure.io/python-qt6/raw/main/f/python-pyqt6-6.2.3-1.fc36.src.rpm
Taking this review.
Spec review: > %global rpm_macros_dir %(d=%{_rpmconfigdir}/macros.d; [ -d $d ] || d=%{_sysconfdir}/rpm; echo $d) Just get rid of all this and use %{_rpmmacrodir} wherever %{rpm_macros_dir} was used. > #patch0 -p1 Drop this, it's unused. > --qmake-setting 'QMAKE_CFLAGS_RELEASE="%{optflags}"' \ > --qmake-setting 'QMAKE_CXXFLAGS_RELEASE="%{optflags} `pkg-config --cflags dbus-python`"' \ > --qmake-setting 'QMAKE_LFLAGS_RELEASE="%{?__global_ldflags}"' Use %{build_cflags}, %{build_cxxflags}, and %{build_ldflags} accordingly.
FWIW: I'm looking into upgrading tortoisehg to use qt6. It seems like I need this package and am blocked. (Note: this is also tracked on https://pagure.io/fedora-kde/SIG/issue/127 )
(In reply to Mads Kiilerich from comment #7) > FWIW: I'm looking into upgrading tortoisehg to use qt6. It seems like I need > this package and am blocked. > > (Note: this is also tracked on https://pagure.io/fedora-kde/SIG/issue/127 ) Sorry for bit delay I am gonna taking care of it.
*** Bug 2124098 has been marked as a duplicate of this bug. ***
Scratch build results F38 and F37 builds fine https://koji.fedoraproject.org/koji/taskinfo?taskID=91655388 https://koji.fedoraproject.org/koji/taskinfo?taskID=91655383 I did all the changes Neal asked as well. Spec URL: https://pagure.io/python-qt6/raw/main/f/python-pyqt6.spec SRPM URL: https://pagure.io/python-qt6/raw/main/f/python-pyqt6-6.3.1-1.fc38.src.rpm
Looks good to me. Package review notes: * Builds and installs * Package licensing is correct and license files are correctly installed * Package naming follows packaging policy
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-pyqt6
@thunderbirdtr Could you import the package? Or feel free to add me to the package and I'm happy to help.
PyQt6 is already in F36-37-38 and sure I can add you as well.
My bad, I was looking for python-qt6... Thanks!
No problem, you're welcome :)
This mat not be the place but pyqtwebengine-5.15.4-4.fc37 also needs to be updated for QT6 as it provides PyQY6 QTWebEngineWidgets.
Package is now in repositories, closing review.