Spec URL: https://decathorpe.fedorapeople.org/rust-wasmtime-jit-debug.spec SRPM URL: https://decathorpe.fedorapeople.org/rust-wasmtime-jit-debug-0.35.3-1.fc36.src.rpm Description: JIT debug interfaces support for Wasmtime. Fedora Account System Username: decathorpe koji scratch build for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=85629809
Taking this review
Note: depends on the rustix update, which depends on linux-raw-sys and io-lifetimes, make sure to push them together once they are ready Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (MIT) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. one question - rust2rpm does automatically generate the comment that this is ASL with LLVM exception, but... is there a better thing we can put in the license field?
Thanks for the review! Yeah, I'm building all these packages in side tags right now, they will be submitted together. > rust2rpm does automatically generate the comment that this is ASL with LLVM exception This is a known problem ... Fedora Legal determined that "Apache-2.0 WITH LLVM-Exception" is functionally equivalent to "Apache-2.0" for our purposes. rust2rpm however can't easily map this to just "ASL 2.0" because the SPDX parser apparently doesn't support doing that. Reported as an issue to rust2rpm here: https://pagure.io/fedora-rust/rust2rpm/issue/163 https://pagure.io/releng/fedora-scm-requests/issue/43720 https://pagure.io/releng/fedora-scm-requests/issue/43721 https://pagure.io/releng/fedora-scm-requests/issue/43722 https://pagure.io/releng/fedora-scm-requests/issue/43723
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-wasmtime-jit-debug
Built and submitted for rawhide: https://bodhi.fedoraproject.org/updates/FEDORA-2022-31e5d41c38