Bug 2076023 - Review Request: rust-cargo-manifest - Helper crate to parse and manipulate manifests
Summary: Review Request: rust-cargo-manifest - Helper crate to parse and manipulate ma...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-04-17 06:37 UTC by Carmelo Sarta
Modified: 2022-05-05 13:51 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2022-05-05 13:51:48 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Carmelo Sarta 2022-04-17 06:37:41 UTC
Spec URL: https://raw.githubusercontent.com/Laiot/rust-cargo-manifest-rpm/master/rust-cargo-manifest.spec
SRPM URL: https://github.com/Laiot/rust-cargo-manifest-rpm/raw/master/rust-cargo-manifest-0.2.6-1.fc36.src.rpm
Description: Helper crate to parse and manipulate manifests 
Fedora Account System Username: laiot

Comment 1 Fabio Valentini 2022-05-01 14:30:03 UTC
Please modify the Summary in the spec file.
Markdown markup is useless in there, it is only ever rendered as plain text.
For example:

Summary:        Helper crate to parse and manipulate Cargo.toml files

Other than that:

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (Apache-2.0 OR MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

===

I'm curious what you need this crate for?

Comment 2 Carmelo Sarta 2022-05-01 15:14:55 UTC
Hi Fabio, thank you for all your reviews!
I needed this package for a sub-package of Bevy called bevy-macro-utils ( https://crates.io/crates/bevy_macro_utils )

Comment 3 Gwyn Ciesla 2022-05-02 15:20:40 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-cargo-manifest

Comment 4 Fabio Valentini 2022-05-02 20:31:31 UTC
Oh, so you're packaging Bevy? What for? :)


Note You need to log in before you can comment on or make changes to this bug.