Spec URL: https://rathann.fedorapeople.org/review/normalize/normalize.spec SRPM URL: https://rathann.fedorapeople.org/review/normalize/normalize-0.7.7-25.fc37.src.rpm Description: normalize is a tool for adjusting the volume of audio files to a standard level. This is useful for things like creating mixed CDs and mp3 collections, where different recording levels on different albums can cause the volume to vary greatly from song to song. Fedora Account System Username: rathann Additional info: This package was retired from RPM Fusion due to FTBFS, but is eligible for Fedora since mp3 was approved. Original bug: https://bugzilla.rpmfusion.org/show_bug.cgi?id=4986 .
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License, Version 2", "GNU General Public License v2.0 or later", "FSF Unlimited License (with License Retention)", "FSF Unlimited License [generated file]", "GNU General Public License v2.0 or later [generated file]", "X11 License [generated file]", "*No copyright* [generated file]", "FSF Unlimited License (with License Retention) GNU Lesser General Public License GNU General Public License", "GNU General Public License", "GNU Library General Public License v2 or later". 50 files have unknown license. Detailed output of licensecheck in /home/sage/2076111-normalize/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: The spec file handles locales properly. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 30720 bytes in 4 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Sources can be downloaded from URI in Source: tag Note: Could not download Source0: http://savannah.nongnu.org/download/normalize/normalize-0.7.7.tar.bz2 See: https://docs.fedoraproject.org/en-US/packaging- guidelines/SourceURL/ [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [ ]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define plugindir %(xmms-config --effect-plugin-dir 2>/dev/null) [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [!]: Package should not use obsolete m4 macros Note: Some obsoleted macros found, see the attachment. See: https://fedorahosted.org/FedoraReview/wiki/AutoTools [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.
Thanks for the review! Spec URL: https://rathann.fedorapeople.org/review/normalize/normalize.spec SRPM URL: https://rathann.fedorapeople.org/review/normalize/normalize-0.7.7-26.fc37.src.rpm * Wed May 04 2022 Dominik Mierzejewski <dominik> - 0.7.7-26 - use a working Source URL - verify source signature
There seems to be errors on autoreconf. Can you fix those? Have you tried fedpkg mockbuild on your package? ... + /usr/lib/rpm/redhat/gpgverify --keyring=/builddir/build/SOURCES/0xAFC8519A83FE7486.gpg --signature=/builddir/build/SOURCES/normalize-0.7.7.tar.gz.sig --data=/builddir/build/SOURCES/normalize-0.7.7.tar.gz gpgv: Signature made Wed Sep 14 20:42:44 2005 CEST gpgv: using DSA key AFC8519A83FE7486 gpgv: Good signature from "Chris Vaill <chrisvaill>" + cd /builddir/build/BUILD + rm -rf normalize-0.7.7 + /usr/lib/rpm/rpmuncompress -x /builddir/build/SOURCES/normalize-0.7.7.tar.gz + STATUS=0 + '[' 0 -ne 0 ']' + cd normalize-0.7.7 + /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w . + /usr/lib/rpm/rpmuncompress /builddir/build/SOURCES/normalize-0.7.7-audiofile.patch + /usr/bin/patch -p1 -s --fuzz=0 --no-backup-if-mismatch -f + /usr/lib/rpm/rpmuncompress /builddir/build/SOURCES/normalize-0.7.7-autoreconf.patch + /usr/bin/patch -p1 -s --fuzz=0 --no-backup-if-mismatch -f + touch AUTHORS ChangeLog + autoreconf -fi configure.ac:224: warning: macro 'AM_PATH_GLIB' not found in library configure.ac:225: warning: macro 'AM_PATH_GTK' not found in library configure.ac:226: warning: macro 'AM_PATH_XMMS' not found in library m4/gettext.m4:442: warning: macro 'AM_LANGINFO_CODESET' not found in library configure.ac: warning: AM_GNU_GETTEXT is used, but not AM_GNU_GETTEXT_VERSION or AM_GNU_GETTEXT_REQUIRE_VERSION libtoolize: putting auxiliary files in AC_CONFIG_AUX_DIR, 'config'. libtoolize: copying file 'config/ltmain.sh' libtoolize: putting macros in 'm4'. libtoolize: copying file 'm4/libtool.m4' libtoolize: copying file 'm4/ltoptions.m4' libtoolize: copying file 'm4/ltsugar.m4' libtoolize: copying file 'm4/ltversion.m4' libtoolize: copying file 'm4/lt~obsolete.m4' libtoolize: Consider adding 'AC_CONFIG_MACRO_DIRS([m4])' to configure.ac, libtoolize: and rerunning libtoolize and aclocal. configure.ac:224: warning: macro 'AM_PATH_GLIB' not found in library configure.ac:225: warning: macro 'AM_PATH_GTK' not found in library configure.ac:226: warning: macro 'AM_PATH_XMMS' not found in library m4/gettext.m4:442: warning: macro 'AM_LANGINFO_CODESET' not found in library configure.ac:11: warning: 'AM_CONFIG_HEADER': this macro is obsolete. configure.ac:11: You should use the 'AC_CONFIG_HEADERS' macro instead. ./lib/autoconf/general.m4:2434: AC_DIAGNOSE is expanded from... aclocal.m4:745: AM_CONFIG_HEADER is expanded from... configure.ac:11: the top level configure.ac:15: warning: The macro `AC_ISC_POSIX' is obsolete. configure.ac:15: You should run autoupdate. ./lib/autoconf/specific.m4:550: AC_ISC_POSIX is expanded from... configure.ac:15: the top level configure.ac:22: warning: The macro `AC_HEADER_STDC' is obsolete. configure.ac:22: You should run autoupdate. ./lib/autoconf/headers.m4:704: AC_HEADER_STDC is expanded from... configure.ac:22: the top level configure.ac:162: warning: The macro `AC_HELP_STRING' is obsolete. configure.ac:162: You should run autoupdate. ./lib/autoconf/general.m4:204: AC_HELP_STRING is expanded from... configure.ac:162: the top level configure.ac:213: warning: The macro `AC_HELP_STRING' is obsolete. configure.ac:213: You should run autoupdate. ./lib/autoconf/general.m4:204: AC_HELP_STRING is expanded from... configure.ac:213: the top level configure.ac:227: warning: The macro `AM_DISABLE_STATIC' is obsolete. configure.ac:227: You should run autoupdate. m4/ltoptions.m4:260: AM_DISABLE_STATIC is expanded from... configure.ac:227: the top level configure.ac:228: warning: The macro `AM_PROG_LIBTOOL' is obsolete. configure.ac:228: You should run autoupdate. m4/libtool.m4:101: AM_PROG_LIBTOOL is expanded from... configure.ac:228: the top level configure.ac:230: warning: The macro `AC_HELP_STRING' is obsolete. configure.ac:230: You should run autoupdate. ./lib/autoconf/general.m4:204: AC_HELP_STRING is expanded from... configure.ac:230: the top level configure.ac:257: warning: The macro `AC_HELP_STRING' is obsolete. configure.ac:257: You should run autoupdate. ./lib/autoconf/general.m4:204: AC_HELP_STRING is expanded from... configure.ac:257: the top level configure.ac:286: warning: The macro `AC_HELP_STRING' is obsolete. configure.ac:286: You should run autoupdate. ./lib/autoconf/general.m4:204: AC_HELP_STRING is expanded from... configure.ac:286: the top level configure.ac:292: warning: The macro `AC_HELP_STRING' is obsolete. configure.ac:292: You should run autoupdate. ./lib/autoconf/general.m4:204: AC_HELP_STRING is expanded from... configure.ac:292: the top level configure.ac:315: warning: The macro `AC_HELP_STRING' is obsolete. configure.ac:315: You should run autoupdate. ./lib/autoconf/general.m4:204: AC_HELP_STRING is expanded from... configure.ac:315: the top level configure.ac:325: warning: The macro `AC_OUTPUT_COMMANDS' is obsolete. configure.ac:325: You should run autoupdate. ./lib/autoconf/status.m4:1025: AC_OUTPUT_COMMANDS is expanded from... m4/po.m4:23: AM_PO_SUBDIRS is expanded from... m4/gettext.m4:57: AM_GNU_GETTEXT is expanded from... configure.ac:325: the top level configure.ac:325: warning: The macro `AC_TRY_LINK' is obsolete. configure.ac:325: You should run autoupdate. ./lib/autoconf/general.m4:2920: AC_TRY_LINK is expanded from... lib/m4sugar/m4sh.m4:692: _AS_IF_ELSE is expanded from... lib/m4sugar/m4sh.m4:699: AS_IF is expanded from... ./lib/autoconf/general.m4:2249: AC_CACHE_VAL is expanded from... ./lib/autoconf/general.m4:2270: AC_CACHE_CHECK is expanded from... m4/gettext.m4:486: gt_INTL_MACOSX is expanded from... m4/gettext.m4:57: AM_GNU_GETTEXT is expanded from... configure.ac:325: the top level configure.ac:325: warning: The macro `AC_TRY_LINK' is obsolete. configure.ac:325: You should run autoupdate. ./lib/autoconf/general.m4:2920: AC_TRY_LINK is expanded from... lib/m4sugar/m4sh.m4:692: _AS_IF_ELSE is expanded from... lib/m4sugar/m4sh.m4:699: AS_IF is expanded from... ./lib/autoconf/general.m4:2249: AC_CACHE_VAL is expanded from... ./lib/autoconf/general.m4:2270: AC_CACHE_CHECK is expanded from... m4/gettext.m4:57: AM_GNU_GETTEXT is expanded from... configure.ac:325: the top level configure.ac:325: warning: The macro `AC_TRY_LINK' is obsolete. configure.ac:325: You should run autoupdate. ./lib/autoconf/general.m4:2920: AC_TRY_LINK is expanded from... lib/m4sugar/m4sh.m4:692: _AS_IF_ELSE is expanded from... lib/m4sugar/m4sh.m4:699: AS_IF is expanded from... ./lib/autoconf/general.m4:2249: AC_CACHE_VAL is expanded from... ./lib/autoconf/general.m4:2270: AC_CACHE_CHECK is expanded from... m4/iconv.m4:20: AM_ICONV_LINK is expanded from... m4/gettext.m4:57: AM_GNU_GETTEXT is expanded from... configure.ac:325: the top level configure.ac:224: error: possibly undefined macro: AM_PATH_GLIB If this token and others are legitimate, please use m4_pattern_allow. See the Autoconf documentation. configure.ac:225: error: possibly undefined macro: AM_PATH_GTK configure.ac:226: error: possibly undefined macro: AM_PATH_XMMS RPM build errors: autoreconf: error: /usr/bin/autoconf failed with exit status: 1 error: Bad exit status from /var/tmp/rpm-tmp.tBQgrr (%prep) Bad exit status from /var/tmp/rpm-tmp.tBQgrr (%prep) Child return code was: 1 EXCEPTION: [Error()] Traceback (most recent call last): File "/usr/lib/python3.10/site-packages/mockbuild/trace_decorator.py", line 93, in trace result = func(*args, **kw) File "/usr/lib/python3.10/site-packages/mockbuild/util.py", line 598, in do_with_status raise exception.Error("Command failed: \n # %s\n%s" % (command, output), child.returncode) mockbuild.exception.Error: Command failed:
Fixed. Spec URL: https://rathann.fedorapeople.org/review/normalize/normalize.spec SRPM URL: https://rathann.fedorapeople.org/review/normalize/normalize-0.7.7-27.fc37.src.rpm * Thu Jul 21 2022 Dominik Mierzejewski <dominik> - 0.7.7-27 - fix build without xmms/gtk+/glib
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License, Version 2", "GNU General Public License v2.0 or later", "FSF Unlimited License (with License Retention)", "FSF Unlimited License [generated file]", "GNU General Public License v2.0 or later [generated file]", "X11 License [generated file]", "*No copyright* [generated file]", "FSF Unlimited License (with License Retention) GNU Lesser General Public License GNU General Public License", "GNU General Public License", "GNU Library General Public License v2 or later". 50 files have unknown license. Detailed output of licensecheck in /home/FedoraPackaging/reviews/normalize/2076111-normalize/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [?]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 30720 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: Sources 0, 1 and 2 are not passed to gpgverify. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Package should not use obsolete m4 macros Note: Some obsoleted macros found, see the attachment. See: https://fedorahosted.org/FedoraReview/wiki/AutoTools [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Cannot parse rpmlint output: Rpmlint (debuginfo) ------------------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 3 normalize.x86_64: W: no-manual-page-for-binary normalize-ogg 3 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 2.5 s Source checksums ---------------- http://download.savannah.gnu.org/releases/normalize/normalize-0.7.7.tar.gz.sig : CHECKSUM(SHA256) this package : 7f894cf15dc2e18d28f8c72dbd0024107cecdee961db47c38071c6266bbd8b37 CHECKSUM(SHA256) upstream package : 7f894cf15dc2e18d28f8c72dbd0024107cecdee961db47c38071c6266bbd8b37 http://download.savannah.gnu.org/releases/normalize/normalize-0.7.7.tar.gz : CHECKSUM(SHA256) this package : 6055a2abccc64296e1c38f9652f2056d3a3c096538e164b8b9526e10b486b3d8 CHECKSUM(SHA256) upstream package : 6055a2abccc64296e1c38f9652f2056d3a3c096538e164b8b9526e10b486b3d8 Requires -------- normalize (rpmlib, GLIBC filtered): /usr/bin/perl flac lame libaudiofile.so.1()(64bit) libc.so.6()(64bit) libm.so.6()(64bit) libmad.so.0()(64bit) perl(Fcntl) rtld(GNU_HASH) vorbis-tools normalize-debuginfo (rpmlib, GLIBC filtered): normalize-debugsource (rpmlib, GLIBC filtered): Provides -------- normalize: normalize normalize(x86-64) normalize-debuginfo: debuginfo(build-id) normalize-debuginfo normalize-debuginfo(x86-64) normalize-debugsource: normalize-debugsource normalize-debugsource(x86-64) AutoTools: Obsoleted m4s found ------------------------------ AM_PROG_LIBTOOL found in: normalize-0.7.7/configure.ac:225 Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -b 2076111 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Generic, Shell-api Disabled plugins: Python, Perl, PHP, Java, SugarActivity, R, Ocaml, fonts, Haskell, Ruby Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH Comments: a) Some obsolete m4 macros. Maybe patches can be sent upstream? b) Tests are available, please add a make check section c) Can explanations for the patches be added? d) Builds on required architectures https://copr.fedorainfracloud.org/coprs/fed500/normalize/build/4944631/ e) Still some warnings from autreconf and configure
f) 3 files have GNU Library General Public License v2 or later normalize-0.7.7/src/getopt.c normalize-0.7.7/src/getopt.h normalize-0.7.7/src/getopt1.c
Fixed b, c and f. Spec URL: https://rathann.fedorapeople.org/review/normalize/normalize.spec SRPM URL: https://rathann.fedorapeople.org/review/normalize/normalize-0.7.7-28.fc37.src.rpm * Mon Jan 16 2023 Dominik Mierzejewski <dominik> - 0.7.7-28 - add mpg123 to dependencies (required for mp3 decoding) - use SPDX license identifiers - enable tests - describe patches As for a, upstream is pretty much dead (last release in 2005).
Copr build: https://copr.fedorainfracloud.org/coprs/build/5238066 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2076111-normalize/srpm-builds/05238066/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
Spec URL: https://rathann.fedorapeople.org/review/normalize/normalize.spec SRPM URL: https://rathann.fedorapeople.org/review/normalize/normalize-0.7.7-28.fc38.src.rpm Corrected SRPM URL. :)
Copr build: https://copr.fedorainfracloud.org/coprs/build/5240665 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2076111-normalize/fedora-rawhide-x86_64/05240665-normalize/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
Benson, is anything required from my side or is this ready to be approved?
In general it seems ok and runs. There are a few unresolved issues upstream: https://savannah.nongnu.org/bugs/?group=normalize Will you or someone else be able to maintain it or fix bugs if needed? This is not a blocker at present, but is probably something that needs to be added to the packaging guidelines.
(In reply to Benson Muite from comment #12) > In general it seems ok and runs. > > There are a few unresolved issues upstream: > https://savannah.nongnu.org/bugs/?group=normalize > > Will you or someone else be able to maintain it or fix bugs if needed? We've established Multimedia SIG in Fedora to help maintain multimedia-related packages. I intend to maintain the package in Fedora and respond to bugs filed in Fedora. If upstream doesn't respond to issues, I'll consider including proposed patches like the one from Debian in https://savannah.nongnu.org/bugs/?58504 . > This is not a blocker at present, but is probably something that needs to be > added to the packaging guidelines. Please take that up with the Packaging Committee. Can you please complete the review?
Thanks. Approved.
The Pagure repository was created at https://src.fedoraproject.org/rpms/normalize
FEDORA-2023-9157ee0e70 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-9157ee0e70
FEDORA-2023-c06b29a05f has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-c06b29a05f
FEDORA-2023-9157ee0e70 has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-9157ee0e70 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-9157ee0e70 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-c06b29a05f has been pushed to the Fedora 37 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-c06b29a05f \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-c06b29a05f See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-c06b29a05f has been pushed to the Fedora 37 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2023-9157ee0e70 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.