Bug 2076657 - Review Request: rust-integer-encoding - Varint+zigzag and fixedint integer encoding/decoding
Summary: Review Request: rust-integer-encoding - Varint+zigzag and fixedint integer en...
Keywords:
Status: CLOSED CANTFIX
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-04-19 14:50 UTC by Carmelo Sarta
Modified: 2023-03-22 22:39 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-03-22 22:39:46 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Carmelo Sarta 2022-04-19 14:50:17 UTC
Spec URL: https://raw.githubusercontent.com/Laiot/rust-integer-encoding-rpm/master/rust-integer-encoding.spec
SRPM URL: https://github.com/Laiot/rust-integer-encoding-rpm/raw/master/rust-integer-encoding-3.0.3-1.fc36.src.rpm
Description: Varint+zigzag and fixedint integer encoding/decoding
Fedora Account System Username: laiot

Comment 1 Fabio Valentini 2022-05-01 14:37:22 UTC
Two small things:

- trim the Summary in the spec file the same way you did for the bug title (i.e. remove the URL in parentheses)
- exclude the "coverage.sh" script from being included in packaged files (i.e. by patching Cargo.toml to add "exclude = ["/coverage.sh"]")

Other than that, I'm only curious what you're packaging this crate for :)

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

Comment 2 Gwyn Ciesla 2022-05-02 15:20:22 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-integer-encoding

Comment 3 Fabio Valentini 2022-05-02 20:33:59 UTC
Hey, looks like you missed one of my comments:

- exclude the "coverage.sh" script from being included in packaged files (i.e. by patching Cargo.toml to add "exclude = ["/coverage.sh"]")

And the build failed due to what looks like endianness-related problems (s390x is our only big-endian architecture).
You might want to report this with the upstream project, otherwise the crate will most probably not work correctly on s390x.

Comment 4 Carmelo Sarta 2022-05-02 22:14:14 UTC
Sorry about that, I just pushed the patched .spec but apparently you're right, the build fails. I will report this to the upstream project.

Comment 5 Fabio Valentini 2022-10-14 12:01:45 UTC
Looks like this is the issue you reported?
https://github.com/dermesser/integer-encoding-rs/issues/24

Please follow up there.

Comment 6 Fabio Valentini 2023-03-22 22:39:46 UTC
The package was retired from Fedora 38+.


Note You need to log in before you can comment on or make changes to this bug.