Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://download.copr.fedorainfracloud.org/results/salimma/misc-wip/fedora-rawhide-x86_64/04294494-jigdo/jigdo.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/salimma/misc-wip/fedora-rawhide-x86_64/04294494-jigdo/jigdo-0.8.1-1.fc37.src.rpm Description: Jigsaw Download (for short jigdo) is a scheme developed primarily to make it easy to distribute huge filesystem images (e.g. CD (ISO9660) or DVD (UDF) images) over the internet, but it could also be used for other data which is awkward to handle due to its size, like audio/video files or large software packages. jigdo tries to ensure that the large file is downloaded in small parts which can be stored on different servers. People who want to download the image do so by telling the jigdo download tool to process one ".jigdo" file; using it, jigdo downloads the parts and reassembles the image. jigdo-file is used to prepare the files for download. Fedora Account System Username: salimma COPR builds and review templates: https://copr.fedorainfracloud.org/coprs/salimma/misc-wip/build/4294494/ NOTE: This is part of the package unretirement process
Taking this review.
> # debugsourcefiles.list is empty (though debugfiles.list has content) > %global debug_package %{nil} This sounds like we've got something goofy with how compiler flags are propagated into the code. Looking at the build logs, I notice that "-g" doesn't actually propagate into the build itself. You might want to check to see if there's a way to keep things from stripping build flags...
(In reply to Neal Gompa from comment #2) > > # debugsourcefiles.list is empty (though debugfiles.list has content) > > %global debug_package %{nil} > > This sounds like we've got something goofy with how compiler flags are > propagated into the code. Looking at the build logs, I notice that "-g" > doesn't actually propagate into the build itself. You might want to check to > see if there's a way to keep things from stripping build flags... yeah, I'll take another look. When checking the build directories though - debugfiles.list is not empty, just debugsourcefiles. Which was... weird. But maybe debugfiles.list != the files are compiled with debugging info.
So I had to read configure.ac, since it's easier than reading the generated configure, and... sigh CFLAGS=`echo "$CFLAGS" | sed 's/\(^\| \)-g\( \|$\)/ /'` ... nonono.
Fixed: COPR builds and review templates: https://copr.fedorainfracloud.org/coprs/salimma/misc-wip/build/4294663/ Spec URL: https://download.copr.fedorainfracloud.org/results/salimma/misc-wip/fedora-rawhide-x86_64/04294663-jigdo/jigdo.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/salimma/misc-wip/fedora-rawhide-x86_64/04294663-jigdo/jigdo-0.8.1-1.fc37.src.rpm
Review notes: * Packaging complies with the guidelines * Package builds and installs * No serious issues from rpmlint * Licensing is correct and license files are correctly installed PACKAGE APPROVED.
Thanks! Unretirement request: https://pagure.io/releng/issue/10754
Built for Rawhide. Requesting the other branches now jigdo on rawhide [?] ❯ fedpkg request-branch --all-releases https://pagure.io/releng/fedora-scm-requests/issue/43808 https://pagure.io/releng/fedora-scm-requests/issue/43809 https://pagure.io/releng/fedora-scm-requests/issue/43810 jigdo on rawhide [?] took 7s ❯ fedpkg request-branch epel9 https://pagure.io/releng/fedora-scm-requests/issue/43811 jigdo on rawhide [?] took 5s ❯ fedpkg request-branch epel8 https://pagure.io/releng/fedora-scm-requests/issue/43812
FEDORA-EPEL-2022-44213d365d has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-44213d365d
FEDORA-2022-4dd42b644f has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-4dd42b644f
FEDORA-EPEL-2022-ff4479fc04 has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-ff4479fc04
FEDORA-2022-72a3a5e07f has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-72a3a5e07f
FEDORA-2022-6c722cfd6a has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2022-6c722cfd6a
FEDORA-2022-4dd42b644f has been pushed to the Fedora 36 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-4dd42b644f \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-4dd42b644f See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2022-6c722cfd6a has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-6c722cfd6a \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-6c722cfd6a See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2022-72a3a5e07f has been pushed to the Fedora 35 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-72a3a5e07f \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-72a3a5e07f See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-EPEL-2022-ff4479fc04 has been pushed to the Fedora EPEL 8 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-ff4479fc04 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-EPEL-2022-44213d365d has been pushed to the Fedora EPEL 9 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-44213d365d See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2022-6c722cfd6a has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2022-72a3a5e07f has been pushed to the Fedora 35 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-EPEL-2022-44213d365d has been pushed to the Fedora EPEL 9 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-EPEL-2022-ff4479fc04 has been pushed to the Fedora EPEL 8 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2022-4dd42b644f has been pushed to the Fedora 36 stable repository. If problem still persists, please make note of it in this bug report.