Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 2078991

Summary:	Backport to add sysinfo_serial parameter to control a Serial number entry generation method.
Product:	Red Hat OpenStack	Reporter:	Siggy Sigwald <ssigwald>
Component:	puppet-nova	Assignee:	Bogdan Dobrelya <bdobreli>
Status:	CLOSED ERRATA	QA Contact:	Jason Grosso <jgrosso>
Severity:	high	Docs Contact:
Priority:	high
Version:	16.2 (Train)	CC:	alifshit, aruffin, bdobreli, bgibizer, dasmith, eglynn, jgrosso, jhakimra, jjoyce, jparker, jschluet, kchamart, nlevinki, sbauza, sgordon, slinaber, tvignaud, vromanso
Target Milestone:	z4	Keywords:	Triaged
Target Release:	16.2 (Train on RHEL 8.4)
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	puppet-nova-15.8.1-2.20220528005432.99908de.el8ost	Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-12-07 19:22:27 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	2139854
Bug Blocks:	2081800

Description Siggy Sigwald 2022-04-26 16:33:11 UTC

Description of problem:
Looks like unique per-instance serial numbers to servers feature was added in stein based on openstack documentation[1]
In OSP 16, default choice for sysinfo is to instance UUID as serial number; where as old version of OSP13 is using host serial UUID

In OSP13 , from the virsh dumpxml

<sysinfo type='smbios'>
<system>
<entry name='manufacturer'>Cisco Systems(Equinix)</entry>
<entry name='product'>OpenStack Compute</entry>
<entry name='version'>20.4.1-cisco.1.20210708183306.el8</entry>
<entry name='serial'>**27a87a5e-bf66-4544-bde8-234c909fd9fa**</entry>
<entry name='uuid'>259f237e-390b-4d0c-bcc6-a7c2cdbcbc67</entry>
<entry name='family'>Virtual Machine</entry>
</system>
</sysinfo>

In OSP16 , from the virsh dumpxml

<sysinfo type='smbios'>
<system>
<entry name='manufacturer'>Cisco Systems(Equinix)</entry>
<entry name='product'>OpenStack Compute</entry>
<entry name='version'>20.4.1-cisco.1.20210708183306.el8</entry>
<entry name='serial'>**259f237e-390b-4d0c-bcc6-a7c2cdbcbc67**</entry>
<entry name='uuid'>259f237e-390b-4d0c-bcc6-a7c2cdbcbc67</entry>
<entry name='family'>Virtual Machine</entry>
</system>
</sysinfo>

[1]https://specs.openstack.org/openstack/nova-specs/specs/stein/implemented/per-instance-libvirt-sysinfo-serial.html#id3

As per a rhos-tech thread:

Hiera overrides for nova::config::nova_config in role ExtraConfig often
causes puppet double declaration errors. So a direct hiera override

nova::compute::libvirt::sysinfo_serial: auto

should be preferred. Here is the feature patch [0] for that. We can
backport it down to Train, and have it for OSP16.x as well.

[0] https://review.opendev.org/c/openstack/puppet-nova/+/839310

Comment 1 aruffin@redhat.com 2022-04-28 21:10:01 UTC

Questions from cu:

1. If we change this setting of sysinfo_serial : "auto" in nova.conf and restart the compute; whether the existing VNF will get changed to this option.

2. when you say this settings will be backported to trains, what would be the default value of "sysinfo_serial" in OSP trains and future releases ?

Comment 2 Bogdan Dobrelya 2022-05-02 14:42:49 UTC

The linked patch is to be backported to Train (ans OSP16.2). It would not change defaults but only provide a direct hiera overriding interface for it, via the role ExtraConfig settings, by usual meanings.

Comment 3 Artom Lifshitz 2022-05-04 16:20:26 UTC

This is caused by [1] changing the default of [libvirt]sysinfo_serial from `auto` in queens to `unique`. As this can have FFU impact, we think landing [2] and backporting to stable/train is a valid thing to do. I've also filed https://bugzilla.redhat.com/show_bug.cgi?id=2081800 to track the documentation impact.

[1] https://github.com/openstack/nova/blob/stable/train/nova/conf/libvirt.py#L738
[2] https://review.opendev.org/c/openstack/puppet-nova/+/839310

Comment 15 errata-xmlrpc 2022-12-07 19:22:27 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Release of components for Red Hat OpenStack Platform 16.2.4), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:8794