RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 2079188 - sos report does not honor plugin's default plugin_timeout
Summary: sos report does not honor plugin's default plugin_timeout
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 9
Classification: Red Hat
Component: sos
Version: 9.1
Hardware: All
OS: Linux
high
high
Target Milestone: rc
: ---
Assignee: Pavel Moravec
QA Contact: Adriana Jurkechova
URL:
Whiteboard:
: 2097675 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-04-27 07:32 UTC by Pavel Moravec
Modified: 2022-11-15 12:54 UTC (History)
8 users (show)

Fixed In Version: sos-4.3-2.el9
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-11-15 11:12:29 UTC
Type: Bug
Target Upstream Version:
Embargoed:
pm-rhel: mirror+

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github sosreport sos pull 2864 0 None Merged [report] Honor plugins' hardcoded plugin_timeout 2022-04-27 07:32:03 UTC
Red Hat Issue Tracker RHELPLAN-120716 0 None None None 2022-05-02 07:00:03 UTC
Red Hat Product Errata RHEA-2022:8275 0 None None None 2022-11-15 11:12:42 UTC

Description Pavel Moravec 2022-04-27 07:32:03 UTC 
This bug was initially created as a copy of Bug #2055547

I am copying this bug because: 

It will be fixed in 9.0 so to prevent regression, we need to backport the fix into 9.1 as well.

Description of problem:
Wired plugins' default_tieout is silently ignored. This means, default "sos report" will ignore foreman's default_timeout = 1800 and will use default --plugin-timeout default value 300. Which would often truncate the plugin's execution in the middle.

https://github.com/sosreport/sos/pull/2864 needs to be backported to 8.6/9.0


Version-Release number of selected component (if applicable):
sos-4.2-*


How reproducible:
100%


Steps to Reproduce:
1. sos report -o foreman --batch --build
2. In generated sosreport:

grep -A10 foreman -m2 ${sosdir}/sos_reports/manifest.json


Actual results:
2. shows:
..
--
                "foreman": {
                    ..
                    "timeout": 300, 
                    ..


Expected results:
2. must show:
..
--
                "foreman": {
                    ..
                    "timeout": 1800, 
                    ..

Additional info:
Comment 2 Pavel Moravec 2022-06-16 10:19:43 UTC 
*** Bug 2097675 has been marked as a duplicate of this bug. ***
Comment 3 Adriana Jurkechova 2022-07-08 11:32:49 UTC 
Switching to Tested based on results from OSCI dashboard. Tested on RHEL 9.1 Beta x86_64.

Old:
===

::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
::   Setup
::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::

:: [ 09:07:10 ] :: [   INFO   ] :: rlImport: Found 'sos/utils', version '1.0-18' in /mnt/tests
:: [ 09:07:10 ] :: [   INFO   ] :: rlImport: Will try to import sos/utils from /mnt/tests/CoreOS/sos/Library/utils/lib.sh
:: [ 09:07:10 ] :: [   INFO   ] :: found dependencies: ''
:: [ 09:07:10 ] :: [   PASS   ] :: sos/utils library loaded, variables defined (Expected 0, got 0)
:: [ 09:07:11 ] :: [   PASS   ] :: Checking for the presence of sos rpm 
:: [ 09:07:11 ] :: [   LOG    ] :: Package versions:
:: [ 09:07:11 ] :: [   LOG    ] ::   sos-4.3-1.el9.noarch

...

::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
::   Test
::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::

:: [ 09:07:11 ] :: [   INFO   ] :: Running sos report and test if default plugin timeout is used:
:: [ 09:07:14 ] :: [   PASS   ] :: sosReport: generating new report (Expected 0, got 0)
:: [ 09:07:14 ] :: [   PASS   ] :: sosReport: listing generated report (Expected 0, got 0)
:: [ 09:07:14 ] :: [   PASS   ] :: sosAssertFileIncluded 'sos_reports/manifest.json' (Expected 0, got 0)
:: [ 09:07:14 ] :: [   PASS   ] :: Unpacking sosreport (Expected 0, got 0)
:: [ 09:07:14 ] :: [   FAIL   ] :: Plugin default timeout is used (Assert: '300' should equal '1800')
::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
::   Duration: 3s
::   Assertions: 4 good, 1 bad
::   RESULT: FAIL (Test)

New:
===
::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
::   Setup
::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::

:: [ 07:20:28 ] :: [   INFO   ] :: rlImport: Found 'sos/utils', version '1.0-18' in /mnt/tests
:: [ 07:20:28 ] :: [   INFO   ] :: rlImport: Will try to import sos/utils from /mnt/tests/CoreOS/sos/Library/utils/lib.sh
:: [ 07:20:28 ] :: [   INFO   ] :: found dependencies: ''
:: [ 07:20:28 ] :: [   PASS   ] :: sos/utils library loaded, variables defined (Expected 0, got 0)
:: [ 07:20:28 ] :: [   PASS   ] :: Checking for the presence of sos rpm 
:: [ 07:20:28 ] :: [   LOG    ] :: Package versions:
:: [ 07:20:28 ] :: [   LOG    ] ::   sos-4.3-2.el9.noarch

...

::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
::   Test
::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::

:: [ 07:20:29 ] :: [   INFO   ] :: Running sos report and test if default plugin timeout is used:
:: [ 07:20:32 ] :: [   PASS   ] :: sosReport: generating new report (Expected 0, got 0)
:: [ 07:20:32 ] :: [   PASS   ] :: sosReport: listing generated report (Expected 0, got 0)
:: [ 07:20:32 ] :: [   PASS   ] :: sosAssertFileIncluded 'sos_reports/manifest.json' (Expected 0, got 0)
:: [ 07:20:32 ] :: [   PASS   ] :: Unpacking sosreport (Expected 0, got 0)
:: [ 07:20:32 ] :: [   PASS   ] :: Plugin default timeout is used (Assert: '1800' should equal '1800')
::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
::   Duration: 3s
::   Assertions: 5 good, 0 bad
::   RESULT: PASS (Test)
Comment 8 errata-xmlrpc 2022-11-15 11:12:29 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (sos bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2022:8275
Note You need to log in before you can comment on or make changes to this bug.