Bug 2079198 - Editting of an existing contact creates another entry with empty content.
Summary: Editting of an existing contact creates another entry with empty content.
Keywords:
Status: NEW
Alias: None
Product: Fedora
Classification: Fedora
Component: gnome-contacts
Version: 36
Hardware: x86_64
OS: Linux
unspecified
high
Target Milestone: ---
Assignee: Kalev Lember
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: AcceptedFreezeException RejectedBlocker
Depends On:
Blocks: F36FinalFreezeException
TreeView+ depends on / blocked
 
Reported: 2022-04-27 07:48 UTC by Lukas Ruzicka
Modified: 2022-04-28 19:43 UTC (History)
8 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: Bug


Attachments (Terms of Use)
The video of the situation. (282.08 KB, video/webm)
2022-04-27 07:48 UTC, Lukas Ruzicka
no flags Details
contacts with same email (3.30 MB, video/webm)
2022-04-27 10:04 UTC, Kamil Páral
no flags Details


Links
System ID Private Priority Status Summary Last Updated
GNOME Gitlab GNOME gnome-contacts issues 232 0 None opened Duplicate empty contacts are created when adding fields to a contact 2022-04-27 15:59:08 UTC

Description Lukas Ruzicka 2022-04-27 07:48:53 UTC
Created attachment 1875257 [details]
The video of the situation.

Description of problem:

When users want to edit an existing contact (add a record to it), the action creates a new (empty) contact with the same name, so it looks like there are suddenly two same contacts in the contact list, one is empty and the other is the original (now updated) contact.

Version-Release number of selected component (if applicable):
gnome-contacts-42.0-1.fc36.x86_64

How reproducible:
Always

Steps to Reproduce:
1. See the attached video.

Actual results:

An updated contant gets doubled.

Expected results:

The contact should be updated with no issues.

Comment 1 Fedora Blocker Bugs Application 2022-04-27 07:51:06 UTC
Proposed as a Blocker for 36-final by Fedora user lruzicka using the blocker tracking app because:

 I am proposing this as a blocker because it might violate the Basic functionality criteria.

Comment 2 Kamil Páral 2022-04-27 08:28:19 UTC
I can confirm this problem. However, it seems to happen only if you change the email, changing other fields doesn't trigger it. Also, after you restart the application, the duplicate contact is gone, and there's only one contact with the correct (updated) email.

Comment 3 Kamil Páral 2022-04-27 10:04:42 UTC
Created attachment 1875308 [details]
contacts with same email

The email handling is even more confusing. A probably-related issue: Instead of editing the email, if you instead create a new contact with the same email (intentionally or by accident), then you'll see the contact *description* (and not just name) duplicated. Each section is there twice, once normally and once under "Local Contact". The displayed name randomly switches between the first and the second contact name. If you delete the contact, one of two things randomly happen: a) both contacts are deleted b) only one contact is deleted, and the second one appears after a while in your address book with its original details.

I can split this into a separate bug if you want. But it might be caused by the same problem - broken email handling.

Comment 4 Ben Cotton 2022-04-27 15:50:18 UTC
I see what you mean. I'm inclined to say create a separate bug for this. It may be the same problem or it may not. In any case, I voted -1 for blocking on this based on comment 0, but I'm leaning toward +1 for a comment 3 bug. So at least for the purposes of the blocker process, it's probably better to split them.

Comment 5 Niels De Graef 2022-04-28 13:00:17 UTC
Hi, Contacts maintainer here (who didn't follow fedora BZs about it until now):

When you start up gnome-contacts, does it give you a warning (sometimes after a few seconds) from libfolks about some E-D-S store not being found?

After that, can you go to the "Change Addressbook" dialog and see if any addressbook is checked?

If any item is selected, I would suspect it's because the "local address book" is checked. Can you confirm?

Comment 6 Kamil Páral 2022-04-28 13:24:34 UTC
(In reply to Niels De Graef from comment #5)
> When you start up gnome-contacts, does it give you a warning (sometimes
> after a few seconds) from libfolks about some E-D-S store not being found?

I don't see any message in journal from gnome-contacts of libfolks, if I just start the app and wait.

> After that, can you go to the "Change Addressbook" dialog and see if any
> addressbook is checked?

Local Address Book is checked (no other is available). [1]

> If any item is selected, I would suspect it's because the "local address
> book" is checked. Can you confirm?

Yes.


[1] Please note that there's a little bug when starting gnome-contacts for the first time. It allows you to select address book, and local address book seems to be checked, but you can't continue, until you click on it at least once. I believe the item is not really checked, it just looks checked. The issue is even more visible if you add an online account before hand - if you click on the online address book in the initial dialog, you can see both items checked, local and online. But I don't think this affects anything, I think it's just a UI-related glitch.

Comment 7 Ben Cotton 2022-04-28 19:18:59 UTC
In today's Go/No-Go meeting, we agreed to reject this as a blocker and accept it as a freeze exception. This falls outside of "basic functionality", but is worth fixing if possible
https://meetbot.fedoraproject.org/fedora-meeting/2022-04-28/f36-final-go_no_go-meeting.2022-04-28-17.01.html


Note You need to log in before you can comment on or make changes to this bug.