Spec URL: https://petersen.fedorapeople.org/reviews/ghc-enummapset/ghc-enummapset.spec SRPM URL: https://petersen.fedorapeople.org/reviews/ghc-enummapset/ghc-enummapset-0.6.0.3-1.fc36.src.rpm Description: This package contains simple wrappers around 'Data.IntMap' and 'Data.IntSet' with 'Enum' keys and elements respectively. Especially useful for 'Int's wrapped with `newtype`. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=86384563
Needed for the calligraphy tool
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time. We're sorry it is taking so long. If you're still interested in packaging this software into Fedora repositories, please respond to this comment clearing the NEEDINFO flag. You may want to update the specfile and the src.rpm to the latest version available and to propose a review swap on Fedora devel mailing list to increase chances to have your package reviewed. If this is your first package and you need a sponsor, you may want to post some informal reviews. Read more at https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group. Without any reply, this request will shortly be considered abandoned and will be closed. Thank you for your patience.
Also required by ghcide and hls plugins
Spec URL: https://petersen.fedorapeople.org/reviews/ghc-enummapset/ghc-enummapset.spec SRPM URL: https://petersen.fedorapeople.org/reviews/ghc-enummapset/ghc-enummapset-0.7.3.0-1.fc43.src.rpm - update to version 0.7.3.0
Copr build: https://copr.fedorainfracloud.org/coprs/build/9086451 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2080130-ghc-enummapset/fedora-rawhide-x86_64/09086451-ghc-enummapset/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
ackage Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* BSD 3-Clause License", "Unknown or generated". 11 files have unknown license. Detailed output of licensecheck in /home/fedora-packaging/reviews/ghc-enumapset/2080130-ghc- enummapset/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 611 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in ghc- enummapset-prof [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: ghc-enummapset-0.7.3.0-1.fc43.x86_64.rpm ghc-enummapset-devel-0.7.3.0-1.fc43.x86_64.rpm ghc-enummapset-prof-0.7.3.0-1.fc43.x86_64.rpm ghc-enummapset-0.7.3.0-1.fc43.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.6.1 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp5casx0kd')] checks: 32, packages: 4 ghc-enummapset-devel.x86_64: E: static-library-without-debuginfo /usr/lib64/ghc-9.8.4/lib/enummapset-0.7.3.0/libHSenummapset-0.7.3.0-2vbvztsjsohGIHwqz5RWUg.a ghc-enummapset-prof.x86_64: E: static-library-without-debuginfo /usr/lib64/ghc-9.8.4/lib/enummapset-0.7.3.0/libHSenummapset-0.7.3.0-2vbvztsjsohGIHwqz5RWUg_p.a ghc-enummapset.src: E: spelling-error ('IntMap', '%description -l en_US IntMap -> Int Map, Int-map, Bitmap') ghc-enummapset.src: E: spelling-error ('IntSet', '%description -l en_US IntSet -> Int Set, Int-Set, Inset') ghc-enummapset.src: E: spelling-error ('newtype', '%description -l en_US newtype -> new type, new-type, tintype') ghc-enummapset.x86_64: E: spelling-error ('IntMap', '%description -l en_US IntMap -> Int Map, Int-map, Bitmap') ghc-enummapset.x86_64: E: spelling-error ('IntSet', '%description -l en_US IntSet -> Int Set, Int-Set, Inset') ghc-enummapset.x86_64: E: spelling-error ('newtype', '%description -l en_US newtype -> new type, new-type, tintype') ghc-enummapset.x86_64: W: no-documentation ghc-enummapset-prof.x86_64: W: no-documentation ghc-enummapset.spec: W: no-%check-section 4 packages and 0 specfiles checked; 8 errors, 3 warnings, 20 filtered, 8 badness; has taken 0.7 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 ghc-enummapset.x86_64: E: unused-direct-shlib-dependency /usr/lib64/ghc-9.8.4/lib/libHSenummapset-0.7.3.0-2vbvztsjsohGIHwqz5RWUg-ghc9.8.4.so /lib64/libm.so.6 ghc-enummapset.x86_64: E: unused-direct-shlib-dependency /usr/lib64/ghc-9.8.4/lib/libHSenummapset-0.7.3.0-2vbvztsjsohGIHwqz5RWUg-ghc9.8.4.so /usr/lib64/ghc-9.8.4/lib/libHSwitherable-0.5-J2Yej31FajyK9tGbuilpSt-ghc9.8.4.so ghc-enummapset.x86_64: E: unused-direct-shlib-dependency /usr/lib64/ghc-9.8.4/lib/libHSenummapset-0.7.3.0-2vbvztsjsohGIHwqz5RWUg-ghc9.8.4.so /usr/lib64/ghc-9.8.4/lib/libHSuuid-types-1.0.6-IrV06Nx9KAt4WKuG0a9BQI-ghc9.8.4.so ... ghc-enummapset-prof.x86_64: E: static-library-without-debuginfo /usr/lib64/ghc-9.8.4/lib/enummapset-0.7.3.0/libHSenummapset-0.7.3.0-2vbvztsjsohGIHwqz5RWUg_p.a ghc-enummapset-devel.x86_64: E: static-library-without-debuginfo /usr/lib64/ghc-9.8.4/lib/enummapset-0.7.3.0/libHSenummapset-0.7.3.0-2vbvztsjsohGIHwqz5RWUg.a ghc-enummapset.x86_64: E: spelling-error ('IntMap', '%description -l en_US IntMap -> Int Map, Int-map, Bitmap') ghc-enummapset.x86_64: E: spelling-error ('IntSet', '%description -l en_US IntSet -> Int Set, Int-Set, Inset') ghc-enummapset.x86_64: E: spelling-error ('newtype', '%description -l en_US newtype -> new type, new-type, tintype') ghc-enummapset-prof.x86_64: W: no-documentation ghc-enummapset.x86_64: W: no-documentation 3 packages and 0 specfiles checked; 2074 errors, 2 warnings, 16 filtered, 2074 badness; has taken 1.4 s Unversioned so-files -------------------- ghc-enummapset: /usr/lib64/ghc-9.8.4/lib/libHSenummapset-0.7.3.0-2vbvztsjsohGIHwqz5RWUg-ghc9.8.4.so Source checksums ---------------- https://hackage.haskell.org/package/enummapset-0.7.3.0/enummapset-0.7.3.0.tar.gz : CHECKSUM(SHA256) this package : 74c805415005f065379d644b2f2530d297b1cff650e5ef269a479220afdf7070 CHECKSUM(SHA256) upstream package : 74c805415005f065379d644b2f2530d297b1cff650e5ef269a479220afdf7070 Requires -------- ghc-enummapset (rpmlib, GLIBC filtered): libHSOneTuple-0.4.2-JdYQTzVZvDwGTkWqXjHkCy-ghc9.8.4.so()(64bit) libHSQuickCheck-2.14.3-7ThNmMPNMozCVAKcpIEBnn-ghc9.8.4.so()(64bit) libHSStateVar-1.2.2-JiXIFd7ycvv2DVTXgNl5Sl-ghc9.8.4.so()(64bit) libHSaeson-2.2.3.0-LVN644RDSGV1pDguDpiuz3-ghc9.8.4.so()(64bit) libHSarray-0.5.8.0-fb6f-ghc9.8.4.so()(64bit) libHSassoc-1.1.1-KIaHsSxUnU4KC0E35UVVI5-ghc9.8.4.so()(64bit) libHSbase-4.19.2.0-6e03-ghc9.8.4.so()(64bit) libHSbase-orphans-0.9.3-6ZvEtEcQN8bAC5hVcbpbvH-ghc9.8.4.so()(64bit) libHSbifunctors-5.6.2-IRemgndUqeGCjhIYjBtUNs-ghc9.8.4.so()(64bit) libHSbinary-0.8.9.1-3bda-ghc9.8.4.so()(64bit) libHSbytestring-0.12.1.0-bb11-ghc9.8.4.so()(64bit) libHScharacter-ps-0.1-LVXKK9pecML2xjQKW56ckS-ghc9.8.4.so()(64bit) libHScomonad-5.0.9-2WEDJQNruA7BWfoDTisgJT-ghc9.8.4.so()(64bit) libHScontainers-0.6.8-b2d8-ghc9.8.4.so()(64bit) libHScontravariant-1.5.5-JZEuMViZbMOERhRQ9f2EK4-ghc9.8.4.so()(64bit) libHSdata-fix-0.3.4-8L32rhurBEr3omLqvQrtWV-ghc9.8.4.so()(64bit) libHSdeepseq-1.5.1.0-0513-ghc9.8.4.so()(64bit) libHSdistributive-0.6.2.1-JsMJNI6TslfIkRDXlWRu4x-ghc9.8.4.so()(64bit) libHSdlist-1.0-H2yjbd4lEhUOfbwdbL7xX-ghc9.8.4.so()(64bit) libHSexceptions-0.10.7-302f-ghc9.8.4.so()(64bit) libHSfilepath-1.4.301.0-b305-ghc9.8.4.so()(64bit) libHSgenerically-0.1.1-D1eJBngfb9z8DPIpEzhOCA-ghc9.8.4.so()(64bit) libHSghc-bignum-1.3-6046-ghc9.8.4.so()(64bit) libHSghc-boot-th-9.8.4-73a9-ghc9.8.4.so()(64bit) libHSghc-prim-0.11.0-a7b1-ghc9.8.4.so()(64bit) libHShashable-1.4.7.0-4sYUjiqCRWp1Ivr6Bfittp-ghc9.8.4.so()(64bit) libHSindexed-traversable-0.1.4-LAa2TiQLgC0L6nx10uqu30-ghc9.8.4.so()(64bit) libHSindexed-traversable-instances-0.1.2-2eGEJSt9Qiu6VE7IgiYmrz-ghc9.8.4.so()(64bit) libHSinteger-conversion-0.1.1-EBOfWf4kar7Aavgmxcr2ia-ghc9.8.4.so()(64bit) libHSinteger-logarithms-1.0.4-FUO74u7wCELK1xUt9Vj8EO-ghc9.8.4.so()(64bit) libHSmtl-2.3.1-7365-ghc9.8.4.so()(64bit) libHSnetwork-uri-2.6.4.2-F2UsnxbDK7BH8XhFY5000P-ghc9.8.4.so()(64bit) libHSos-string-2.0.7-LjoE4uZSBZ73BbdeBYQJa6-ghc9.8.4.so()(64bit) libHSparsec-3.1.17.0-db41-ghc9.8.4.so()(64bit) libHSpretty-1.1.3.6-b6ac-ghc9.8.4.so()(64bit) libHSprimitive-0.9.0.0-9lWW508Z1zq4f32hztDYir-ghc9.8.4.so()(64bit) libHSrandom-1.2.1.3-ILLUQbUmpZA0bdz7RIdNQ-ghc9.8.4.so()(64bit) libHSscientific-0.3.8.0-4FfTWjk2XJoF0zwjyZyzdv-ghc9.8.4.so()(64bit) libHSsemialign-1.3.1-6V74rVtghGTBhUNWDemNtp-ghc9.8.4.so()(64bit) libHSsemigroupoids-6.0.1-1GoTWiN3v41BUik9ozh3aE-ghc9.8.4.so()(64bit) libHSsplitmix-0.1.1-EOOzlisW0ha6xqy8OmZkpY-ghc9.8.4.so()(64bit) libHSstm-2.5.3.1-ca51-ghc9.8.4.so()(64bit) libHSstrict-0.5.1-gzmuAqAdvt3TUspeushIr-ghc9.8.4.so()(64bit) libHStagged-0.8.8-GyrslFoLiphJ2P1vvH48n6-ghc9.8.4.so()(64bit) libHStemplate-haskell-2.21.0.0-98b0-ghc9.8.4.so()(64bit) libHStext-2.1.1-1bf1-ghc9.8.4.so()(64bit) libHStext-iso8601-0.1.1-Kpp3Tbccxmj8BJTCNBa6bj-ghc9.8.4.so()(64bit) libHStext-short-0.1.6-8qrw6oMVBIBDB1EEF0NUU4-ghc9.8.4.so()(64bit) libHSth-abstraction-0.7.1.0-80oylQNbrmxDZOJexbHcoi-ghc9.8.4.so()(64bit) libHSth-compat-0.1.6-5uSpvSxMHUYAYf3g8aE5WZ-ghc9.8.4.so()(64bit) libHSthese-1.2.1-DbZnELJ2IRTI8Xi0i4r2hP-ghc9.8.4.so()(64bit) libHStime-1.12.2-7526-ghc9.8.4.so()(64bit) libHStime-compat-1.9.7-F8ATBNZN1rvAgv6TtwIYf7-ghc9.8.4.so()(64bit) libHStransformers-0.6.1.0-da7f-ghc9.8.4.so()(64bit) libHStransformers-compat-0.7.2-9uBIUn9bgjL3AwHN60vb9R-ghc9.8.4.so()(64bit) libHSunordered-containers-0.2.20-KA9cmPMMMq97KcjgGqmnLp-ghc9.8.4.so()(64bit) libHSuuid-types-1.0.6-IrV06Nx9KAt4WKuG0a9BQI-ghc9.8.4.so()(64bit) libHSvector-0.13.2.0-WoGhxe9rar2AgNN1w6KXF-ghc9.8.4.so()(64bit) libHSvector-stream-0.1.0.1-KENGI2ESqaZ3hdcHDMqAVW-ghc9.8.4.so()(64bit) libHSwitherable-0.5-J2Yej31FajyK9tGbuilpSt-ghc9.8.4.so()(64bit) libc.so.6()(64bit) libgmp.so.10()(64bit) libm.so.6()(64bit) rtld(GNU_HASH) ghc-enummapset-devel (rpmlib, GLIBC filtered): ghc-compiler ghc-devel(aeson-2.2.3.0-LVN644RDSGV1pDguDpiuz3) ghc-devel(base-4.19.2.0-6e03) ghc-devel(containers-0.6.8-b2d8) ghc-devel(deepseq-1.5.1.0-0513) ghc-enummapset(x86-64) ghc-enummapset-prof (rpmlib, GLIBC filtered): ghc-enummapset-devel(x86-64) ghc-prof(aeson-2.2.3.0-LVN644RDSGV1pDguDpiuz3) ghc-prof(base-4.19.2.0-6e03) ghc-prof(containers-0.6.8-b2d8) ghc-prof(deepseq-1.5.1.0-0513) Provides -------- ghc-enummapset: ghc-enummapset ghc-enummapset(x86-64) libHSenummapset-0.7.3.0-2vbvztsjsohGIHwqz5RWUg-ghc9.8.4.so()(64bit) ghc-enummapset-devel: ghc-devel(enummapset-0.7.3.0-2vbvztsjsohGIHwqz5RWUg) ghc-enummapset-devel ghc-enummapset-devel(x86-64) ghc-enummapset-static ghc-enummapset-static(x86-64) ghc-enummapset-prof: ghc-enummapset-prof ghc-enummapset-prof(x86-64) ghc-prof(enummapset-0.7.3.0-2vbvztsjsohGIHwqz5RWUg) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2080130 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Shell-api, Haskell, Generic Disabled plugins: Python, SugarActivity, PHP, Java, Ocaml, R, Perl, fonts Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: a) Documentation introduces a number of javascript files which will likely be replicated on each install. It seems docbook was used before: https://downloads.haskell.org/~ghc/6.4.1/docs/html/building/building-docs.html Is there still sufficient tooling to enable generation of docbook from the currently used markup format? This would be much better to package. b) Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=133248561 c) Consider using %autorelease and %autochangelog macros d) Seems to comply with guidelines at: https://docs.fedoraproject.org/en-US/packaging-guidelines/Haskell Approved. e) Review of: https://bugzilla.redhat.com/show_bug.cgi?id=2368535 would be appreciated if time and expertise allow.
The Pagure repository was created at https://src.fedoraproject.org/rpms/ghc-enummapset
Thank you for the review, Benson - Akira offered to look at your font package review
(In reply to Benson Muite from comment #8) > Comments: > a) Documentation introduces a number of javascript files which will likely > be replicated on each install. Yea, the duplication is a bit inefficient alas: possibly we could use symlinks, but again symlinks can fail under an http server etc. Unfortunately I don't think upstream has any plans to address this, but if you have an idea how to improve the Fedora situation in a simple way we could try to experiment perhaps. My main concern is just it is a hard to test broadly and it might be easy to break many packages if messed up. Then again most people just read the library docs (haddocks) online... > It seems docbook was used before: As I recall docbook was only used for GHC compiler documentation, now mostly replaced by sphinx I believe. > c) Consider using %autorelease and %autochangelog macros Yep thanks I like to do the switch when importing - though maybe I should just bite the bullet and do it for reviews too > e) Review of: > https://bugzilla.redhat.com/show_bug.cgi?id=2368535 (see my preceding comment, thanks :-)
FEDORA-2025-16a6e8e434 (ghc-enummapset-0.7.3.0-2.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2025-16a6e8e434
FEDORA-2025-16a6e8e434 has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-16a6e8e434 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-16a6e8e434 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-16a6e8e434 (ghc-enummapset-0.7.3.0-2.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.