RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 2081103 - hexedit crashes on empty file
Summary: hexedit crashes on empty file
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 9
Classification: Red Hat
Component: hexedit
Version: CentOS Stream
Hardware: x86_64
OS: Linux
unspecified
low
Target Milestone: rc
: ---
Assignee: Richard W.M. Jones
QA Contact: YongkuiGuo
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-05-02 18:22 UTC by Wouter Liefting
Modified: 2022-11-15 11:16 UTC (History)
6 users (show)

Fixed In Version: hexedit-1.6-1.el9
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-11-15 10:19:03 UTC
Type: Bug
Target Upstream Version:
Embargoed:
pm-rhel: mirror+

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker RHELPLAN-120802 0 None None None 2022-05-02 18:29:16 UTC
Red Hat Product Errata RHBA-2022:8087 0 None None None 2022-11-15 10:19:05 UTC

Description Wouter Liefting 2022-05-02 18:22:45 UTC 
Description of problem:

When hexedit is asked to edit an empty file (because I need to add some UTF-8 encoded data) it crashes.

Version-Release number of selected component (if applicable):
1.5-3.el9

How reproducible:


Steps to Reproduce:
1. touch emptyfile
2. hexedit emptyfile

Actual results:
Crashes with a Floating Point Exception (core dumped)

Expected results:
Would start editing the file

Additional info:
This behaviour is new. Editing a file under CentOS 8 and earlier was not a problem.
Comment 1 Richard W.M. Jones 2022-05-02 21:18:24 UTC 
It does this on Fedora too.  Stack trace is:

#0  0x0000562c46bf2fc9 in display () at /usr/src/debug/hexedit-1.5-2.fc35.x86_64/display.c:208
Downloading 0.00 MB source file /usr/src/debug/hexedit-1.5-2.fc35.x86_64/display.c
208	  printw("--%i%%", 100 * (base + cursor + getfilesize()/200) / getfilesize() );

Thread 1 (Thread 0x7f38c0327740 (LWP 553566)):
#0  0x0000562c46bf2fc9 in display () at /usr/src/debug/hexedit-1.5-2.fc35.x86_64/display.c:208
#1  0x0000562c46bf19b5 in main (argc=<optimized out>, argv=<optimized out>) at /usr/src/debug/hexedit-1.5-2.fc35.x86_64/hexedit.c:104

There's quite an obvious divide by zero.
Comment 2 Richard W.M. Jones 2022-05-02 21:21:24 UTC 
Likely fix is:

https://github.com/pixel/hexedit/commit/41981645134d201151f1cea9fd964d892166e866

There are several other fixes too, so it's likely we want to grab those.
Comment 3 Richard W.M. Jones 2022-05-02 21:34:26 UTC 
I updated to 1.6 in Fedora Rawhide:
https://koji.fedoraproject.org/koji/taskinfo?taskID=86552348
Comment 4 Richard W.M. Jones 2022-05-02 21:39:43 UTC 
Technically part of guestfish in RHEL, so adding Yongkui.
Comment 5 YongkuiGuo 2022-05-05 02:08:50 UTC 
Can reproduce this issue on RHEL9.1.
Comment 6 Richard W.M. Jones 2022-05-05 08:58:59 UTC 
This is technically a rebase but the upstream changes are very minor,
basically just bug fixes including this one.
Comment 7 YongkuiGuo 2022-05-09 08:49:25 UTC 
Tested with hexedit-1.6-1.el9.x86_64.rpm:


Steps:

1. On rhel9.1 host
# touch emptyfile

2. 
# hexedit emptyfile
00000000
0000001C
00000038
00000054
00000070
0000008C
000000A8
...
---  emptyfile       --0x0--0%---

Ctrl+x can be able to save and exit.
Comment 10 YongkuiGuo 2022-07-11 07:47:43 UTC 
Verified this bug according to the steps in comment 7.
Comment 12 errata-xmlrpc 2022-11-15 10:19:03 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (hexedit bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:8087
Note You need to log in before you can comment on or make changes to this bug.