Bug 2081284 - Review Request: subfinder - A subdomain discovery tool that discovers valid subdomains for websites
Summary: Review Request: subfinder - A subdomain discovery tool that discovers valid s...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Alessandro Locati
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2081118 2081128 2081179
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-05-03 09:57 UTC by Mikel Olasagasti Uranga
Modified: 2022-05-12 11:50 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-05-12 11:50:35 UTC
Type: ---
Embargoed:
me: fedora-review+


Attachments (Terms of Use)

Description Mikel Olasagasti Uranga 2022-05-03 09:57:52 UTC
Spec URL: https://mikel.olasagasti.info/tmp/fedora/subfinder.spec
SRPM URL: https://mikel.olasagasti.info/tmp/fedora/subfinder-2.5.1-1.fc36.src.rpm
Description: A subdomain discovery tool that discovers valid subdomains for websites
Fedora Account System Username: mikelo2

Comment 1 Mikel Olasagasti Uranga 2022-05-03 13:18:11 UTC
This one also depends on https://src.fedoraproject.org/rpms/golang-github-hako-durafmt/pull-request/1

Comment 2 Fabio Alessandro Locati 2022-05-04 13:30:11 UTC
Hi mikelo!

Thanks a lot for the SPEC.

It seems like something is wrong with the patch:

Patch #1 (542.patch):
+ cd /builddir/build/BUILD/subfinder-2.5.1/_build/src/github.com/projectdiscovery/subfinder
+ echo 'Patch #1 (542.patch):'
+ /usr/bin/patch --no-backup-if-mismatch -f -p1 --fuzz=0
patching file README.md
Hunk #1 FAILED at 242.
1 out of 1 hunk FAILED -- saving rejects to file README.md.rej

Comment 3 Mikel Olasagasti Uranga 2022-05-04 14:25:21 UTC
Spec URL: https://mikel.olasagasti.info/tmp/fedora/subfinder.spec
SRPM URL: https://mikel.olasagasti.info/tmp/fedora/subfinder-2.5.1-1.fc36.src.rpm

Forgot to update the srpm. Upstream added some change over the Pull Request, so I'm picking the commit rather than hole Pull Request in this new spec.

Comment 4 Fabio Alessandro Locati 2022-05-11 15:47:32 UTC
go2rpm package, fedora-review is correct:

- The specfile is sane.
- License is correct
- Builds successfully in mock
- No rpmlint errors
- %check section passes
- The latest version is packaged
- The package complies with the Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- Add package to release-monitoring.org
- Add package to Koschei.
- Give go-sig privileges on package
- Close the review bug by referencing it in the rpm changelog and/or the Bodhi ticket. (rhbz#BUG_ID)

Thanks!

Comment 5 Fedora Update System 2022-05-12 11:48:49 UTC
FEDORA-2022-475ab0df89 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-475ab0df89

Comment 6 Fedora Update System 2022-05-12 11:50:35 UTC
FEDORA-2022-475ab0df89 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.