Bug 2081291 - album picker duplicates fields, preventing photo organization
Summary: album picker duplicates fields, preventing photo organization
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: gnome-photos
Version: 36
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: GNOME SIG Unassigned
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: AcceptedBlocker
Depends On:
Blocks: F36FinalBlocker
TreeView+ depends on / blocked
 
Reported: 2022-05-03 10:15 UTC by Kamil Páral
Modified: 2022-05-05 18:37 UTC (History)
7 users (show)

Fixed In Version: gnome-photos-42.0-2.fc36
Clone Of:
Environment:
Last Closed: 2022-05-05 18:37:31 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
bug demonstration video (1.18 MB, video/webm)
2022-05-03 10:15 UTC, Kamil Páral
no flags Details
Video confirming the deduplication of items (668.56 KB, video/webm)
2022-05-03 12:32 UTC, Lukas Ruzicka
no flags Details

Description Kamil Páral 2022-05-03 10:15:57 UTC
Created attachment 1876729 [details]
bug demonstration video

Description of problem:
When you want to change which albums your photo is in, invoke the Organize dialog and start selecting and unselecting individual albums, the whole list starts to duplicate over and over again. So instead of e.g. 5 items, you end up with 8, 15, 27 or some other random number. Please watch the video.

It seems that the core issue is that instead of updating the existing checkboxes, either part or the whole list is *appended* to the current values. So instead of redrawing the visible widgets, it adds more and more and more.

Version-Release number of selected component (if applicable):
gnome-photos-42.0-1.fc36.x86_64
Fedora-Workstation-Live-x86_64-36-1.3.iso

How reproducible:
always

Steps to Reproduce:
1. populate ~/Pictures with some pictures
2. create some albums in gnome-photos
3. select a picture, click 'Add to Album'
4. start selecting and unselecting checkboxes, they start to replicate

Comment 1 Kamil Páral 2022-05-03 10:20:40 UTC
Proposing as a Final blocker:
https://fedoraproject.org/wiki/Fedora_36_Final_Release_Criteria#Default_application_functionality

Album organization is the very purpose of gnome-photos.

Comment 2 Lukas Ruzicka 2022-05-03 12:27:29 UTC
On my VM, the described situation does not happen "all the time", but I have seen that, too. I just realized it happens, when I click on an item that has already been marked or when I click twice on an item. The first click is OK, the second click duplicates the entry. However, if you click "OK" and then try adding another photo, the Album list only contains unique items again.

There is another problem I have found in Photos, but I am going to open another bug for it.

Comment 3 Lukas Ruzicka 2022-05-03 12:32:50 UTC
Created attachment 1876735 [details]
Video confirming the deduplication of items

You can see on the video, that the items are deduplicated when the OK button is hit and the pictures are added to the album.

Comment 4 Lukas Ruzicka 2022-05-03 12:40:09 UTC
The other bug is here #2081322

Comment 5 Matthew Miller 2022-05-03 14:48:38 UTC
Is this a regression from F35?

Comment 6 Kamil Páral 2022-05-03 15:33:19 UTC
(In reply to Matthew Miller from comment #5)
> Is this a regression from F35?

Yes, in F35 it works as expected. You can actually know where your photos are going to end up.

Comment 7 Adam Williamson 2022-05-03 15:59:40 UTC
The bug also triggers each time you create a new album - two entries for it show up in the list. For me, anyway.

Comment 8 Kamil Páral 2022-05-04 04:24:32 UTC
(In reply to Adam Williamson from comment #7)
> The bug also triggers each time you create a new album - two entries for it
> show up in the list. For me, anyway.

Yes, if you confirm the name with enter. One of the fields is checked, the other unchecked. If you don't confirm with enter but click OK, it still happens, but you probably won't notice, because the dialog will close at the same time.

Comment 9 Kamil Páral 2022-05-04 14:41:35 UTC
There seems to be a fix in bug 2079344 comment 13. More testing is welcome.

Comment 10 Adam Williamson 2022-05-04 17:05:41 UTC
+5 (+7/-2) in https://pagure.io/fedora-qa/blocker-review/issue/802 , marking accepted.

Comment 11 Fedora Update System 2022-05-04 17:10:04 UTC
FEDORA-2022-93063b598b has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-93063b598b

Comment 12 Adam Williamson 2022-05-04 18:19:58 UTC
Confirmed the update does fix both bugs for me.

Comment 13 Geraldo Simião 2022-05-04 22:20:12 UTC
Me too, confirmed that update gnome-photos-42.0-2.fc36 fixes this bug here and BZ#2079344
Tested on a Fedora-Workstation-Live-x86_64-36-1.4.iso

Comment 14 Geraldo Simião 2022-05-05 03:15:11 UTC
Just tested Fedora-Workstation-Live-x86_64-36-1.5.iso live-sessions and installed at VMs. And in all cases this bug was FIXED.

Comment 15 Fedora Update System 2022-05-05 05:34:17 UTC
FEDORA-2022-93063b598b has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2022-93063b598b`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-93063b598b

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 16 Kamil Páral 2022-05-05 07:19:41 UTC
(In reply to Fedora Update System from comment #11)
> FEDORA-2022-93063b598b has been submitted as an update to Fedora 36.
> https://bodhi.fedoraproject.org/updates/FEDORA-2022-93063b598b

Works fine.

Comment 17 Lukas Ruzicka 2022-05-05 08:54:25 UTC
I also confirm that the application works ok now.

Comment 18 Fedora Update System 2022-05-05 18:37:31 UTC
FEDORA-2022-93063b598b has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.