Spec URL: https://cstratak.fedorapeople.org/python-ini2toml.spec SRPM URL: https://cstratak.fedorapeople.org/python-ini2toml-0.10-1.fc35.src.rpm Description: The original purpose of this project is to help migrating setup.cfg files to PEP 621, but by extension it can also be used to convert any compatible .ini/.cfg file to TOML. Please notice, the provided .ini/.cfg files should follow the same syntax supported by Python’s ConfigParser library (here referred to as INI syntax) and more specifically abide by ConfigUpdater restrictions (e.g., no interpolation or repeated fields) Fedora Account System Username: cstratak
This is a new dependency for python-setuptools
I realize that the package may be better served as an application, hence providing new links: Spec URL: https://cstratak.fedorapeople.org/ini2toml.spec SRPM URL: https://cstratak.fedorapeople.org/ini2toml-0.10-1.fc35.src.rpm Leaving the original ones intact for reference.
%pyproject_extras_subpkg -n ini2toml full lite %pyproject_extras_subpkg -n python3-ini2toml full lite You should probably only have this once.
(In reply to Miro Hrončok from comment #3) > %pyproject_extras_subpkg -n ini2toml full lite > %pyproject_extras_subpkg -n python3-ini2toml full lite > > You should probably only have this once. Fixed
The package looks good, I'd just improve testing. Tests can be run by: %pytest -vv --ignore tests/test_examples.py --deselect tests/test_cli.py::test_auto_formatting … === 55 passed, 1 deselected in 0.71s === Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Mozilla Public License 2.0", "MIT License BSD 3-Clause License Mozilla Public License 2.0", "*No copyright* [generated file]", "*No copyright* MIT License", "BSD 3-Clause License", "MIT License". 80 files have unknown license. Detailed output of licensecheck in /home/lbalhar/temp/reviews/2081830-ini2toml/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: ini2toml-0.10-1.fc37.noarch.rpm ini2toml+full-0.10-1.fc37.noarch.rpm ini2toml+lite-0.10-1.fc37.noarch.rpm ini2toml-0.10-1.fc37.src.rpm Source checksums ---------------- https://files.pythonhosted.org/packages/source/i/ini2toml/ini2toml-0.10.tar.gz : CHECKSUM(SHA256) this package : b34983939b396b5ee01e5591c1b7c1ee62d263178ae95e04a99ab7c3c82918f6 CHECKSUM(SHA256) upstream package : b34983939b396b5ee01e5591c1b7c1ee62d263178ae95e04a99ab7c3c82918f6 Requires -------- ini2toml (rpmlib, GLIBC filtered): /usr/bin/python3 python(abi) python3.10dist(packaging) ini2toml+full (rpmlib, GLIBC filtered): (python3.10dist(configupdater) < 4~~ with python3.10dist(configupdater) >= 3.0.1) (python3.10dist(tomlkit) < 2~~ with python3.10dist(tomlkit) >= 0.10) ini2toml python(abi) ini2toml+lite (rpmlib, GLIBC filtered): (python3.10dist(tomli-w) < 2~~ with python3.10dist(tomli-w) >= 0.4) ini2toml python(abi) Provides -------- ini2toml: ini2toml python-ini2toml python3-ini2toml python3.10-ini2toml python3.10dist(ini2toml) python3dist(ini2toml) ini2toml+full: ini2toml+full python3.10dist(ini2toml[full]) python3dist(ini2toml[full]) ini2toml+lite: ini2toml+lite python3.10dist(ini2toml[lite]) python3dist(ini2toml[lite]) Generated by fedora-review 0.8.0 (e988316) last change: 2022-04-07 Command line :/usr/bin/fedora-review -b 2081830 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, Python Disabled plugins: PHP, Ocaml, fonts, C/C++, SugarActivity, Java, Perl, Haskell, R Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
(In reply to Lumír Balhar from comment #5) > The package looks good, I'd just improve testing. Tests can be run by: > > %pytest -vv --ignore tests/test_examples.py --deselect > tests/test_cli.py::test_auto_formatting > … > === 55 passed, 1 deselected in 0.71s === > > Fixed
The only problem discovered in the previous round is now fixed so: The package is APPROVED!
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/ini2toml