RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 2081981 - input element with non-virtio bus should fail to accept the model attribute
Summary: input element with non-virtio bus should fail to accept the model attribute
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 9
Classification: Red Hat
Component: libvirt
Version: 9.1
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: Michal Privoznik
QA Contact: Lili Zhu
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-05-05 07:08 UTC by Lili Zhu
Modified: 2022-11-15 10:39 UTC (History)
5 users (show)

Fixed In Version: libvirt-8.4.0-1.el9
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-11-15 10:04:06 UTC
Type: Bug
Target Upstream Version: 8.4.0
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker RHELPLAN-121112 0 None Waiting on Customer Set SSH connection timeout 2022-06-09 03:19:57 UTC
Red Hat Product Errata RHSA-2022:8003 0 None None None 2022-11-15 10:04:26 UTC

Description Lili Zhu 2022-05-05 07:08:05 UTC 
Description of problem:
input element with non-virtio bus should fail to accept the model attribute 

Version-Release number of selected component (if applicable):
libvirt-8.2.0-1.el9.x86_64

How reproducible:
100%

Steps to Reproduce:
1. prepare a guest with the following xml
   <input type='tablet' bus='usb' model='virtio-transitional'>
      <address type='usb' bus='0' port='1'/>
    </input>
    <input type='mouse' bus='ps2' model='virtio-transitional'/>
    <input type='keyboard' bus='usb' model='virtio-transitional'>
      <address type='usb' bus='0' port='2'/>
    </input>

2. define the guest
# virsh define avocado-vt-vm1.xml 
Domain 'avocado-vt-vm1' defined from avocado-vt-vm1.xml

3.start the guest
# virsh start avocado-vt-vm1 
Domain 'avocado-vt-vm1' started

4. check the qemu cmd line
# ps aux |grep qemu |grep input
...
-device {"driver":"usb-tablet","id":"input0","bus":"usb.0","port":"1"} -device {"driver":"usb-kbd","id":"input2","bus":"usb.0","port":"2"} 
...

Expected results:
Should report error like:
error: unsupported configuration: input model 'virtio-transitional'/'virtio-non-transitional'/'virtio' not supported for bus 'ps2'/'usb'

Additional info:
Comment 1 Michal Privoznik 2022-05-26 13:23:36 UTC 
Patches proposed on the list:

https://listman.redhat.com/archives/libvir-list/2022-May/231852.html
Comment 2 Michal Privoznik 2022-05-30 14:32:43 UTC 
Merged upstream as:

b4161c2d42 virDomainInputDefValidate: Validate model
bded22e3a7 virDomainInputDefValidate: Reformat

v8.4.0-rc2-2-gb4161c2d42
Comment 3 Lili Zhu 2022-06-07 03:09:39 UTC 
Preverify this bug with:
libvirt-8.5.0-1.fc35.x86_64

1. Edit the guest xml with the following three xml snippet respectively
 <input type='tablet' bus='usb' model='virtio-transitional'>
      <address type='usb' bus='0' port='1'/>
    </input>

    <input type='mouse' bus='ps2' model='virtio-transitional'/>

    <input type='keyboard' bus='usb' model='virtio-transitional'>
      <address type='usb' bus='0' port='2'/>
    </input>


2. All Will report the following error
# virsh edit rhel 
error: unsupported configuration: only bus 'virtio' is supported for input model 'virtio-transitional'
Failed. Try again? [y,n,i,f,?]: 

Mark the bug as Tested.
Comment 6 Lili Zhu 2022-06-21 08:22:39 UTC 
Verify this bug with:
libvirt-8.4.0-2.el9.x86_64


1. Edit the guest xml with the following three xml snippet respectively
 <input type='tablet' bus='usb' model='virtio-transitional'>
      <address type='usb' bus='0' port='1'/>
    </input>

    <input type='mouse' bus='ps2' model='virtio-transitional'/>

    <input type='mouse' bus='usb' model='virtio-transitional'>
      <address type='usb' bus='0' port='2'/>
    </input>

    <input type='keyboard' bus='usb' model='virtio-transitional'>
      <address type='usb' bus='0' port='2'/>
    </input>

    <input type='keyboard' bus='usb' model='virtio-transitional'/>



2. All Will report the following error
# virsh edit rhel 
error: unsupported configuration: only bus 'virtio' is supported for input model 'virtio-transitional'
Failed. Try again? [y,n,i,f,?]: 

Mark the bug as verified.
Comment 8 errata-xmlrpc 2022-11-15 10:04:06 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Low: libvirt security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:8003
Note You need to log in before you can comment on or make changes to this bug.