Bug 2082146 - Bad aarch64 branch-protection test for class destructor
Summary: Bad aarch64 branch-protection test for class destructor
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: annobin
Version: 37
Hardware: aarch64
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Nick Clifton
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-05-05 13:21 UTC by Mark Wielaard
Modified: 2023-12-05 21:06 UTC (History)
5 users (show)

Fixed In Version: annobin-10.69-1.fc37
Clone Of:
Environment:
Last Closed: 2023-12-05 21:06:39 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Mark Wielaard 2022-05-05 13:21:00 UTC
For elfutils-0.187-2.fc36
https://bodhi.fedoraproject.org/updates/FEDORA-2022-287a6c3913

Annobin reports:
FAIL: branch-protection test because not enabled (function: _ZN14tmp_inc_metricD2Ev.lto_priv.0) 

https://osci-jenkins-1.ci.fedoraproject.org/job/fedora-ci/job/rpminspect-pipeline/job/master/98018/testReport/(root)/tests/_annocheck/

Which is a class destructor: tmp_inc_metric::~tmp_inc_metric() [clone .lto_priv.0]

But as can be seen in the build.log it is build with -mbranch-protection=standard

g++ -D_GNU_SOURCE -DHAVE_CONFIG_H -DLOCALEDIR='"/usr/share/locale"' -I. -I..  -I. -I. -I../lib -I.. -I. -I./../libelf -I./../libebl -I./../libdw -I./../libdwelf -I/usr/include/p11-kit-1       -std=c++11 -Wall -Wshadow -Wtrampolines -Wlogical-op -Wduplicated-cond -Wnull-dereference -Wimplicit-fallthrough=5 -Werror -Wunused -Wextra -Wstack-usage=262144   -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -mbranch-protection=standard -fasynchronous-unwind-tables -fstack-clash-protection -c -o debuginfod.o debuginfod.cxx
g++ -std=c++11 -Wall -Wshadow -Wtrampolines -Wlogical-op -Wduplicated-cond -Wnull-dereference -Wimplicit-fallthrough=5 -Werror -Wunused -Wextra -Wstack-usage=262144   -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -mbranch-protection=standard -fasynchronous-unwind-tables -fstack-clash-protection -Wl,-rpath-link,../libelf:../libdw:. -Wl,-z,relro -Wl,--as-needed  -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -Wl,--build-id=sha1 -Wl,-dT,/builddir/build/BUILD/elfutils-0.187/.package_note-elfutils-0.187-2.fc36.aarch64.ld -o debuginfod debuginfod.o ../libdw/libdw.so ../libelf/libelf.so ../lib/libeu.a ./libdebuginfod.so   -lmicrohttpd  -lsqlite3  -larchive  -lpthread -ldl 

https://kojipkgs.fedoraproject.org//packages/elfutils/0.187/2.fc36/data/logs/aarch64/build.log

Comment 1 Nick Clifton 2022-05-06 13:52:07 UTC
Ho hum - another issue with the detection of the -mbranch-protection option when LTO is enabled.
I am testing a local fix which I hope, this time, will fix all of the problems....

Comment 2 Nick Clifton 2022-05-06 14:49:57 UTC
Right - the latest annobin - annobin-10.69-1.fc37 - should fix the problem.

Comment 3 Ben Cotton 2022-08-09 13:42:06 UTC
This bug appears to have been reported against 'rawhide' during the Fedora Linux 37 development cycle.
Changing version to 37.

Comment 4 Aoife Moloney 2023-11-23 00:11:35 UTC
This message is a reminder that Fedora Linux 37 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora Linux 37 on 2023-12-05.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
'version' of '37'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, change the 'version' 
to a later Fedora Linux version. Note that the version field may be hidden.
Click the "Show advanced fields" button if you do not see it.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora Linux 37 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora Linux, you are encouraged to change the 'version' to a later version
prior to this bug being closed.

Comment 5 Aoife Moloney 2023-12-05 21:06:39 UTC
Fedora Linux 37 entered end-of-life (EOL) status on None.

Fedora Linux 37 is no longer maintained, which means that it
will not receive any further security or bug fix updates. As a result we
are closing this bug.

If you can reproduce this bug against a currently maintained version of Fedora Linux
please feel free to reopen this bug against that version. Note that the version
field may be hidden. Click the "Show advanced fields" button if you do not see
the version field.

If you are unable to reopen this bug, please file a new report against an
active release.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.