Spec URL: https://raw.githubusercontent.com/Laiot/rust-bevy-rpm/master/bevy_internal/bevy_app/bevy_derive/bevy_macro_utils/rust-bevy_macro_utils.spec SRPM URL: https://github.com/Laiot/rust-bevy-rpm/raw/master/bevy_internal/bevy_app/bevy_derive/bevy_macro_utils/rust-bevy_macro_utils-0.7.0-1.fc36.src.rpm Description: Collection of utils for Bevy Engine Fedora Account System Username: laiot This crate depends on cargo-manifest that has just been packaged for Fedora. Mock on fedora-37-x86_64 works already but it might take a day or two before the build works for Fedora 36, 35 and 34 too.
The published crates for bevy_macro_utils do not contain any license texts. However, both the MIT and Apache-2.0 license terms require that redistributed sources contain a copy of the license text. For example, choosealicense.com lists this under "Conditions" for both licenses: https://choosealicense.com/licenses/apache-2.0/ https://choosealicense.com/licenses/mit/ The sources for this crate live here, and don't link any license files: https://github.com/bevyengine/bevy/tree/main/crates/bevy_macro_utils Looks like none of the crates that are published for the bevy project do, and the license files are only included in the docs folder: https://github.com/bevyengine/bevy/tree/main/docs It might be good to file an issue with the GitHub project to remind them of the fact that their own published crates are not in line with the licenses they themselves chose. :) In the meantime, if you want to continue packaging this crate, you can include the upstream license texts as separate sources: Source1: https://github.com/bevyengine/bevy/raw/v0.7.0/docs/LICENSE-APACHE Source2: https://github.com/bevyengine/bevy/raw/v0.7.0/docs/LICENSE-MIT Then copy them to the build directory in %prep: cp %{SOURCE1} %{SOURCE2} . And list them in %files of the "-devel" subpackage with: %license %{crate_instdir}/LICENSE-APACHE %license %{crate_instdir}/LICENSE-MIT
Sorry for the delay, I just pushed the changes. I also opened an issue upstream about this.
> %license %{crate_instdir}/LICENSE-APACHE > %license %{crate_instdir}/LICENSE-MIT You added these two files to the wrong subpackage. They're in the +default-devel subpackage, but should be with the other, actual files in -devel.
Sorry about that, I hope it's correct now.
Sorry for the delay. This review request slipped through multiple cracks somehow ... === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide ? test suite is run and all unit tests pass (there are no tests) ! latest version of the crate is packaged (0.7.0 vs. 0.8.1) - license matches upstream specification and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - add @rust-sig with "commit" access as package co-maintainer - set bugzilla assignee overrides to @rust-sig (optional) - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - track package in koschei for all built branches === Please regenerate the packaging with rust2rpm v22, and possibly update to the latest version before importing the package (if possible).
Please continue with requesting the dist-git repository if you are still interested in this package. I will refresh the fedora-review+ flag if you get an error about it being expired.