Bug 2082571 - PyQt4 fails to build with Python 3.11: error: invalid use of incomplete type 'PyFrameObject' {aka 'struct _frame'}
Summary: PyQt4 fails to build with Python 3.11: error: invalid use of incomplete type ...
Keywords:
Status: CLOSED WORKSFORME
Alias: None
Product: Fedora
Classification: Fedora
Component: PyQt4
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Antonio T. sagitter
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 2098668 (view as bug list)
Depends On:
Blocks: PYTHON3.11 F37FTBFS F37FailsToInstall 2098713 2099088 2099160
TreeView+ depends on / blocked
 
Reported: 2022-05-06 12:51 UTC by Tomáš Hrnčiar
Modified: 2022-06-21 15:37 UTC (History)
5 users (show)

Fixed In Version: PyQt4-4.12.3-22.fc37
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-06-21 14:30:16 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Tomáš Hrnčiar 2022-05-06 12:51:36 UTC
PyQt4 fails to build with Python 3.11.0a7.

../../../qpy/QtCore/qpycore_classinfo.cpp: In function 'PyObject* qpycore_ClassInfo(const char*, const char*)':
../../../qpy/QtCore/qpycore_classinfo.cpp:39:22: error: invalid use of incomplete type 'PyFrameObject' {aka 'struct _frame'}
   39 |         frame = frame->f_back;
      |                      ^~
In file included from /usr/include/python3.11/Python.h:42,
                 from ../../../qpy/QtCore/qpycore_classinfo.cpp:21:
/usr/include/python3.11/pytypedefs.h:22:16: note: forward declaration of 'PyFrameObject' {aka 'struct _frame'}
   22 | typedef struct _frame PyFrameObject;
      |                ^~~~~~

The PyFrameObject structure members have been removed from the public C API.

While the documentation notes that the PyFrameObject fields are subject to change at any time, they have been stable for a long time and were used in several popular extensions.

In Python 3.11, the frame struct was reorganized to allow performance optimizations. Some fields were removed entirely, as they were details of the old implementation.

PyFrameObject fields:
    f_back: use PyFrame_GetBack().
    f_blockstack: removed.
    f_builtins: use PyFrame_GetBuiltins().
    f_code: use PyFrame_GetCode().
    f_gen: use PyFrame_GetGenerator().
    f_globals: use PyFrame_GetGlobals().
    f_iblock: removed.
    f_lasti: use PyFrame_GetLasti(). Code using f_lasti with PyCode_Addr2Line() should use PyFrame_GetLineNumber() instead; it may be faster.
    f_lineno: use PyFrame_GetLineNumber()
    f_locals: use PyFrame_GetLocals().
    f_stackdepth: removed.
    f_state: no public API (renamed to f_frame.f_state).
    f_trace: no public API.
    f_trace_lines: use PyObject_GetAttrString((PyObject*)frame, "f_trace_lines").
    f_trace_opcodes: use PyObject_GetAttrString((PyObject*)frame, "f_trace_opcodes").
    f_localsplus: no public API (renamed to f_frame.localsplus).
    f_valuestack: removed.

The Python frame object is now created lazily. A side effect is that the f_back member must not be accessed directly, since its value is now also computed lazily. The PyFrame_GetBack() function must be called instead.

https://docs.python.org/3.11/whatsnew/3.11.html

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.11/fedora-rawhide-x86_64/04369448-PyQt4/

For all our attempts to build PyQt4 with Python 3.11, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.11/package/PyQt4/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.11:
https://copr.fedorainfracloud.org/coprs/g/python/python3.11/

Let us know here if you have any questions.

Python 3.11 is planned to be included in Fedora 37. To make that update smoother, we're building Fedora packages with all pre-releases of Python 3.11.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Miro Hrončok 2022-06-20 10:16:15 UTC
*** Bug 2098668 has been marked as a duplicate of this bug. ***

Comment 2 Miro Hrončok 2022-06-21 14:30:16 UTC
Hello,

Please note that this comment was generated automatically. If you feel that this output has mistakes, please contact me via email (mhroncok).

All subpackages of a package against which this bug was filled are now installable or removed from Fedora 37.

Thanks for taking care of it!

Comment 3 Than Ngo 2022-06-21 15:37:28 UTC
it is fixed in PyQt4-4.12.3-22.fc37, https://koji.fedoraproject.org/koji/taskinfo?taskID=88549066


Note You need to log in before you can comment on or make changes to this bug.