Bug 2082588 - [RFE] Add new Azure instance types to the official "tested/supported" list
Summary: [RFE] Add new Azure instance types to the official "tested/supported" list
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Cloud Compute
Version: 4.8
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: 4.12.0
Assignee: Radek Maňák
QA Contact: sunzhaohua
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-05-06 13:24 UTC by Rainer Beyel
Modified: 2023-09-18 04:36 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: No Doc Update
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-01-17 19:48:18 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2022:7399 0 None None None 2023-01-17 19:48:38 UTC

Description Rainer Beyel 2022-05-06 13:24:45 UTC
Description of problem:

Add the following instance types to azure_instance_types list[1]:
- Standard_D8s_v5
- Standard_E8s_v5
- Standard_E16s_v5

Version-Release number of selected component (if applicable):
OCP 4.8

Steps to Reproduce:
1. Migrate worker/infra nodes to above mentioned (missing) v5 instance types
2. "Failed to set autoscaling from zero annotations, instance type unknown"

Actual results:
- "Failed to set autoscaling from zero annotations, instance type unknown"
- New v5 instance types not officially tested/supported

Expected results:
The new instance types are available in the azure_instance_types list[1] and no errors/warnings are observed after migrating:
- Standard_D8s_v5
- Standard_E8s_v5
- Standard_E16s_v5


Additional info:

The related v4 instance types are already available[1] - I suspect adding the mentioned v5 instance types is a minor update:
- Standard_D8s_v4
- Standard_E8s_v4
- Standard_E16s_v4
 
1) azure_instance_types.go
   https://github.com/openshift/cluster-api-provider-azure/blob/release-4.8/pkg/cloud/azure/actuators/machineset/azure_instance_types.go

Comment 2 Rainer Beyel 2022-05-24 11:47:56 UTC
Hi Sudha, I know it's a RFE and therefore has low-prio, but do we have a rough estimate on when this might be added? Is there a rough interval from past experience? Thanks

Comment 4 Rainer Beyel 2022-05-27 14:27:53 UTC
I created the following RFE in Jira:
  [RFE] Add new Azure instance types to the official "tested/supported" list
  https://issues.redhat.com/browse/RFE-2896

Comment 6 Patrick Dillon 2022-07-26 17:37:04 UTC
Moving this to the cloud compute team. I initially mis-triaged this thinking this was asking for a docs update to our supported instance types list. Apologies for the delay.

Comment 7 Joel Speed 2022-07-27 13:23:02 UTC
We need to spend some time to get this data dynamically from Azure rather than storing it within a list, will see if we can prioritise this in the near future

Comment 9 Joel Speed 2022-10-03 15:22:07 UTC
I believe https://bugzilla.redhat.com/show_bug.cgi?id=2108647 should have resolved this issue. QE, could you please verify that the scaling from zero information is set correctly on the above instance types and that the annotation log messages are no longer present

Comment 10 sunzhaohua 2022-10-08 07:08:51 UTC
Blocked by https://issues.redhat.com/browse/OCPBUGS-2121

Comment 11 sunzhaohua 2022-10-09 04:08:33 UTC
Verfied, annotations are set correctly, autoscaler log no error.
4.12.0-0.nightly-2022-10-07-215539

Standard_D8s_v5:
  annotations:
    autoscaling.openshift.io/machineautoscaler: openshift-machine-api/machineautoscaler-c
    machine.openshift.io/GPU: "0"
    machine.openshift.io/cluster-api-autoscaler-node-group-max-size: "3"
    machine.openshift.io/cluster-api-autoscaler-node-group-min-size: "0"
    machine.openshift.io/memoryMb: "32768"
    machine.openshift.io/vCPU: "8"

Standard_E8s_v5:
  annotations:
    autoscaling.openshift.io/machineautoscaler: openshift-machine-api/machineautoscaler-c
    machine.openshift.io/GPU: "0"
    machine.openshift.io/cluster-api-autoscaler-node-group-max-size: "3"
    machine.openshift.io/cluster-api-autoscaler-node-group-min-size: "0"
    machine.openshift.io/memoryMb: "65536"
    machine.openshift.io/vCPU: "8"

Standard_E16s_v5:
  annotations:
    autoscaling.openshift.io/machineautoscaler: openshift-machine-api/machineautoscaler-c
    machine.openshift.io/GPU: "0"
    machine.openshift.io/cluster-api-autoscaler-node-group-max-size: "3"
    machine.openshift.io/cluster-api-autoscaler-node-group-min-size: "0"
    machine.openshift.io/memoryMb: "131072"
    machine.openshift.io/vCPU: "16"

Comment 13 Radek Maňák 2022-11-24 13:00:29 UTC
Does not need docs as it is basically a duplicate of https://bugzilla.redhat.com/show_bug.cgi?id=2108647

Comment 15 errata-xmlrpc 2023-01-17 19:48:18 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.12.0 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:7399

Comment 16 Red Hat Bugzilla 2023-09-18 04:36:42 UTC
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 120 days


Note You need to log in before you can comment on or make changes to this bug.