Created attachment 1877974 [details]
add disk wizard

This is deliberate. The VM creation dialog should *not* offer all the possible options, as this would make it way too complex. For non-default options, create the VM without storage, don't start it, and then tweak storage, devices, boot loader/order, networking, etc; then start it.

I completely agree that providing *all* options would be insane, but selecting the image storage format is a very basic operation that should not be taken away from the user in my opinion. Especially considering that the field can have a default value (let it qcow2 or raw) so that the casual user can simply ignore it, I fail to understand how that option would complicate things for VM creation.

The workaround you provided is real (it is how I am working at the moment), but it adds unneeded steps to the creation of a new virtual machine. So I would ask to reconsider your decision.
Regards.

I would add that, due to apparmor issues described in https://bugzilla.redhat.com/show_bug.cgi?id=2129408, adding a raw disk is unneeded complex. 

At the moment, when operating on an apparmor-enabled distro, one had to:
- create a vm with no storage selected;
- create and add a raw disk via the wizard;
- remove the just-added disk;
- re-add it specifying a full, custom path.

So please consider enabling raw disk image selection on the vm creation wizard.
Regards.

Merged: https://github.com/cockpit-project/cockpit-machines/pull/1031

Verified with Packages:
cockpit-machines-290-1.el9.noarch
cockpit-292-1.el9.x86_64
libvirt-dbus-1.4.1-5.el9.x86_64
libvirt-daemon-9.0.0-10.1.el9_2.x86_64

Steps :
1. click "Create VM" 
Storage: "Create new qcow2 volume" 
Fill in left fields , click "Crate and run"

The vm image file format will be qcow2:
# qemu-img info /var/lib/libvirt/images/fedora37-2023-5-22.qcow2 
image: /var/lib/libvirt/images/fedora37-2023-5-22.qcow2
file format: qcow2
virtual size: 20 GiB (21474836480 bytes)
disk size: 40.4 MiB
cluster_size: 65536
Format specific information:
    compat: 1.1
    compression type: zlib
    lazy refcounts: true
    refcount bits: 16
    corrupt: false
    extended l2: false
Child node '/file':
    filename: /var/lib/libvirt/images/fedora37-2023-5-22.qcow2
    protocol type: file
    file length: 20 GiB (21478375424 bytes)
    disk size: 40.4 MiB
    Format specific information:
        extent size hint: 1048576


2. click "Create VM" again
Storage: "Create new raw volume" 
Fill in left fields , click "Crate and run"

The vm image file format will be raw:
# qemu-img info /var/lib/libvirt/images/test2.img
image: /var/lib/libvirt/images/test2.img
file format: raw
virtual size: 20 GiB (21474836480 bytes)
disk size: 4 KiB
Child node '/file':
    filename: /var/lib/libvirt/images/test2.img
    protocol type: file
    file length: 20 GiB (21474836480 bytes)
    disk size: 4 KiB


So verified.

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (cockpit-machines bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2023:6336