Spec URL: http://freeshell.in/~kushal/kphotobymail.spec SRPM URL: http://freeshell.in/~kushal/kphotobymail-0.3.2-1.src.rpm Description: Kphotobymail is a PyQT based application for uploading photos to flickr account. You can also use it to send emails with photo attachment on the fly. This is my first package, so requesting a review.
<!> First reviews for new packagers must be done by registered sponsors.
I'll review it and get it ready for official review. But someone else will approved it. I can't be assigned to this bug.
Spec URL: http://freeshell.in/~kushal/kphotobymail.spec SRPM URL: http://freeshell.in/~kushal/kphotobymail-0.3.2-2.src.rpm Added deskto-file-install rpmlint still showing W: kphotobymail conffile-without-noreplace-flag /etc/kphotobymail.data E: kphotobymail non-executable-script /usr/lib/python2.4/site-packages/Kphotobymail/__init__.py 0644 where there is no problem in replacing /etc/kphotobymail.data Second one .. no idea, but it is having required permissions.
A few things need to be fixed here: You need to add: BuildRequires: desktop-file-utils Upstream source does not match source in SRPM, you need to reconcile that: ecfa19fa8618da1314b3964f3d4b39c731e3d1ee kphotobymail-0.3.2.tar.gz.UPSTREAM 70cf51f8641f315b0b6f738c0740a351fe5eb912 kphotobymail-0.3.2.tar.gz Don't use the name of the program in the summary. A recommended change: Summary: A PyQT based application for uploading photos to flickr Also, while not mandatory, I highly recommend that you append %{?dist} to the end of the Release string. See http://fedoraproject.org/wiki/Packaging/DistTag Good: - rpmlint checks return: W: kphotobymail conffile-without-noreplace-flag /etc/kphotobymail.data Should be safe to ignore. E: kphotobymail non-executable-script /usr/lib/python2.4/site-packages/Kphotobymail/__init__.py 0644 Should be safe to ignore. W: kphotobymail mixed-use-of-spaces-and-tabs (spaces: line 14, tab: line 4) Just fix line 14 to use tabs instead of spaces. - package meets naming guidelines - license (GPL) OK, text in %doc, matches source - spec file legible, in am. english - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - desktop file ok Bad: - source does NOT match upstream Fix the blockers and I'll revisit this.
Fixed.. :) Spec URL: http://freeshell.in/~kushal/kphotobymail.spec SRPM URL: http://freeshell.in/~kushal/kphotobymail-0.3.2-3.src.rpm
Looks good. Only remaining issue I see is that you're using spaces instead of tabs in your desktop-file-install call (line 34). rpmlint complained about it, so, just fix it before you commit. APPROVED and SPONSORED. Do your paperwork, when I see it come across, I'll sponsor you.
Done. Spec URL: http://freeshell.in/~kushal/kphotobymail.spec SRPM URL: http://freeshell.in/~kushal/kphotobymail-0.3.2-4.src.rpm