Bug 2084587 - hunspell-pt is not installed on installing langpacks-pt_BR but is when installing langpacks-pt
Summary: hunspell-pt is not installed on installing langpacks-pt_BR but is when instal...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: hunspell-pt
Version: 36
Hardware: All
OS: Linux
unspecified
low
Target Milestone: ---
Assignee: Caolan McNamara
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-05-12 13:21 UTC by Mateus Rodrigues Costa
Modified: 2022-05-16 11:52 UTC (History)
3 users (show)

Fixed In Version: hunspell-pt-0.20131030-4.fc37 hunspell-pt-0.20131030-5.fc37 hunspell-pt-0.20131030-5.fc36 hunspell-pt-0.20131030-6.fc37
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-05-15 01:02:41 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 2084575 1 unspecified CLOSED Spell checker dictionaries and hyphenation rules are not propertly installed on pt_BR locales compared to pt locales 2022-07-01 12:56:09 UTC

Description Mateus Rodrigues Costa 2022-05-12 13:21:38 UTC
Description of problem:

hunspell-pt provides dictonaries for both pt_PT and pt_BR, but it doesn't get automatically installed along installing langpacks-pt_BR while it does when installing langpakcs-pt

Version-Release number of selected component (if applicable):

hunspell-pt-0.20131030-3.fc36.noarch

How reproducible:

Reproducible if installing langpacks-pt_BR intead of langpacks-pt on Silverblue/Workstation

Steps to Reproduce:
1. Try to installing langpacks-pt
2. Try to install langpacks-pt_BR
3. Compare different results

Actual results:

hunspell-pt won't installed for langpacks-pt_BR but will for langpacks-pt

Expected results:

hunspell-pt should be installed for langpacks-pt_BR

Additional info:

I filled bug #2084575 for this first, but I looked at the spec and the problem seems to be that the supplements line on the spec file looks like this:

`Supplements: (hunspell and langpacks-pt)`

I guess it should be changed so it can work for either langpacks-pt or langpacks-pt_BR.

Comment 1 Caolan McNamara 2022-05-12 15:04:57 UTC
we have Supplements: (hunspell and langpacks-pt) so indeed, presumably (hunspell and langpacks-pt and langpacks-pt_BR) would fix this

Comment 2 Fedora Update System 2022-05-12 15:17:02 UTC
FEDORA-2022-a3e1a84140 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-a3e1a84140

Comment 3 Fedora Update System 2022-05-12 15:17:40 UTC
FEDORA-2022-a3e1a84140 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 4 Fedora Update System 2022-05-12 15:32:51 UTC
FEDORA-2022-12359bdd18 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-12359bdd18

Comment 5 Parag Nemade 2022-05-12 16:34:16 UTC
I really wanted to have some difference between langpacks-pt and langpacks-pt_BR
I am looking for some good trusted source that says langpacks-pt_BR should not include hunspell-pt

Comment 6 Caolan McNamara 2022-05-12 18:46:40 UTC
It just happens to be that hunspell-pt.spec outputs one rpm with all pt_* in it. We could change hunspell-pt.spec to output two rpms, a specific pt_BR one and then the other pt one for the rest of the variants and then langpacks-pt_BR would only include hunspell-pt-BR.

Comment 7 Mateus Rodrigues Costa 2022-05-12 20:09:14 UTC
(In reply to Caolan McNamara from comment #6)
> It just happens to be that hunspell-pt.spec outputs one rpm with all pt_* in
> it. We could change hunspell-pt.spec to output two rpms, a specific pt_BR
> one and then the other pt one for the rest of the variants and then
> langpacks-pt_BR would only include hunspell-pt-BR.

Just as a tip though, you might want to hold off pushing the separate rpm approach to stable for a bit due to bug 2085107 (either the backport or, of course, Gnome Software 42.2 release).

Due to a bug in how Gnome Software automatically installs langpacks, pt_BR Workstation/Silverblue systems where the user lets gnome-software do that for them might only have langpacks-pt instead of langpacks-pt_BR, so if you split a separate "hunspell-pt_BR" those systems might suddenly be without spelling dictionaries.

Comment 8 Fedora Update System 2022-05-12 20:30:37 UTC
FEDORA-2022-12359bdd18 has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2022-12359bdd18`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-12359bdd18

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Mateus Rodrigues Costa 2022-05-13 12:22:53 UTC
Not fixed yet.

The line `Supplements: (hunspell and langpacks-pt and langpacks-pt_BR)` will apparently make hunspell be grabbed as weak dep only if `hunspell`, `langpacks-pt` and langpacks-pt_BR` are all present at the same time.
It ideally should work if only `hunspell` and `langpacks-pt` or if only `hunspell` and `hunspell-pt_BR` are present (i.e. only one of the langpacks portuguese packages is needed).

I believe it should be something like this instead:

```
Supplements: (hunspell and (langpacks-pt or langpacks-pt_BR))
```

Comment 10 Mateus Rodrigues Costa 2022-05-13 12:29:18 UTC
(In reply to Mateus Rodrigues Costa from comment #9)

> It ideally should work if only `hunspell` and `langpacks-pt` or if only
> `hunspell` and `hunspell-pt_BR` are present (i.e. only one of the langpacks
> portuguese packages is needed).
> 

Sorry, small correction, I actually meant "if only `hunspell` and `langpacks-pt` or if only `hunspell` and `langpacks-pt_BR` are present" in this section.

Comment 11 Fedora Update System 2022-05-13 12:32:39 UTC
FEDORA-2022-8c8ee157e6 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-8c8ee157e6

Comment 12 Fedora Update System 2022-05-13 12:36:04 UTC
FEDORA-2022-8c8ee157e6 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Parag Nemade 2022-05-13 12:47:27 UTC
I request to split this package into hunspell-pt and hunspell-pt_BR for now. When supporting package and glibc locale is available we can think about pt_AO langpack creation.

Comment 14 Caolan McNamara 2022-05-13 13:09:08 UTC
I'll have another go at fixing the current Supplements line and do the split idea later.

Comment 15 Fedora Update System 2022-05-13 13:10:52 UTC
FEDORA-2022-b7e639ac83 has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-b7e639ac83

Comment 16 Mateus Rodrigues Costa 2022-05-13 13:47:52 UTC
(In reply to Parag Nemade from comment #13)
> When supporting package and glibc locale is available we can think about
> pt_AO langpack creation.

AFAIK there's no significant difference between pt_PT and pt_AO in most things, so it should be okay to keep both together with the Angolan variation of stuff being a symlink to the one from Portugal.

You would have to ask to someone who is familiar enough with Angolan Portuguese for more details though.

Comment 17 Fedora Update System 2022-05-14 02:15:13 UTC
FEDORA-2022-b7e639ac83 has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2022-b7e639ac83`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-b7e639ac83

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 18 Fedora Update System 2022-05-15 01:02:41 UTC
FEDORA-2022-b7e639ac83 has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 19 Fedora Update System 2022-05-16 11:14:08 UTC
FEDORA-2022-5e06d684c9 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-5e06d684c9

Comment 20 Fedora Update System 2022-05-16 11:16:13 UTC
FEDORA-2022-5e06d684c9 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 21 Fedora Update System 2022-05-16 11:50:34 UTC
FEDORA-2022-3618f33750 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-3618f33750

Comment 22 Fedora Update System 2022-05-16 11:52:14 UTC
FEDORA-2022-3618f33750 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.