Bug 2086497 - Borg --check fails after upgrade to F36
Summary: Borg --check fails after upgrade to F36
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: borgbackup
Version: 36
Hardware: x86_64
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Felix Schwarz
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-05-16 10:44 UTC by Patrick O'Callaghan
Modified: 2022-05-23 11:45 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2022-05-23 11:45:50 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github borgbackup borg issues 6687 0 None open borg check errors after upgrade to 1.2.0 2022-05-16 20:12:13 UTC

Description Patrick O'Callaghan 2022-05-16 10:44:26 UTC
Description of problem:
Borgbackup reports errors from borg checking phase despite no change in configuration

Version-Release number of selected component (if applicable):
borgbackup-1.2.0-1.fc36.x86_64

How reproducible:
100%

Steps to Reproduce:
1.Run borg either manually or via borgmatic
2.Backup appears to succeed until check phase
3.Borgmatic reports "Error running actions for repository".

Actual results:
Borgbackup check phase reports errors on all existing repositories, *including those created before the latest updates*.


Expected results:
No errors

Additional info:
The actual backup looks good to visual inspection. These errors have been appearing only since upgrading F35->F36 a few days ago. There have been no changes to the Borg config.yaml file since before updating to F36.

Comment 1 Felix Schwarz 2022-05-16 20:12:13 UTC
There were multiple reports over the last week about similar issues upstream. Please read https://github.com/borgbackup/borg/issues/6687#issuecomment-1127090587 for the current state of the investigation.

This is on my radar and I will update Fedora's borgbackup once upstream publishes a bugfix release or provides a "blessed" patchset.

Comment 2 Patrick O'Callaghan 2022-05-16 21:32:38 UTC
(In reply to Felix Schwarz from comment #1)
> There were multiple reports over the last week about similar issues
> upstream. Please read
> https://github.com/borgbackup/borg/issues/6687#issuecomment-1127090587 for
> the current state of the investigation.
> 
> This is on my radar and I will update Fedora's borgbackup once upstream
> publishes a bugfix release or provides a "blessed" patchset.

Thanks. I don't think it's caused by the update to Borg 1.2, which happened about a month ago. In my case the errors started only after upgrading to Fedora 36.

Comment 3 Felix Schwarz 2022-05-17 06:27:38 UTC
Fedora 35 ships borg 1.1.x so upgrading to Fedora 36 means you updated to borg 1.2 :-)

Comment 4 Patrick O'Callaghan 2022-05-17 10:46:31 UTC
(In reply to Felix Schwarz from comment #3)
> Fedora 35 ships borg 1.1.x so upgrading to Fedora 36 means you updated to
> borg 1.2 :-)

Fedroa 35 did ship with 1.1.x originally, but later on the updates repo supplied 1.2 and that's what I used.

Comment 5 Felix Schwarz 2022-05-17 11:30:59 UTC
> Fedroa 35 did ship with 1.1.x originally, but later on the updates repo supplied 1.2

Our dist-git disagrees: https://src.fedoraproject.org/rpms/borgbackup/
Are you sure that you were using 1.2 on F35? In that case you did use some other repo as F35 never shipped borg 1.2

Comment 6 Patrick O'Callaghan 2022-05-17 12:10:55 UTC
(In reply to Felix Schwarz from comment #5)
> > Fedroa 35 did ship with 1.1.x originally, but later on the updates repo supplied 1.2
> 
> Our dist-git disagrees: https://src.fedoraproject.org/rpms/borgbackup/
> Are you sure that you were using 1.2 on F35? In that case you did use some
> other repo as F35 never shipped borg 1.2

I had a distinct memory of reading the 1.2 Changelog a while back, but on checking the logs again, it looks like 1.2 did come with F36 after all, in which case hopefully the error will be fixed by upstream.

Sorry for the confusion.

Comment 7 Patrick O'Callaghan 2022-05-23 11:45:50 UTC
Just to close this off:

I managed to fix it using 'borg check --repair'. My backup drive is a
BTRFS RAID1, so after using Btrfs to check there were no physical
errors, I copied the Borg repository ('cp -R', really fast because of
COW), then ran the repair. It reported a single error from an
unimportant file (which presumably was causing the shower of errors due
to de-duplication), and the repair fixed it.

Subsequent runs of borgmatic report no errors.


Note You need to log in before you can comment on or make changes to this bug.