Spec URL: https://download.copr.fedorainfracloud.org/results/aekoroglu/fedora/fedora-rawhide-x86_64/04418313-telepathy-idle/telepathy-idle.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/aekoroglu/fedora/fedora-rawhide-x86_64/04418313-telepathy-idle/telepathy-idle-0.2.2-1.fc37.src.rpm Description: IRC connection manager for Telepathy
This package is runtime dependency for Polari (#2064643). After the reviewing process I'll open unretire request in pagure.
So as I happen to be telepathy-glib maintainer, I comment for now. * Now for new packages License field must use SPDX identifier: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_valid_license_short_names https://spdx.org/licenses/ * For BuildRequires: using "BuildRequires: pkgconfig(foo)" is preferred than to use "BuildRequires: dbus-glib-devel" or so https://docs.fedoraproject.org/en-US/packaging-guidelines/PkgConfigBuildRequires/ * Unneeded BR - At least "BR: openssl-devel" seems unneeded - Also check if there is any more unneeded BRs left. * Using "python-unversioned-command" as BR is strongly discouraged. Patch out not to use non-version python and use python3. https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_dependencies * scratch build says: checking for Python with Twisted and IRC protocol support... no https://koji.fedoraproject.org/koji/taskinfo?taskID=91402714 Looking at configure.ac, this perhaps means that some twisted tests are disabled. Please consider to enable this. * Directory ownership: https://docs.fedoraproject.org/en-US/packaging-guidelines/UnownedDirectories/ With "mock --init" and doint "mock --install telepathy-idle.x86_64.rpm", /usr/share/dbus-1/services/ is not owned by any packages. ============================================================= [mockbuild@93f3667e0cdb434cb87064920e66e928 ~]$ rpm -qf /usr/share/dbus-1/services/ file /usr/share/dbus-1/services is not owned by any package ============================================================= Make it sure this directory is owned by some package when telepathy-idle is installed.
Some notes: * For BR: pkgconfig(foo), you can check for configure.ac, and check what is used with PKG_CHECK_MODULES macro or so.
Setting NEEDINFO.
I've taken as is from F36 but I updated the spec as you recommended Spec URL: https://download.copr.fedorainfracloud.org/results/aekoroglu/fedora/fedora-rawhide-x86_64/04812915-telepathy-idle/telepathy-idle.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/aekoroglu/fedora/fedora-rawhide-x86_64/04812915-telepathy-idle/telepathy-idle-0.2.2-1.fc38.src.rpm
Assigning.
* License - Many files (such as src/idle-connection-manager.c or so) explictly says the license is under LGPL-2.0 only. Please check this. * Directory ownership issue - /usr/share/dbus-1/ and /usr/share/dbus-1/services/ are unowned by any packages when telepathy-idle binary is installed. Add: "Requires: dbus-common".
I checked the code so license is LGPL-2.1-or-later and as you're saying /usr/share/dbus-1/services belongs to dbus-common which is added as "requires" SPEC Url: https://download.copr.fedorainfracloud.org/results/aekoroglu/fedora/fedora-rawhide-x86_64/04830536-telepathy-idle/telepathy-idle.spec SRPM Url: https://download.copr.fedorainfracloud.org/results/aekoroglu/fedora/fedora-rawhide-x86_64/04830536-telepathy-idle/telepathy-idle-0.2.2-1.fc38.src.rpm
* License - For example, this https://gitlab.freedesktop.org/telepathy/telepathy-idle/-/blob/master/src/idle-connection.c#L9-10 says "GNU Lesser General Public License version 2.1 as published", this is LGPL-2.1 only. For reference, this sentence https://gitlab.freedesktop.org/telepathy/telepathy-idle/-/blob/master/extensions/Connection_Interface_IRC_Command1.xml#L7-8 is LGPL-2.1-or-later .
Project's license (https://gitlab.freedesktop.org/telepathy/telepathy-idle/-/blob/master/COPYING) is LGPL-2.1-or-later, probably they forgot to change that while migrating from SF.net to SVN 15 years ago :) But we can do like "LGPL-2.1-only AND LGPL-2.1-or-later"
We judge the license of the software not only from copyright files but also the actual contents of the source file. Please change the license tag to "LGPL-2.1-only AND LGPL-2.1-or-later".
Sure, license is changed as requested SPEC Url: https://download.copr.fedorainfracloud.org/results/aekoroglu/fedora/fedora-rawhide-x86_64/04832146-telepathy-idle/telepathy-idle.spec SRPM Url: https://download.copr.fedorainfracloud.org/results/aekoroglu/fedora/fedora-rawhide-x86_64/04832146-telepathy-idle/telepathy-idle-0.2.2-1.fc38.src.rpm
* Name legitimate * EVR correct * License correct * Summary clean * Source matches upstream * BR / Requires okay * %prep / %build / %install / %check okay * %files okay * rpmlint on srpm clean * directory ownership okay * scratch build okay https://koji.fedoraproject.org/koji/taskinfo?taskID=91904425 * build logs are sane * %optflags correctly used * can be installed * rpmlint on binary rpm okay Approving. ================================================== This package (telepathy-idle) is APPROVED by mtasaka ==================================================
Thank you Mamoru https://koji.fedoraproject.org/koji/buildinfo?buildID=2062783
Please rebuild this package also on F-37, and submit to bodhi (submitting to bodhi is needed for F-37) - unless this, polari dependency issue on F-37 cannot be resolved.
Yep I did, thanks https://bodhi.fedoraproject.org/updates/FEDORA-2022-d23557aec2