Bug 2087264 - Review Request: bfs - A breadth-first version of the UNIX find command
Summary: Review Request: bfs - A breadth-first version of the UNIX find command
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Benson Muite
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-05-17 17:18 UTC by Gustavo Costa
Modified: 2022-08-12 19:45 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-08-12 19:45:37 UTC
Type: ---
Embargoed:
benson_muite: fedora-review+


Attachments (Terms of Use)

Description Gustavo Costa 2022-05-17 17:18:45 UTC
Spec URL: https://xfgusta.fedorapeople.org/packages/bfs/bfs.spec
SRPM URL: https://xfgusta.fedorapeople.org/packages/bfs/bfs-2.6.1-1.fc36.src.rpm

Description:
bfs is a breadth-first version of the UNIX find(1) command.

bfs supports almost every feature from every major find(1)
implementation, so your existing command lines should work as-is.
It also adds some features of its own, such as a more forgiving
command line parser and some additional options.

Fedora Account System Username: xfgusta

Comment 1 Benson Muite 2022-06-05 08:23:55 UTC
Unofficial review

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "BSD 0-Clause License", "Unknown or generated", "*No copyright*
     BSD 0-Clause License". 331 files have unknown license. Detailed output
     of licensecheck in
     /home/FedoraPackaging/libkrunfw/bfs/2087264-bfs/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[?]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/share/bash-
     completion(fd-find, dnf, repo, wlogout, task, stress-ng, stratis-cli,
     fedora-update-feedback, ModemManager, mdbtools, just,
     python3-streamlink, rpmspectool, tracker, datamash, ffsend,
     devscripts, azure-cli, doctl, dotnet-host, swayidle, pdfgrep,
     osslsigncode, buildah, bodhi-client, chocolate-doom, cpu-x, playerctl,
     linode-cli, ripgrep, python-django-bash-completion, exercism, darcs,
     zypper, pcp, etckeeper, yadifa, maven, httpie, driverctl, git-delta,
     vagrant, exa, dub, croc, monotone, gopass, alacritty, python3-tqdm,
     zola, mercurial, lxi-tools, golang-github-tdewolff-minify, poetry,
     bodhi-cli, policycoreutils, clevis, reprepro, eg, tldr, source-
     highlight, lmms, python3-trezor, zeitgeist, hstr, rubygem-ronn-ng,
     cowsay, cobbler, beaker-client, docker-compose, lightdm, skopeo, kmod,
     swaylock, rpmdevtools, falkon, mtr, bubblewrap, libmbim-utils, dosbox-
     staging, xca, breezy, gammu, bash-completion, nitrokey-app, gh,
     licensecheck, awscli, toolbox, filesystem, lxc, gpaste, git-core,
     skim, subversion, timew, flatpak, vcsh, hcloud, hyperfine, devscripts-
     checkbashisms, glib2, ldc, libqmi-utils, hashcat, chatty, restic,
     fedpkg, ethtool, nnn, smc-tools, mt-st, pbuilder, sway, yadifa-tools,
     docopt, dconf-editor, unar, calf, vultr-cli, tealdeer, tio,
     python3-catkin_tools), /usr/share/bash-completion/completions(fd-find,
     dnf, minipro, repo, wlogout, task, firejail, stress-ng, stratis-cli,
     GMT-common, fedora-update-feedback, ModemManager, mdbtools, just,
     python3-streamlink, rpmspectool, tracker, datamash, xss-lock, libnbd-
     bash-completion, nbdkit-bash-completion, ffsend, devscripts, azure-
     cli, doctl, dotnet-host, swayidle, pdfgrep, osslsigncode, nordugrid-
     arc-client, buildah, bodhi-client, chocolate-doom, cpu-x, playerctl,
     linode-cli, ripgrep, python-django-bash-completion, exercism, darcs,
     zypper, pcp, etckeeper, yadifa, maven, calibre, driverctl, httpie,
     git-delta, vagrant, exa, dub, flameshot, croc, monotone, gopass,
     alacritty, lastpass-cli, python3-tqdm, zola, mercurial, tig, lxi-
     tools, golang-github-tdewolff-minify, libappstream-glib, poetry,
     bodhi-cli, coccinelle-bash-completion, clevis, reprepro, eg, tldr,
     source-highlight, lmms, python3-trezor, zeitgeist, hstr, rubygem-ronn-
     ng, cowsay, cobbler, beaker-client, docker-compose, libguestfs-bash-
     completion, lightdm, skopeo, kmod, swaylock, rpmdevtools, falkon, mtr,
     bubblewrap, libmbim-utils, dosbox-staging, xca, breezy, gammu, bash-
     completion, nitrokey-app, gh, licensecheck, awscli, python3-pip,
     toolbox, environment-modules, filesystem, lxc, gpaste, git-core, skim,
     subversion, timew, flatpak, vcsh, hcloud, hyperfine, devscripts-
     checkbashisms, glib2, ldc, libqmi-utils, firewalld, hashcat, chatty,
     restic, fedpkg, ethtool, packit, nnn, opensc, smc-tools, mt-st,
     pbuilder, sway, yadifa-tools, docopt, kompose, dconf-editor, guestfs-
     tools-bash-completion, unar, calf, vultr-cli, tealdeer, tio,
     python3-catkin_tools), /usr/share/zsh(creds, fd-find, hyperfine, pcp,
     wlogout, snapd, etckeeper, python3-wstool, task, stratis-cli, docker-
     compose, git-delta, vagrant, exa, dub, exercism, croc, swaylock, xss-
     lock, fuzzel, hub, ffsend, gopass, alacritty, bubblewrap, zola, doctl,
     mercurial, ninja-build, polybar, sway, libinput, swayidle, jo,
     pdfgrep, pulseaudio, poetry, caddy, gh, zsh, awscli, cpu-x, catimg,
     playerctl, kde-connect, reprepro, foot, mako, ripgrep, gpaste, tldr,
     skim, profile-cleaner, vultr-cli, why3, osmium-tool, vcsh, hcloud,
     youtube-dl, curl), /usr/share/zsh/site-functions(creds, fd-find,
     wlogout, snapd, task, stratis-cli, podman, just, python3-streamlink,
     xss-lock, ffsend, arch-install-scripts, doctl, swayidle, pdfgrep,
     pulseaudio, zsh, cpu-x, playerctl, kde-connect, ripgrep, ddgr,
     exercism, curl, pcp, podman-remote, git-delta, exa, dub, flameshot,
     croc, gopass, khard, alacritty, lastpass-cli, zola, mercurial,
     libinput, poetry, reprepro, tldr, googler, osmium-tool, rubygem-ronn-
     ng, docker-compose, swaylock, fuzzel, bubblewrap, fzf, polybar, jo,
     caddy, gh, awscli, environment-modules, profile-sync-daemon, mako,
     gpaste, skim, imgp, flatpak, salt, vcsh, hcloud, youtube-dl,
     hyperfine, python3-wstool, xpanes, firewalld, restic, hub, nnn, ninja-
     build, sway, kompose, catimg, buku, foot, vultr-cli, why3, profile-
     cleaner)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[?]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 40960 bytes in 3 files.
[?]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures. https://copr.fedorainfracloud.org/coprs/xfgusta/bfs/
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: There are rpmlint messages (see attachment).
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Cannot parse rpmlint output:


Rpmlint (debuginfo)
-------------------
Cannot parse rpmlint output:



Rpmlint (installed packages)
----------------------------
Cannot parse rpmlint output:


Source checksums
----------------
https://github.com/tavianator/bfs/archive/2.6/bfs-2.6.tar.gz :
  CHECKSUM(SHA256) this package     : 5812a4c62004c851eb02e23c0b6698dbb40061ce1c
4069bb33c5b14f5361d81b
  CHECKSUM(SHA256) upstream package : 5812a4c62004c851eb02e23c0b6698dbb40061ce1c
4069bb33c5b14f5361d81b


Requires
--------
bfs (rpmlib, GLIBC filtered):
    libacl.so.1()(64bit)
    libacl.so.1(ACL_1.0)(64bit)
    libc.so.6()(64bit)
    libcap.so.2()(64bit)
    libonig.so.5()(64bit)
    rtld(GNU_HASH)

bfs-debuginfo (rpmlib, GLIBC filtered):

bfs-debugsource (rpmlib, GLIBC filtered):



Provides
--------
bfs:
    bfs
    bfs(x86-64)

bfs-debuginfo:
    bfs-debuginfo
    bfs-debuginfo(x86-64)
    debuginfo(build-id)

bfs-debugsource:
    bfs-debugsource
    bfs-debugsource(x86-64)



Generated by fedora-review 0.8.0 (e988316) last change: 2022-04-07
Command line :/usr/bin/fedora-review -b 2087264
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, C/C++, Shell-api
Disabled plugins: Java, Perl, SugarActivity, Python, R, Ocaml, fonts, Haskell, P
HP
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH


Comments

1) Perhaps change 
BuildRequires:  /usr/bin/setfacl
to
BuildRequires:  acl
as setfacl is provided by https://packages.fedoraproject.org/pkgs/acl/acl/

2) Should header files be in a devel package? See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages

3) Would be helpful to explicitly use %{_mandir}/man1/%{name}.1.gz rather than %{_mandir}/man1/%{name}.1*

Comment 2 Benson Muite 2022-06-05 17:40:56 UTC
Can ignore 2, devel package not needed since only an executable is provided, not a library.

Comment 3 Gustavo Costa 2022-06-06 01:34:53 UTC
Hi Benson. Thanks for the unofficial review.

> 1) Perhaps change 
> BuildRequires:  /usr/bin/setfacl
> to
> BuildRequires:  acl
> as setfacl is provided by https://packages.fedoraproject.org/pkgs/acl/acl/

Done!

> 2) Should header files be in a devel package? See
> https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages

As you've already noticed, the bfs package doesn't provide any header files or library.

> 3) Would be helpful to explicitly use %{_mandir}/man1/%{name}.1.gz rather
> than %{_mandir}/man1/%{name}.1*

This is the correct way. RPM will re-compress it into its preferred format when installing the man page [1]

1. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages

Comment 4 Benson Muite 2022-06-07 08:44:25 UTC
Updated unofficial review:

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "BSD 0-Clause License", "Unknown or generated", "*No copyright*
     BSD 0-Clause License". 331 files have unknown license. Detailed output
     of licensecheck in
     /home/FedoraPackaging/bfs/2087264-bfs/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[?]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/share/bash-
     completion(bodhi-client, chocolate-doom, mdbtools, calf, gpaste,
     hyperfine, rubygem-ronn-ng, exa, mtr, cpu-x, unar, devscripts-
     checkbashisms, awscli, lxi-tools, ffsend, exercism, breezy, vultr-cli,
     golang-github-tdewolff-minify, swayidle, lmms, tealdeer, subversion,
     docker-compose, monotone, maven, kmod, xca, pdfgrep, hstr,
     policycoreutils, buildah, mt-st, lightdm, skopeo, task, fedpkg,
     source-highlight, dotnet-host, hcloud, python3-streamlink, timew,
     etckeeper, zypper, doctl, git-delta, fd-find, ldc, libqmi-utils,
     docopt, driverctl, gammu, reprepro, ethtool, falkon, beaker-client,
     restic, stratis-cli, tracker, python3-tqdm, libmbim-utils, pbuilder,
     sway, mercurial, tio, eg, toolbox, python3-catkin_tools, ModemManager,
     yadifa, httpie, playerctl, glib2, just, filesystem, fedora-update-
     feedback, linode-cli, zola, cobbler, rpmdevtools, azure-cli, git-core,
     datamash, rpmspectool, vagrant, flatpak, dosbox-staging, alacritty,
     skim, licensecheck, wlogout, vcsh, swaylock, bash-completion, smc-
     tools, nitrokey-app, stress-ng, cowsay, clevis, lxc, chatty, python-
     django-bash-completion, nnn, pcp, croc, zeitgeist, hashcat, repo,
     ripgrep, devscripts, bubblewrap, dub, gh, osslsigncode, darcs,
     python3-trezor, poetry, tldr, dconf-editor, bodhi-cli, gopass, dnf,
     yadifa-tools), /usr/share/bash-completion/completions(bodhi-client,
     chocolate-doom, mdbtools, calf, gpaste, hyperfine, rubygem-ronn-ng,
     flameshot, exa, mtr, cpu-x, unar, calibre, devscripts-checkbashisms,
     awscli, lxi-tools, ffsend, exercism, breezy, libguestfs-bash-
     completion, vultr-cli, golang-github-tdewolff-minify, swayidle, lmms,
     tealdeer, subversion, docker-compose, monotone, maven, kmod, xca,
     pdfgrep, hstr, buildah, mt-st, lightdm, skopeo, task, fedpkg, source-
     highlight, dotnet-host, hcloud, python3-streamlink, timew, etckeeper,
     zypper, coccinelle-bash-completion, doctl, fd-find, git-delta, ldc,
     libqmi-utils, GMT-common, docopt, driverctl, gammu, reprepro, ethtool,
     falkon, beaker-client, libappstream-glib, libnbd-bash-completion, xss-
     lock, restic, stratis-cli, tracker, python3-tqdm, libmbim-utils,
     pbuilder, sway, mercurial, tio, eg, toolbox, python3-catkin_tools,
     ModemManager, yadifa, httpie, packit, playerctl, glib2, just,
     filesystem, fedora-update-feedback, linode-cli, zola, cobbler,
     rpmdevtools, azure-cli, git-core, tig, datamash, rpmspectool, vagrant,
     firewalld, flatpak, python3-pip, dosbox-staging, kompose, alacritty,
     skim, lastpass-cli, licensecheck, wlogout, environment-modules, vcsh,
     guestfs-tools-bash-completion, bash-completion, smc-tools, swaylock,
     nitrokey-app, stress-ng, cowsay, clevis, lxc, opensc, chatty, python-
     django-bash-completion, nnn, firejail, nordugrid-arc-client, pcp,
     croc, minipro, zeitgeist, hashcat, repo, ripgrep, devscripts,
     bubblewrap, dub, gh, osslsigncode, darcs, python3-trezor, poetry,
     tldr, dconf-editor, bodhi-cli, gopass, nbdkit-bash-completion, dnf,
     yadifa-tools), /usr/share/zsh(pdfgrep, vcsh, swaylock, polybar, curl,
     fuzzel, profile-cleaner, why3, hyperfine, gpaste, exa, jo, task,
     osmium-tool, foot, creds, cpu-x, playerctl, python3-wstool, hcloud,
     awscli, etckeeper, ninja-build, caddy, doctl, git-delta, fd-find,
     ffsend, zola, exercism, pcp, croc, snapd, vultr-cli, kde-connect,
     swayidle, mako, ripgrep, zsh, reprepro, bubblewrap, dub, gh, xss-lock,
     docker-compose, stratis-cli, poetry, tldr, catimg, vagrant, sway,
     mercurial, gopass, pulseaudio, alacritty, skim, hub, libinput,
     youtube-dl, wlogout), /usr/share/zsh/site-functions(podman-remote,
     rubygem-ronn-ng, hyperfine, gpaste, flameshot, exa, creds, cpu-x,
     awscli, ffsend, exercism, vultr-cli, swayidle, docker-compose, catimg,
     imgp, youtube-dl, pdfgrep, profile-sync-daemon, fuzzel, task, xpanes,
     python3-wstool, hcloud, python3-streamlink, doctl, git-delta, fd-find,
     kde-connect, ddgr, mako, zsh, reprepro, xss-lock, restic, stratis-cli,
     sway, mercurial, fzf, hub, jo, why3, foot, arch-install-scripts,
     playerctl, just, salt, caddy, zola, snapd, buku, firewalld, flatpak,
     kompose, pulseaudio, alacritty, skim, libinput, lastpass-cli, wlogout,
     googler, environment-modules, vcsh, swaylock, polybar, curl, profile-
     cleaner, osmium-tool, nnn, ninja-build, pcp, croc, ripgrep,
     bubblewrap, dub, gh, podman, poetry, tldr, khard, gopass)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 40960 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: There are rpmlint messages (see attachment).
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Cannot parse rpmlint output:


Rpmlint (debuginfo)
-------------------
Cannot parse rpmlint output:



Rpmlint (installed packages)
----------------------------
Cannot parse rpmlint output:


Source checksums
----------------
https://github.com/tavianator/bfs/archive/2.6/bfs-2.6.tar.gz :
  CHECKSUM(SHA256) this package     : 5812a4c62004c851eb02e23c0b6698dbb40061ce1c4069bb33c5b14f5361d81b
  CHECKSUM(SHA256) upstream package : 5812a4c62004c851eb02e23c0b6698dbb40061ce1c4069bb33c5b14f5361d81b


Requires
--------
bfs (rpmlib, GLIBC filtered):
    libacl.so.1()(64bit)
    libacl.so.1(ACL_1.0)(64bit)
    libc.so.6()(64bit)
    libcap.so.2()(64bit)
    libonig.so.5()(64bit)
    rtld(GNU_HASH)

bfs-debuginfo (rpmlib, GLIBC filtered):

bfs-debugsource (rpmlib, GLIBC filtered):



Provides
--------
bfs:
    bfs
    bfs(x86-64)

bfs-debuginfo:
    bfs-debuginfo
    bfs-debuginfo(x86-64)
    debuginfo(build-id)

bfs-debugsource:
    bfs-debugsource
    bfs-debugsource(x86-64)



Generated by fedora-review 0.8.0 (e988316) last change: 2022-04-07
Command line :/usr/bin/fedora-review -b 2087264
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, C/C++, Shell-api
Disabled plugins: Ocaml, Java, Haskell, Perl, SugarActivity, fonts, Python, R, PHP
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH


Comments:
1) Not necessary for further packaging, but maybe helpful to update what is available at:
https://copr.fedorainfracloud.org/coprs/xfgusta/bfs/

2) Not clear to me how to evaluate "Package does not own files or directories owned by other packages.", it seems ok, but an explanation on the co-owned directories is helpful.

3) Thanks for adding this to the Fedora ecosystem

Comment 5 Gustavo Costa 2022-06-08 01:57:11 UTC
> 1) Not necessary for further packaging, but maybe helpful to update what is available at:
> https://copr.fedorainfracloud.org/coprs/xfgusta/bfs/

The "BuildRequires: acl" is mostly a cosmetic change. I will update it when upstream releases a new version.

> 2) Not clear to me how to evaluate "Package does not own files or directories owned by other packages.", it seems ok, but an explanation on the co-owned directories is helpful.

Since bfs doesn't require bash or zsh -completion to work properly, there's no need to install them along with the package. But the package should own the directories they provide (/usr/share/bash-completion/completions and /usr/share/zsh/site-functions). Several packages do this and co-own these directories as well. See [1] and [2]

> 3) Thanks for adding this to the Fedora ecosystem

:)

1. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_and_directory_ownership
2. https://docs.fedoraproject.org/en-US/packaging-guidelines/UnownedDirectories/

Comment 6 Benson Muite 2022-06-08 06:27:00 UTC
Great, looks good to me.

Comment 7 Benson Muite 2022-08-10 09:17:24 UTC
Can now do official reviews. Approved.

Comment 8 Gustavo Costa 2022-08-10 10:52:43 UTC
Hi Benson.

> Can now do official reviews. Approved.

Thanks!

> Flags: None yet set (set flags) 

One more thing: in the advanced fields, you have to set the "fedora-review" flag to "+" [1]

1. https://docs.fedoraproject.org/en-US/package-maintainers/Package_Review_Process/#_reviewer

Comment 9 Benson Muite 2022-08-10 11:13:09 UTC
Thanks.

Comment 10 Gwyn Ciesla 2022-08-10 13:12:29 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/bfs


Note You need to log in before you can comment on or make changes to this bug.