Bug 2087590 - [REF] "Upload a new file to a PVC" should not open the form in a new tab
Summary: [REF] "Upload a new file to a PVC" should not open the form in a new tab
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Container Native Virtualization (CNV)
Classification: Red Hat
Component: User Experience
Version: 4.11.0
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: ---
: 4.11.0
Assignee: Tal Nisan
QA Contact: Guohua Ouyang
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-05-18 05:21 UTC by Guohua Ouyang
Modified: 2023-11-13 08:12 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-09-14 19:34:25 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
upload form (189.06 KB, image/png)
2022-05-18 05:21 UTC, Guohua Ouyang
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Github kubevirt-ui kubevirt-plugin pull 485 0 None open Bug 2087590: "Upload a new file to a PVC" should not open the form in a new tab 2022-05-26 09:50:05 UTC
Red Hat Issue Tracker CNV-18394 0 None None None 2023-11-13 08:12:49 UTC
Red Hat Product Errata RHSA-2022:6526 0 None None None 2022-09-14 19:34:35 UTC

Description Guohua Ouyang 2022-05-18 05:21:25 UTC
Created attachment 1880692 [details]
upload form

Description of problem:
"Upload a new file to a PVC" should not open the form in a new tab, better to refer 4.10 implementation, which opens the form in the same page.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Yaacov Zamir 2022-05-18 06:14:41 UTC
Gilad hi,

Can we do it in the time we have for 4.11 ?

Comment 2 Yaacov Zamir 2022-05-18 06:15:22 UTC
setting to low, because it's an RFE

Comment 3 Gilad Lekner 2022-05-23 10:07:44 UTC
@yzamir 

The 4.10 implementation is complex, with a context provider in the mix, allowing the user to navigate the console while the image is uploading.
In order to implement it our selves in 4.11, we need to copy the context provider.
does it make sense to let the user leave the customize form while the image is uploading? I dont think so

However, we can easily implement an inline uploading input, but the user won't be able to leave the page until the uploading is done.

Comment 4 Yaacov Zamir 2022-05-23 13:19:38 UTC
> we can easily implement an inline uploading input, but the user won't be able to leave the page until the uploading is done.

it's ok to not let users continue upload when leaving the page (pending some warning before leaving the page).

Comment 5 Guohua Ouyang 2022-05-27 06:54:40 UTC
> However, we can easily implement an inline uploading input, but the user won't be able to leave the page until the uploading is done.
I'm okay don't let user leave the page until the uploading is done

Comment 6 Guohua Ouyang 2022-05-30 06:48:13 UTC
verified on v4.11.0-35, one improvement can be filtering the target disk image by the valid image format in the upload open window.

Comment 10 errata-xmlrpc 2022-09-14 19:34:25 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: OpenShift Virtualization 4.11.0 Images security and bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:6526


Note You need to log in before you can comment on or make changes to this bug.