Fedora Account System
Red Hat Associate
Red Hat Customer
I want to volunteer for the maintenance of the python-docstring-parser package in Fedora. The docstring_parser is a Python library [1] used to parse Python docstrings. Currently support ReST, Google, Numpydoc-style and Epydoc docstrings. [1] https://github.com/rr-/docstring_parser Spec URL: https://github.com/pszubiak/rpms/raw/master/python-docstring-parser/python-docstring-parser.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/pszubiak/python-docstring-parser/fedora-rawhide-x86_64/04431781-python-docstring-parser/python-docstring-parser-0.14.1-1.fc37.src.rpm Description: Parse Python docstrings. Currently support ReST, Google, Numpydoc-style and Epydoc docstrings. Fedora Account System Username: pszubiak Automated Fedora Review on Copr: https://download.copr.fedorainfracloud.org/results/pszubiak/python-docstring-parser/fedora-rawhide-x86_64/04431781-python-docstring-parser/fedora-review/review.txt
I've reformatted your description to follow the https://bugzilla.redhat.com/bugzilla/enter_bug.cgi?product=Fedora&format=fedora-review template and have blocked FE-NEEDSPONSOR.
Your specfile looks pretty good! I just have a couple minor comments. > %{url}/archive/refs/tags/%{version}.tar.gz This should be %{url}/archive/%{version}/%{name}-%{version}.tar.gz. Source0 can also be shortened to Source if you'd like. RPM has supported automatic source file numbering since 4.15.x. > Summary: Parse Python docstrings. The Summary tag should not have a period. > %description > %{_description} Normally, you'd have the text of the description on a newline after the `%description` macro. However, ``` %global _description %{expand: Parse Python docstrings. Currently support ReST, Google, Numpydoc-style and Epydoc docstrings.} ``` already has a leading newline, so you want it formatted as `%description %{_description}`. The same thing applies for `%description -n python3-%{srcname}`. Regarding your sponsorship, you should send an introduction email to the devel list if you haven't already[1]. [1]: https://docs.fedoraproject.org/en-US/package-maintainers/Joining_the_Package_Maintainers/#introduce_yourself
Thank you for the review! The new SRPM URL: https://download.copr.fedorainfracloud.org/results/pszubiak/python-docstring-parser/fedora-rawhide-x86_64/04648900-python-docstring-parser/python-docstring-parser-0.14.1-1.fc37.src.rpm My introduction to the devel community: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/XQTORJADLRHEMEV5YEYAF6TGNT7UFRKH/
I'm dropping my NEEDINFO so another reviewer who has more time than me can look at this. I will come back to this later if nobody beats me to it. Generally, you shouldn't use NEEDINFO in this type of scenario, anyways.
The package looks good. License is correctly tagged, follows packaging guidelines and sources match upstream: 0f6927d45ca22a20fd7530e27cd8bbc5409d4b08c8cfbc6f30a148532d497936 python-docstring-parser-0.14.1.tar.gz It builds in mock successfully (I tested F36+). The included test suite runs successfully as well. Package is APPROVED. I'll also sponsor Piotr.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-docstring-parser