Bug 2089544 - DNF Snapper plugin fails if config isn't named "root"
Summary: DNF Snapper plugin fails if config isn't named "root"
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: dnf-plugins-extras
Version: 39
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Jan Kolarik
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-05-24 01:08 UTC by dev
Modified: 2024-02-02 02:22 UTC (History)
9 users (show)

Fixed In Version: dnf-plugins-extras-4.1.2-1.fc39 dnf-plugins-extras-4.1.2-1.fc38
Clone Of:
Environment:
Last Closed: 2024-02-02 01:13:38 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description dev 2022-05-24 01:08:31 UTC
Description of problem:

The DNF Snapper plugin fails if the snapper config for / is not named
"root". The name is currently hard-coded in the plugin source, so
there's no way to configure it.

Additionally, any systems which distribute the root filesystem over
more than one btrfs subvolume would be affected by this issue.

How reproducible: always

Steps to Reproduce:
1. Create snapper config named "example": `snapper -c example create-config /`
2. Install python3-dnf-plugin-snapper
3. Run some DNF operation, for example: `dnf install tmux`

Actual results:

The plugin fails to take pre/post snapshots, producing the following
error message:

```
snapper: creating pre_snapshot failed: error.unknown_config: org.freedesktop.DBus.Error.Failed
```

Expected results:

The plugin successfully takes a snapshot using the "example" snapper
config.

Additional info:

I've submitted a pull request on GitHub which implements a new
"snapper_config" setting for specifying which config the plugin uses
for creating snapshots:
https://github.com/rpm-software-management/dnf-plugins-extras/pull/208

This doesn't address the issue of multiple btrfs subvolumes; I'm
happy to work on that too, but I wasn't sure which configuration
syntax would be most appropriate in this case.

Comment 1 Ben Cotton 2022-11-29 18:55:41 UTC
This message is a reminder that Fedora Linux 35 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora Linux 35 on 2022-12-13.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
'version' of '35'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, change the 'version' 
to a later Fedora Linux version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora Linux 35 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora Linux, you are encouraged to change the 'version' to a later version
prior to this bug being closed.

Comment 2 Ben Cotton 2022-12-13 18:01:33 UTC
Fedora Linux 35 entered end-of-life (EOL) status on 2022-12-13.

Fedora Linux 35 is no longer maintained, which means that it
will not receive any further security or bug fix updates. As a result we
are closing this bug.

If you can reproduce this bug against a currently maintained version of Fedora Linux
please feel free to reopen this bug against that version. Note that the version
field may be hidden. Click the "Show advanced fields" button if you do not see
the version field.

If you are unable to reopen this bug, please file a new report against an
active release.

Thank you for reporting this bug and we are sorry it could not be fixed.

Comment 3 Jan Kolarik 2024-01-24 08:31:01 UTC
Reopening against current Fedora version. Fixed by the upstream PR https://github.com/rpm-software-management/dnf-plugins-extras/pull/208.

Comment 4 Fedora Update System 2024-01-24 09:38:36 UTC
FEDORA-2024-864e44643d has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2024-864e44643d

Comment 5 Fedora Update System 2024-01-24 09:38:36 UTC
FEDORA-2024-298f9c1bda has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-298f9c1bda

Comment 6 Fedora Update System 2024-01-25 01:11:43 UTC
FEDORA-2024-864e44643d has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-864e44643d`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-864e44643d

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Fedora Update System 2024-01-25 01:11:55 UTC
FEDORA-2024-298f9c1bda has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-298f9c1bda`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-298f9c1bda

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2024-02-02 01:13:38 UTC
FEDORA-2024-298f9c1bda has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 9 Fedora Update System 2024-02-02 02:22:19 UTC
FEDORA-2024-864e44643d has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.