Bug 2089789 - Add windows drivers disk is missing when template is not windows
Summary: Add windows drivers disk is missing when template is not windows
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Container Native Virtualization (CNV)
Classification: Red Hat
Component: User Experience
Version: 4.11.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: 4.11.0
Assignee: Ugo Palatucci
QA Contact: Guohua Ouyang
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-05-24 12:39 UTC by Yaacov Zamir
Modified: 2023-11-13 08:19 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-09-14 19:34:32 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github kubevirt-ui kubevirt-plugin pull 476 0 None open Bug 2089789: windows drivers checkbox for all templates 2022-05-24 14:41:41 UTC
Red Hat Issue Tracker CNV-18567 0 None None None 2023-11-13 08:19:58 UTC
Red Hat Product Errata RHSA-2022:6526 0 None None None 2022-09-14 19:34:39 UTC

Description Yaacov Zamir 2022-05-24 12:39:26 UTC 
Description of problem:
In the wizard in the "parameters" stage "add windows drivers" checkbox is missing

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. choose a template that is not a windows
2. choose to customize the vm
3. try to add a "windows driver" disk

Actual results:
no checkbox to add the drivers disk is available

Expected results:
a checkbox to add the drivers disk is available


Additional info:
we may want an easy way to add the drivers disk in the "disks" tab, in case the user want to add the disk after creating the VM
Comment 1 Yaacov Zamir 2022-05-24 14:36:13 UTC 
Note:
for windows it should be enabled by default
for other os, should be disabled by defulat
Comment 2 Guohua Ouyang 2022-05-24 23:32:35 UTC 
This is a reverse of https://bugzilla.redhat.com/show_bug.cgi?id=2083097
Why we need to show this checkbox for non-windows? Does it make sense to add a windows driver to RHEL?
Even we leave it disabled by default, it still makes users thinking whether they should check it or not.
Comment 3 Yaacov Zamir 2022-05-25 12:38:49 UTC 
(In reply to Guohua Ouyang from comment #2)
> This is a reverse of https://bugzilla.redhat.com/show_bug.cgi?id=2083097
> Why we need to show this checkbox for non-windows? Does it make sense to add
> a windows driver to RHEL?

The reasoning is to support templates that require the drivers disk, but do not have the "windows label", for example a data base template that require the drivers.

> Even we leave it disabled by default, it still makes users thinking whether
> they should check it or not.

It's called "windows driver" so a user may understand it's relevant when running a windows based payload (even if the template is not labeled with "windows")
Comment 4 Guohua Ouyang 2022-05-30 07:54:52 UTC 
verified on v4.11.0-35
Comment 7 errata-xmlrpc 2022-09-14 19:34:32 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: OpenShift Virtualization 4.11.0 Images security and bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:6526
Note You need to log in before you can comment on or make changes to this bug.