Bug 2090042 - Move the edit button close to the text for "boot order" and "ssh access"
Summary: Move the edit button close to the text for "boot order" and "ssh access"
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Container Native Virtualization (CNV)
Classification: Red Hat
Component: User Experience
Version: 4.11.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: 4.11.0
Assignee: Ugo Palatucci
QA Contact: Guohua Ouyang
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-05-25 02:10 UTC by Guohua Ouyang
Modified: 2023-11-13 08:17 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-09-14 19:34:47 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
move button close (175.16 KB, image/png)
2022-05-25 02:10 UTC, Guohua Ouyang
no flags Details
the edit button in template script tab is closing to the text (125.85 KB, image/png)
2022-06-01 04:06 UTC, Guohua Ouyang
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Github kubevirt-ui kubevirt-plugin pull 629 0 None open Bug 2090042: Move pencil icon close to text 2022-06-16 08:50:01 UTC
Red Hat Issue Tracker CNV-18605 0 None None None 2023-11-13 08:17:56 UTC
Red Hat Product Errata RHSA-2022:6526 0 None None None 2022-09-14 19:34:57 UTC

Description Guohua Ouyang 2022-05-25 02:10:06 UTC
Created attachment 1883006 [details]
move button close

Description of problem:
Move the edit button close to the text for "boot order" and "ssh access"

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 3 Yaacov Zamir 2022-05-31 15:33:41 UTC
Adding Yifat from UX

" and the correct design is what we actually have "

The correct design of the labels edit is as we have now, (like in the console)
The correct design for the ssh, and boot source is like in the console, different then what we have now.

Note this bug is for boot-order and ssh not the labels

"""
Description of problem:
Move the edit button close to the text for "boot order" and "ssh access"
"""

As Yifat mentioned the labels should stay as they are, 

the boot-order and ssh should align with the rest of the console, e.g the should be close to the edited value
(in case of the labels, the edited value is big, and we have to put the pencil where it is now)

Comment 5 Guohua Ouyang 2022-06-01 04:06:44 UTC
Created attachment 1885657 [details]
the edit button in template script tab is closing to the text

A good example about edit button is closing to its text

Comment 6 Guohua Ouyang 2022-06-01 04:08:40 UTC
(In reply to Guohua Ouyang from comment #4)
> Created attachment 1885656 [details]
> the button in VM scripts also have this problem

@Hilda, if the bug need to be fixed, could you fix the same problem in VM script tab too, or do you prefer a separate bug?

Comment 8 Guohua Ouyang 2022-06-02 00:20:05 UTC
(In reply to Guohua Ouyang from comment #5)
> Created attachment 1885657 [details]
> the edit button in template script tab is closing to the text
> 
> A good example about edit button is closing to its text

Please ignore this. Please refer to edit button on the scheduling tab as an example, the edit button should be on the text line and close to the text, not on the section's title line.

Comment 9 Guohua Ouyang 2022-06-21 04:19:09 UTC
verified on v4.11.0-64

Comment 12 errata-xmlrpc 2022-09-14 19:34:47 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: OpenShift Virtualization 4.11.0 Images security and bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:6526


Note You need to log in before you can comment on or make changes to this bug.