Bug 2090236 - Only reconcile annotations and status for clusters
Summary: Only reconcile annotations and status for clusters
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Cloud Compute
Version: 4.11
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ---
: 4.11.0
Assignee: Alexander Demicev
QA Contact: sunzhaohua
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-05-25 12:28 UTC by Alexander Demicev
Modified: 2022-08-10 11:14 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-08-10 11:14:09 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift cluster-capi-operator pull 60 0 None open Bug 2090236: Only reconcile annotations and status for clusters 2022-05-25 12:28:48 UTC
Red Hat Product Errata RHSA-2022:5069 0 None None None 2022-08-10 11:14:28 UTC

Description Alexander Demicev 2022-05-25 12:28:08 UTC
Currently, our controllers enforce some values in cluster object specs, this might not work for UPI. We should drop most of the logic and also remove validating webhooks so we can use clusters in a more flexible way.

Comment 4 sunzhaohua 2022-06-15 07:17:45 UTC
Hi@ademicev wanted to get results reviewed , do you think this is expected and any other need to check?
Tested on gcp, clusterversion 4.11.0-0.nightly-2022-06-14-032134

Cluster and InfrastructureCluter are not created, feel there is some issue here, or have I missed something?
$ oc get clusters.cluster.x-k8s.io --all-namespaces                                                     
No resources found
$ oc get gcpclusters.infrastructure.cluster.x-k8s.io --all-namespaces                             
No resources found

No cluster related webhooks.
$ oc get mutatingwebhookconfigurations -n openshift-cluster-api                   
NAME                                  WEBHOOKS   AGE
capg-mutating-webhook-configuration   2          126m
capi-mutating-webhook-configuration   5          126m
machine-api                           2          4h45m
$ oc get validatingwebhookconfigurations -n openshift-cluster-api                 
NAME                                    WEBHOOKS   AGE
alertmanagerconfigs.openshift.io        1          4h32m
autoscaling.openshift.io                2          4h47m
capg-validating-webhook-configuration   2          129m
capi-validating-webhook-configuration   6          129m
machine-api                             2          4h48m
multus.openshift.io                     1          4h49m
performance-addon-operator              1          4h51m
prometheusrules.openshift.io            1          4h32m
snapshot.storage.k8s.io                 1          4h48m

Comment 6 sunzhaohua 2022-06-21 10:09:00 UTC
As no Cluster and InfrastructureCluter are created, move this back, if I am wrong, feel free move to ON_QA

Comment 7 Alexander Demicev 2022-06-27 14:18:11 UTC
Hi,
Cluster and InfrastructureCluter are expected to be created by users, not by the operator.

Comment 8 sunzhaohua 2022-06-30 05:33:45 UTC
Move to verified, test on upi aws, create cluster and awscluster works well, annotation can be set and cluster status can be update.
clusterversion: 4.11.0-0.nightly-2022-06-28-160049

status:
  conditions:
  - lastTransitionTime: "2022-06-30T05:17:05Z"
    status: "True"
    type: Ready
  - lastTransitionTime: "2022-06-30T04:04:34Z"
    status: "True"
    type: ControlPlaneInitialized
  - lastTransitionTime: "2022-06-30T05:17:05Z"
    status: "True"
    type: InfrastructureReady
  infrastructureReady: true
  observedGeneration: 1
  phase: Provisioning

apiVersion: infrastructure.cluster.x-k8s.io/v1beta1
kind: AWSCluster
metadata:
  annotations:
    cluster.x-k8s.io/managed-by: ""
  creationTimestamp: "2022-06-30T05:17:05Z"
  generation: 1
  labels:
    cluster.x-k8s.io/cluster-name: zhsunupi-h8wbm
  name: zhsunupi-h8wbm
  namespace: openshift-cluster-api
  ownerReferences:
  - apiVersion: cluster.x-k8s.io/v1beta1
    blockOwnerDeletion: true
    controller: true
    kind: Cluster
    name: zhsunupi-h8wbm
    uid: 698ab64a-6983-4336-a38c-2f1cafce838d
  resourceVersion: "91736"
  uid: 6addd3b2-7cd3-46a9-9427-ec9fcc3731f7
spec:
  region: us-east-2
status:
  ready: true

Comment 9 errata-xmlrpc 2022-08-10 11:14:09 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: OpenShift Container Platform 4.11.0 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:5069


Note You need to log in before you can comment on or make changes to this bug.