Bug 2090707 - Review Request: cr-marcstevens-snippets - Collection of useful one-file C/C++ headers
Summary: Review Request: cr-marcstevens-snippets - Collection of useful one-file C/C++...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Ankur Sinha (FranciscoD)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2022-05-26 12:08 UTC by Ben Beasley
Modified: 2023-08-25 00:32 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-08-15 16:15:38 UTC
Type: ---
Embargoed:
sanjay.ankur: fedora-review+


Attachments (Terms of Use)

Description Ben Beasley 2022-05-26 12:08:44 UTC
Spec URL: https://music.fedorapeople.org/cr-marcstevens-snippets.spec
SRPM URL: https://music.fedorapeople.org/cr-marcstevens-snippets-0^20210722gite01ae88-0.1.fc36.src.rpm
Description:

Collection of useful one-file C/C++ headers.

Fedora Account System Username: music

These single-file, header-only libraries are packaged for unbundling purposes. Currently, the known user is libfplll, from which cr-marcstevens-snippets-thread_pool-devel can be unbundled.

Koji scratch builds:

F37: https://koji.fedoraproject.org/koji/taskinfo?taskID=87511618
F36: https://koji.fedoraproject.org/koji/taskinfo?taskID=87511788
F35: https://koji.fedoraproject.org/koji/taskinfo?taskID=87512107

Comment 1 Kalvin McCallum 2022-11-17 21:02:14 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[ ]: Package does not contain kernel modules.
[ ]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[ ]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[ ]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "MIT License", "Unknown or generated", "Boost Software License
     1.0". 4 files have unknown license. Detailed output of licensecheck in
     /home/kalvinmccallum/2090707-cr-marcstevens-snippets/licensecheck.txt
[ ]: License file installed when any subpackage combination is installed.
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
     names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[ ]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in cr-
     marcstevens-snippets-base64-devel , cr-marcstevens-snippets-
     concurrent_unordered_map-devel , cr-marcstevens-snippets-
     cpuperformance-devel , cr-marcstevens-snippets-parallel_algorithms-
     devel , cr-marcstevens-snippets-program_options-devel , cr-
     marcstevens-snippets-progress_display-devel , cr-marcstevens-snippets-
     string_algo-devel , cr-marcstevens-snippets-thread_pool-devel
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[ ]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[ ]: Package should compile and build into binary rpms on all supported
     architectures.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Cannot parse rpmlint output:


Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 8

cr-marcstevens-snippets-program_options-devel.noarch: W: no-documentation
cr-marcstevens-snippets-concurrent_unordered_map-devel.noarch: W: no-documentation
cr-marcstevens-snippets-base64-devel.noarch: W: no-documentation
cr-marcstevens-snippets-progress_display-devel.noarch: W: no-documentation
cr-marcstevens-snippets-string_algo-devel.noarch: W: no-documentation
cr-marcstevens-snippets-parallel_algorithms-devel.noarch: W: no-documentation
cr-marcstevens-snippets-thread_pool-devel.noarch: W: no-documentation
cr-marcstevens-snippets-cpuperformance-devel.noarch: W: no-documentation
 8 packages and 0 specfiles checked; 0 errors, 8 warnings, 0 badness; has taken 0.1 s 



Source checksums
----------------
https://github.com/cr-marcstevens/snippets/archive/e01ae885cdbef3af265341110a434f6fa7b8e8ac/snippets-e01ae885cdbef3af265341110a434f6fa7b8e8ac.tar.gz :
  CHECKSUM(SHA256) this package     : c19270666a42fc6192f3207d7869d1461d2579f3f83e8b7115d72be923f57571
  CHECKSUM(SHA256) upstream package : c19270666a42fc6192f3207d7869d1461d2579f3f83e8b7115d72be923f57571


Requires
--------
cr-marcstevens-snippets-base64-devel (rpmlib, GLIBC filtered):

cr-marcstevens-snippets-concurrent_unordered_map-devel (rpmlib, GLIBC filtered):

cr-marcstevens-snippets-cpuperformance-devel (rpmlib, GLIBC filtered):

cr-marcstevens-snippets-parallel_algorithms-devel (rpmlib, GLIBC filtered):

cr-marcstevens-snippets-program_options-devel (rpmlib, GLIBC filtered):

cr-marcstevens-snippets-progress_display-devel (rpmlib, GLIBC filtered):

cr-marcstevens-snippets-string_algo-devel (rpmlib, GLIBC filtered):

cr-marcstevens-snippets-thread_pool-devel (rpmlib, GLIBC filtered):



Provides
--------
cr-marcstevens-snippets-base64-devel:
    cr-marcstevens-snippets-base64-devel
    cr-marcstevens-snippets-base64-static

cr-marcstevens-snippets-concurrent_unordered_map-devel:
    cr-marcstevens-snippets-concurrent_unordered_map-devel
    cr-marcstevens-snippets-concurrent_unordered_map-static

cr-marcstevens-snippets-cpuperformance-devel:
    cr-marcstevens-snippets-cpuperformance-devel
    cr-marcstevens-snippets-cpuperformance-static

cr-marcstevens-snippets-parallel_algorithms-devel:
    cr-marcstevens-snippets-parallel_algorithms-devel
    cr-marcstevens-snippets-parallel_algorithms-static

cr-marcstevens-snippets-program_options-devel:
    cr-marcstevens-snippets-program_options-devel
    cr-marcstevens-snippets-program_options-static

cr-marcstevens-snippets-progress_display-devel:
    cr-marcstevens-snippets-progress_display-devel
    cr-marcstevens-snippets-progress_display-static

cr-marcstevens-snippets-string_algo-devel:
    cr-marcstevens-snippets-string_algo-devel
    cr-marcstevens-snippets-string_algo-static

cr-marcstevens-snippets-thread_pool-devel:
    cr-marcstevens-snippets-thread_pool-devel
    cr-marcstevens-snippets-thread_pool-static



Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23
Command line :/usr/bin/fedora-review -b 2090707
Buildroot used: fedora-rawhide-x86_64
Active plugins: C/C++, Shell-api, Generic
Disabled plugins: Ocaml, fonts, Python, SugarActivity, Perl, Haskell, Java, PHP, R
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

Comment 2 Ben Beasley 2023-03-13 02:28:04 UTC
I have updated the spec file to switch to SPDX and include the BSL-1.0 license text for the progress_display snippet.

Updated spec URL: https://music.fedorapeople.org/20230312/cr-marcstevens-snippets.spec
Updated SRPM URL: https://music.fedorapeople.org/20230312/cr-marcstevens-snippets-0^20210722gite01ae88-0.1.fc37.src.rpm

Comment 4 Ankur Sinha (FranciscoD) 2023-08-15 09:31:52 UTC
LGTM, XXX APPROVED XXX

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[-]: Provides: bundled(gnulib) in place as required.
     Note: Sources not installed
[x]: Package does not contain kernel modules.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Package does not contain any libtool archives (.la)
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "MIT License", "*No copyright* Boost Software License 1.0",
     "Unknown or generated", "Boost Software License 1.0". 4 files have
     unknown license. Detailed output of licensecheck in
     /home/asinha/dump/fedora-reviews/2090707-cr-marcstevens-
     snippets/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in cr-
     marcstevens-snippets-base64-devel , cr-marcstevens-snippets-
     concurrent_unordered_map-devel , cr-marcstevens-snippets-
     cpuperformance-devel , cr-marcstevens-snippets-parallel_algorithms-
     devel , cr-marcstevens-snippets-program_options-devel , cr-
     marcstevens-snippets-progress_display-devel , cr-marcstevens-snippets-
     string_algo-devel , cr-marcstevens-snippets-thread_pool-devel
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: cr-marcstevens-snippets-base64-devel-0^20210722gite01ae88-0.1.fc40.noarch.rpm
          cr-marcstevens-snippets-concurrent_unordered_map-devel-0^20210722gite01ae88-0.1.fc40.noarch.rpm
          cr-marcstevens-snippets-cpuperformance-devel-0^20210722gite01ae88-0.1.fc40.noarch.rpm
          cr-marcstevens-snippets-parallel_algorithms-devel-0^20210722gite01ae88-0.1.fc40.noarch.rpm
          cr-marcstevens-snippets-program_options-devel-0^20210722gite01ae88-0.1.fc40.noarch.rpm
          cr-marcstevens-snippets-progress_display-devel-0^20210722gite01ae88-0.1.fc40.noarch.rpm
          cr-marcstevens-snippets-string_algo-devel-0^20210722gite01ae88-0.1.fc40.noarch.rpm
          cr-marcstevens-snippets-thread_pool-devel-0^20210722gite01ae88-0.1.fc40.noarch.rpm
          cr-marcstevens-snippets-0^20210722gite01ae88-0.1.fc40.src.rpm
=========================================================================== rpmlint session starts ==========================================================================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpl3nrg412')]
checks: 31, packages: 9

cr-marcstevens-snippets-base64-devel.noarch: W: no-documentation
cr-marcstevens-snippets-concurrent_unordered_map-devel.noarch: W: no-documentation
cr-marcstevens-snippets-cpuperformance-devel.noarch: W: no-documentation
cr-marcstevens-snippets-parallel_algorithms-devel.noarch: W: no-documentation
cr-marcstevens-snippets-program_options-devel.noarch: W: no-documentation
cr-marcstevens-snippets-progress_display-devel.noarch: W: no-documentation
cr-marcstevens-snippets-string_algo-devel.noarch: W: no-documentation
cr-marcstevens-snippets-thread_pool-devel.noarch: W: no-documentation
============================================ 9 packages and 0 specfiles checked; 0 errors, 8 warnings, 0 badness; has taken 0.4 s ===========================================




Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 8

cr-marcstevens-snippets-cpuperformance-devel.noarch: W: no-documentation
cr-marcstevens-snippets-progress_display-devel.noarch: W: no-documentation
cr-marcstevens-snippets-string_algo-devel.noarch: W: no-documentation
cr-marcstevens-snippets-parallel_algorithms-devel.noarch: W: no-documentation
cr-marcstevens-snippets-thread_pool-devel.noarch: W: no-documentation
cr-marcstevens-snippets-program_options-devel.noarch: W: no-documentation
cr-marcstevens-snippets-base64-devel.noarch: W: no-documentation
cr-marcstevens-snippets-concurrent_unordered_map-devel.noarch: W: no-documentation
 8 packages and 0 specfiles checked; 0 errors, 8 warnings, 0 badness; has taken 0.0 s 



Source checksums
----------------
https://www.boost.org/LICENSE_1_0.txt :
  CHECKSUM(SHA256) this package     : c9bff75738922193e67fa726fa225535870d2aa1059f91452c411736284ad566
  CHECKSUM(SHA256) upstream package : c9bff75738922193e67fa726fa225535870d2aa1059f91452c411736284ad566
https://github.com/cr-marcstevens/snippets/archive/e01ae885cdbef3af265341110a434f6fa7b8e8ac/snippets-e01ae885cdbef3af265341110a434f6fa7b8e8ac.tar.gz :
  CHECKSUM(SHA256) this package     : c19270666a42fc6192f3207d7869d1461d2579f3f83e8b7115d72be923f57571
  CHECKSUM(SHA256) upstream package : c19270666a42fc6192f3207d7869d1461d2579f3f83e8b7115d72be923f57571


Requires
--------
cr-marcstevens-snippets-base64-devel (rpmlib, GLIBC filtered):

cr-marcstevens-snippets-concurrent_unordered_map-devel (rpmlib, GLIBC filtered):

cr-marcstevens-snippets-cpuperformance-devel (rpmlib, GLIBC filtered):

cr-marcstevens-snippets-parallel_algorithms-devel (rpmlib, GLIBC filtered):

cr-marcstevens-snippets-program_options-devel (rpmlib, GLIBC filtered):

cr-marcstevens-snippets-progress_display-devel (rpmlib, GLIBC filtered):

cr-marcstevens-snippets-string_algo-devel (rpmlib, GLIBC filtered):

cr-marcstevens-snippets-thread_pool-devel (rpmlib, GLIBC filtered):



Provides
--------
cr-marcstevens-snippets-base64-devel:
    cr-marcstevens-snippets-base64-devel
    cr-marcstevens-snippets-base64-static

cr-marcstevens-snippets-concurrent_unordered_map-devel:
    cr-marcstevens-snippets-concurrent_unordered_map-devel
    cr-marcstevens-snippets-concurrent_unordered_map-static

cr-marcstevens-snippets-cpuperformance-devel:
    cr-marcstevens-snippets-cpuperformance-devel
    cr-marcstevens-snippets-cpuperformance-static

cr-marcstevens-snippets-parallel_algorithms-devel:
    cr-marcstevens-snippets-parallel_algorithms-devel
    cr-marcstevens-snippets-parallel_algorithms-static

cr-marcstevens-snippets-program_options-devel:
    cr-marcstevens-snippets-program_options-devel
    cr-marcstevens-snippets-program_options-static

cr-marcstevens-snippets-progress_display-devel:
    cr-marcstevens-snippets-progress_display-devel
    cr-marcstevens-snippets-progress_display-static

cr-marcstevens-snippets-string_algo-devel:
    cr-marcstevens-snippets-string_algo-devel
    cr-marcstevens-snippets-string_algo-static

cr-marcstevens-snippets-thread_pool-devel:
    cr-marcstevens-snippets-thread_pool-devel
    cr-marcstevens-snippets-thread_pool-static



Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review -b 2090707
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Python, Haskell, SugarActivity, Ocaml, R, Perl, PHP, fonts, Java
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH



Kalvin, are you looking to get sponsored as a package maintainer and so doing informal reviews? I think you ran fedora-review on the package, but you must also go through all the unmarked points manually and address them. See my review here, for example ^.

Comment 5 Ben Beasley 2023-08-15 13:40:56 UTC
Thank you for the review!

Comment 6 Fedora Admin user for bugzilla script actions 2023-08-15 13:41:29 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/cr-marcstevens-snippets

Comment 7 Fedora Update System 2023-08-15 16:09:41 UTC
FEDORA-2023-f224830780 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-f224830780

Comment 8 Fedora Update System 2023-08-15 16:15:38 UTC
FEDORA-2023-f224830780 has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 9 Fedora Update System 2023-08-15 16:35:10 UTC
FEDORA-2023-679622e8d9 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-679622e8d9

Comment 10 Fedora Update System 2023-08-15 16:36:37 UTC
FEDORA-2023-679622e8d9 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 11 Fedora Update System 2023-08-15 19:30:33 UTC
FEDORA-2023-81f72f3298 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-81f72f3298

Comment 12 Fedora Update System 2023-08-15 19:30:37 UTC
FEDORA-2023-e9c710350b has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2023-e9c710350b

Comment 13 Fedora Update System 2023-08-16 02:06:04 UTC
FEDORA-2023-e9c710350b has been pushed to the Fedora 37 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-e9c710350b`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-e9c710350b

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2023-08-16 02:54:33 UTC
FEDORA-2023-81f72f3298 has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-81f72f3298`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-81f72f3298

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 15 Fedora Update System 2023-08-16 13:41:30 UTC
FEDORA-EPEL-2023-82e833a6f5 has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-82e833a6f5

Comment 16 Fedora Update System 2023-08-17 00:40:25 UTC
FEDORA-EPEL-2023-82e833a6f5 has been pushed to the Fedora EPEL 9 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-82e833a6f5

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 17 Fedora Update System 2023-08-24 01:31:26 UTC
FEDORA-2023-81f72f3298 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 18 Fedora Update System 2023-08-24 02:37:13 UTC
FEDORA-2023-e9c710350b has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 19 Fedora Update System 2023-08-25 00:32:23 UTC
FEDORA-EPEL-2023-82e833a6f5 has been pushed to the Fedora EPEL 9 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.